* Re: [PATCH] Add touchscreen platform data for the Schneider SCT101CTM tablet
[not found] <VI1PR10MB2574F4636A90613136ACF4BED86B0@VI1PR10MB2574.EURPRD10.PROD.OUTLOOK.COM>
@ 2019-10-23 16:08 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2019-10-23 16:08 UTC (permalink / raw)
To: Daniel Gorbea Ainz
Cc: dvhart, andy, linux-input, platform-driver-x86, linux-kernel
Hi,
On 23-10-2019 17:23, Daniel Gorbea Ainz wrote:
> Add touchscreen platform data for the Schneider SCT101CTM tablet
>
> Signed-off-by: Daniel Gorbea <danielgorbea@hotmail.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Daniel, I received your patch just fine, shall I resend
it to the list for you ?
Regards,
Hans
> ---
> drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 1c7d8324f..8baaf0dfa 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -498,6 +498,24 @@ static const struct ts_dmi_data pov_mobii_wintab_p1006w_v10_data = {
> .properties = pov_mobii_wintab_p1006w_v10_props,
> };
>
> +static const struct property_entry schneider_sct101ctm_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> + PROPERTY_ENTRY_STRING("firmware-name",
> + "gsl1680-schneider-sct101ctm.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct ts_dmi_data schneider_sct101ctm_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = schneider_sct101ctm_props,
> +};
> +
> static const struct property_entry teclast_x3_plus_props[] = {
> PROPERTY_ENTRY_U32("touchscreen-size-x", 1980),
> PROPERTY_ENTRY_U32("touchscreen-size-y", 1500),
> @@ -908,6 +926,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> DMI_EXACT_MATCH(DMI_BOARD_NAME, "0E57"),
> },
> },
> + {
> + /* Schneider SCT101CTM */
> + .driver_data = (void *)&schneider_sct101ctm_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Default string"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "SCT101CTM"),
> + },
> + },
> {
> /* Teclast X3 Plus */
> .driver_data = (void *)&teclast_x3_plus_data,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add touchscreen platform data for the Schneider SCT101CTM tablet
@ 2019-10-23 16:08 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2019-10-23 16:08 UTC (permalink / raw)
To: Daniel Gorbea Ainz
Cc: dvhart, andy, linux-input, platform-driver-x86, linux-kernel
Hi,
On 23-10-2019 17:23, Daniel Gorbea Ainz wrote:
> Add touchscreen platform data for the Schneider SCT101CTM tablet
>
> Signed-off-by: Daniel Gorbea <danielgorbea@hotmail.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Daniel, I received your patch just fine, shall I resend
it to the list for you ?
Regards,
Hans
> ---
> drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 1c7d8324f..8baaf0dfa 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -498,6 +498,24 @@ static const struct ts_dmi_data pov_mobii_wintab_p1006w_v10_data = {
> .properties = pov_mobii_wintab_p1006w_v10_props,
> };
>
> +static const struct property_entry schneider_sct101ctm_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> + PROPERTY_ENTRY_STRING("firmware-name",
> + "gsl1680-schneider-sct101ctm.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct ts_dmi_data schneider_sct101ctm_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = schneider_sct101ctm_props,
> +};
> +
> static const struct property_entry teclast_x3_plus_props[] = {
> PROPERTY_ENTRY_U32("touchscreen-size-x", 1980),
> PROPERTY_ENTRY_U32("touchscreen-size-y", 1500),
> @@ -908,6 +926,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> DMI_EXACT_MATCH(DMI_BOARD_NAME, "0E57"),
> },
> },
> + {
> + /* Schneider SCT101CTM */
> + .driver_data = (void *)&schneider_sct101ctm_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Default string"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "SCT101CTM"),
> + },
> + },
> {
> /* Teclast X3 Plus */
> .driver_data = (void *)&teclast_x3_plus_data,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add touchscreen platform data for the Schneider SCT101CTM tablet
2019-10-23 16:08 ` Hans de Goede
@ 2019-10-23 16:15 ` Andy Shevchenko
-1 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2019-10-23 16:15 UTC (permalink / raw)
To: Hans de Goede
Cc: Daniel Gorbea Ainz, dvhart, andy, linux-input,
platform-driver-x86, linux-kernel
On Wed, Oct 23, 2019 at 7:08 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 23-10-2019 17:23, Daniel Gorbea Ainz wrote:
> > Add touchscreen platform data for the Schneider SCT101CTM tablet
> >
> > Signed-off-by: Daniel Gorbea <danielgorbea@hotmail.com>
>
> Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Daniel, I received your patch just fine, shall I resend
> it to the list for you ?
What list? Everything seems okay to me.
I don't see it in patchwork, though.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add touchscreen platform data for the Schneider SCT101CTM tablet
@ 2019-10-23 16:15 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2019-10-23 16:15 UTC (permalink / raw)
To: Hans de Goede
Cc: Daniel Gorbea Ainz, dvhart, andy, linux-input,
platform-driver-x86, linux-kernel
On Wed, Oct 23, 2019 at 7:08 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 23-10-2019 17:23, Daniel Gorbea Ainz wrote:
> > Add touchscreen platform data for the Schneider SCT101CTM tablet
> >
> > Signed-off-by: Daniel Gorbea <danielgorbea@hotmail.com>
>
> Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Daniel, I received your patch just fine, shall I resend
> it to the list for you ?
What list? Everything seems okay to me.
I don't see it in patchwork, though.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add touchscreen platform data for the Schneider SCT101CTM tablet
2019-10-23 16:15 ` Andy Shevchenko
@ 2019-10-23 16:18 ` Hans de Goede
-1 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2019-10-23 16:18 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Daniel Gorbea Ainz, dvhart, andy, linux-input,
platform-driver-x86, linux-kernel
Hi,
On 23-10-2019 18:15, Andy Shevchenko wrote:
> On Wed, Oct 23, 2019 at 7:08 PM Hans de Goede <hdegoede@redhat.com> wrote:
>> On 23-10-2019 17:23, Daniel Gorbea Ainz wrote:
>>> Add touchscreen platform data for the Schneider SCT101CTM tablet
>>>
>>> Signed-off-by: Daniel Gorbea <danielgorbea@hotmail.com>
>>
>> Patch looks good to me:
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Daniel, I received your patch just fine, shall I resend
>> it to the list for you ?
>
> What list? Everything seems okay to me.
> I don't see it in patchwork, though.
Right, Daniel replied that vger@kernel.org did not like his email/patch
so it makes sense that patchwork has not picked it up.
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add touchscreen platform data for the Schneider SCT101CTM tablet
@ 2019-10-23 16:18 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2019-10-23 16:18 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Daniel Gorbea Ainz, dvhart, andy, linux-input,
platform-driver-x86, linux-kernel
Hi,
On 23-10-2019 18:15, Andy Shevchenko wrote:
> On Wed, Oct 23, 2019 at 7:08 PM Hans de Goede <hdegoede@redhat.com> wrote:
>> On 23-10-2019 17:23, Daniel Gorbea Ainz wrote:
>>> Add touchscreen platform data for the Schneider SCT101CTM tablet
>>>
>>> Signed-off-by: Daniel Gorbea <danielgorbea@hotmail.com>
>>
>> Patch looks good to me:
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Daniel, I received your patch just fine, shall I resend
>> it to the list for you ?
>
> What list? Everything seems okay to me.
> I don't see it in patchwork, though.
Right, Daniel replied that vger@kernel.org did not like his email/patch
so it makes sense that patchwork has not picked it up.
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-23 16:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <VI1PR10MB2574F4636A90613136ACF4BED86B0@VI1PR10MB2574.EURPRD10.PROD.OUTLOOK.COM>
2019-10-23 16:08 ` [PATCH] Add touchscreen platform data for the Schneider SCT101CTM tablet Hans de Goede
2019-10-23 16:08 ` Hans de Goede
2019-10-23 16:15 ` Andy Shevchenko
2019-10-23 16:15 ` Andy Shevchenko
2019-10-23 16:18 ` Hans de Goede
2019-10-23 16:18 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.