* [PATCH] ARM: zynq: Fix refcount leak in zynq_early_slcr_init
@ 2022-11-29 14:05 ` Qiheng Lin
0 siblings, 0 replies; 4+ messages in thread
From: Qiheng Lin @ 2022-11-29 14:05 UTC (permalink / raw)
Cc: michal.simek, linux-arm-kernel, linux-kernel, Qiheng Lin
of_find_compatible_node() returns a node pointer with refcount incremented,
we should use of_node_put() on error path.
Add missing of_node_put() to avoid refcount leak.
Fixes: 3329659df030 ("ARM: zynq: Simplify SLCR initialization")
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
---
arch/arm/mach-zynq/slcr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c
index 37707614885a..9765b3f4c2fc 100644
--- a/arch/arm/mach-zynq/slcr.c
+++ b/arch/arm/mach-zynq/slcr.c
@@ -213,6 +213,7 @@ int __init zynq_early_slcr_init(void)
zynq_slcr_regmap = syscon_regmap_lookup_by_compatible("xlnx,zynq-slcr");
if (IS_ERR(zynq_slcr_regmap)) {
pr_err("%s: failed to find zynq-slcr\n", __func__);
+ of_node_put(np);
return -ENODEV;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: zynq: Fix refcount leak in zynq_early_slcr_init
@ 2022-11-29 14:05 ` Qiheng Lin
0 siblings, 0 replies; 4+ messages in thread
From: Qiheng Lin @ 2022-11-29 14:05 UTC (permalink / raw)
Cc: michal.simek, linux-arm-kernel, linux-kernel, Qiheng Lin
of_find_compatible_node() returns a node pointer with refcount incremented,
we should use of_node_put() on error path.
Add missing of_node_put() to avoid refcount leak.
Fixes: 3329659df030 ("ARM: zynq: Simplify SLCR initialization")
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
---
arch/arm/mach-zynq/slcr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c
index 37707614885a..9765b3f4c2fc 100644
--- a/arch/arm/mach-zynq/slcr.c
+++ b/arch/arm/mach-zynq/slcr.c
@@ -213,6 +213,7 @@ int __init zynq_early_slcr_init(void)
zynq_slcr_regmap = syscon_regmap_lookup_by_compatible("xlnx,zynq-slcr");
if (IS_ERR(zynq_slcr_regmap)) {
pr_err("%s: failed to find zynq-slcr\n", __func__);
+ of_node_put(np);
return -ENODEV;
}
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: zynq: Fix refcount leak in zynq_early_slcr_init
2022-11-29 14:05 ` Qiheng Lin
@ 2022-12-07 14:42 ` Michal Simek
-1 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2022-12-07 14:42 UTC (permalink / raw)
To: Qiheng Lin; +Cc: michal.simek, linux-arm-kernel, linux-kernel
Hi,
On 11/29/22 15:05, Qiheng Lin wrote:
>
> of_find_compatible_node() returns a node pointer with refcount incremented,
> we should use of_node_put() on error path.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 3329659df030 ("ARM: zynq: Simplify SLCR initialization")
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
> ---
> arch/arm/mach-zynq/slcr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c
> index 37707614885a..9765b3f4c2fc 100644
> --- a/arch/arm/mach-zynq/slcr.c
> +++ b/arch/arm/mach-zynq/slcr.c
> @@ -213,6 +213,7 @@ int __init zynq_early_slcr_init(void)
> zynq_slcr_regmap = syscon_regmap_lookup_by_compatible("xlnx,zynq-slcr");
> if (IS_ERR(zynq_slcr_regmap)) {
> pr_err("%s: failed to find zynq-slcr\n", __func__);
> + of_node_put(np);
> return -ENODEV;
> }
>
> --
> 2.32.0
>
Applied.
Thanks,
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: zynq: Fix refcount leak in zynq_early_slcr_init
@ 2022-12-07 14:42 ` Michal Simek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2022-12-07 14:42 UTC (permalink / raw)
To: Qiheng Lin; +Cc: michal.simek, linux-arm-kernel, linux-kernel
Hi,
On 11/29/22 15:05, Qiheng Lin wrote:
>
> of_find_compatible_node() returns a node pointer with refcount incremented,
> we should use of_node_put() on error path.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 3329659df030 ("ARM: zynq: Simplify SLCR initialization")
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
> ---
> arch/arm/mach-zynq/slcr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c
> index 37707614885a..9765b3f4c2fc 100644
> --- a/arch/arm/mach-zynq/slcr.c
> +++ b/arch/arm/mach-zynq/slcr.c
> @@ -213,6 +213,7 @@ int __init zynq_early_slcr_init(void)
> zynq_slcr_regmap = syscon_regmap_lookup_by_compatible("xlnx,zynq-slcr");
> if (IS_ERR(zynq_slcr_regmap)) {
> pr_err("%s: failed to find zynq-slcr\n", __func__);
> + of_node_put(np);
> return -ENODEV;
> }
>
> --
> 2.32.0
>
Applied.
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-07 14:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-29 14:05 [PATCH] ARM: zynq: Fix refcount leak in zynq_early_slcr_init Qiheng Lin
2022-11-29 14:05 ` Qiheng Lin
2022-12-07 14:42 ` Michal Simek
2022-12-07 14:42 ` Michal Simek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.