* [PATCH] wifi: legacy: rndis_wlan: clean up a type issue
@ 2023-03-22 9:07 Dan Carpenter
2023-03-31 14:48 ` wifi: " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-03-22 9:07 UTC (permalink / raw)
To: Jussi Kivilinna; +Cc: Kalle Valo, linux-wireless, kernel-janitors
The rndis_bss_info_update() returns type bool. Change the NULL
returns to false.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/net/wireless/legacy/rndis_wlan.c | 6 +++++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/legacy/rndis_wlan.c b/drivers/net/wireless/legacy/rndis_wlan.c
index bf72e5fd39cf..49e846a0fafd 100644
--- a/drivers/net/wireless/legacy/rndis_wlan.c
+++ b/drivers/net/wireless/legacy/rndis_wlan.c
@@ -1972,7 +1972,7 @@ static bool rndis_bss_info_update(struct usbnet *usbdev,
if (bssid_len < sizeof(struct ndis_80211_bssid_ex) +
sizeof(struct ndis_80211_fixed_ies))
- return NULL;
+ return false;
fixed = (struct ndis_80211_fixed_ies *)bssid->ies;
@@ -1981,13 +1981,13 @@ static bool rndis_bss_info_update(struct usbnet *usbdev,
(int)le32_to_cpu(bssid->ie_length));
ie_len -= sizeof(struct ndis_80211_fixed_ies);
if (ie_len < 0)
- return NULL;
+ return false;
/* extract data for cfg80211_inform_bss */
channel = ieee80211_get_channel(priv->wdev.wiphy,
KHZ_TO_MHZ(le32_to_cpu(bssid->config.ds_config)));
if (!channel)
- return NULL;
+ return false;
signal = level_to_qual(le32_to_cpu(bssid->rssi));
timestamp = le64_to_cpu(*(__le64 *)fixed->timestamp);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: wifi: rndis_wlan: clean up a type issue
2023-03-22 9:07 [PATCH] wifi: legacy: rndis_wlan: clean up a type issue Dan Carpenter
@ 2023-03-31 14:48 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2023-03-31 14:48 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jussi Kivilinna, linux-wireless, kernel-janitors
Dan Carpenter <error27@gmail.com> wrote:
> The rndis_bss_info_update() returns type bool. Change the NULL
> returns to false.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Patch applied to wireless-next.git, thanks.
703f15b6dce1 wifi: rndis_wlan: clean up a type issue
--
https://patchwork.kernel.org/project/linux-wireless/patch/d1f250a3-653a-497d-9c92-12dd628b7927@kili.mountain/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-31 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 9:07 [PATCH] wifi: legacy: rndis_wlan: clean up a type issue Dan Carpenter
2023-03-31 14:48 ` wifi: " Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.