[PATCH 3/3] staging: vt6655: lines should not end with a parentheses

[PATCH 3/3] staging: vt6655: lines should not end with a parentheses

[Vatsala Narang]

Adjust code to fix the style issue-lines should not end with a
parentheses

Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
 drivers/staging/vt6655/rf.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index 6b8a69df509d..e61051076d87 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -756,11 +756,8 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
  * Return Value: true if succeeded; false if failed.
  *
  */
-bool RFbSetPower(
-	struct vnt_private *priv,
-	unsigned int rate,
-	u16 uCH
-)
+bool RFbSetPower(struct vnt_private *priv, unsigned int rate,
+		 u16 uCH)
 {
 	bool ret = true;
 	unsigned char byPwr = 0;
@@ -895,10 +892,8 @@ bool RFbRawSetPower(
  *
  */
 void
-RFvRSSITodBm(
-	struct vnt_private *priv,
-	unsigned char byCurrRSSI,
-	long *pldBm
+RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
+	     long *pldBm
 	)
 {
 	unsigned char byIdx = (((byCurrRSSI & 0xC0) >> 6) & 0x03);
-- 
2.17.1

Re: [Outreachy kernel] [PATCH 3/3] staging: vt6655: lines should not end with a parentheses

[Julia Lawall]

On Fri, 22 Mar 2019, Vatsala Narang wrote:

> Adjust code to fix the style issue-lines should not end with a
> parentheses
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
>  drivers/staging/vt6655/rf.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
> index 6b8a69df509d..e61051076d87 100644
> --- a/drivers/staging/vt6655/rf.c
> +++ b/drivers/staging/vt6655/rf.c
> @@ -756,11 +756,8 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
>   * Return Value: true if succeeded; false if failed.
>   *
>   */
> -bool RFbSetPower(
> -	struct vnt_private *priv,
> -	unsigned int rate,
> -	u16 uCH
> -)
> +bool RFbSetPower(struct vnt_private *priv, unsigned int rate,
> +		 u16 uCH)

You can put the whol thing on one line.

>  {
>  	bool ret = true;
>  	unsigned char byPwr = 0;
> @@ -895,10 +892,8 @@ bool RFbRawSetPower(
>   *
>   */
>  void
> -RFvRSSITodBm(
> -	struct vnt_private *priv,
> -	unsigned char byCurrRSSI,
> -	long *pldBm
> +RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
> +	     long *pldBm
>  	)

Perhaps here too.  In any case the ) on a line by itself is not nice at
all.

If it doesn't fit on one line, them it looks like pldBm could be just dBm.
The pl seems to represent "pointer long".  If you need to do that, then
you could make a series with that change first.

julia

>  {
>  	unsigned char byIdx = (((byCurrRSSI & 0xC0) >> 6) & 0x03);
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190321214056.15963-1-vatsalanarang%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH 3/3] staging: vt6655: lines should not end with a parentheses

[Vatsala Narang]

[-- Attachment #1.1: Type: text/plain, Size: 330 bytes --]


> -bool RFbSetPower( 

> > -        struct vnt_private *priv, 
> > -        unsigned int rate, 
> > -        u16 uCH 
> > -) 
> > +bool RFbSetPower(struct vnt_private *priv, unsigned int rate, 
> > +                 u16 uCH) 
>
> You can put the whol thing on one line. 
>
>
> okay I will  add this change in v2
thanks,
Vatsala


[-- Attachment #1.2: Type: text/html, Size: 632 bytes --]