* [Qemu-devel] [PATCH] Document mon's pretty parameter
@ 2017-11-13 18:27 Vicente Jimenez Aguilar
2017-11-13 19:33 ` John Snow
0 siblings, 1 reply; 2+ messages in thread
From: Vicente Jimenez Aguilar @ 2017-11-13 18:27 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Vicente Jimenez Aguilar
---
qemu-options.hx | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 3728e9b4dd..f06002689d 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3477,11 +3477,12 @@ Like -qmp but uses pretty JSON formatting.
ETEXI
DEF("mon", HAS_ARG, QEMU_OPTION_mon, \
- "-mon [chardev=]name[,mode=readline|control]\n", QEMU_ARCH_ALL)
+ "-mon [chardev=]name[,mode=readline|control][,pretty[=on|off]]\n", QEMU_ARCH_ALL)
STEXI
-@item -mon [chardev=]name[,mode=readline|control]
+@item -mon [chardev=]name[,mode=readline|control][,pretty[=on|off]]
@findex -mon
-Setup monitor on chardev @var{name}.
+Setup monitor on chardev @var{name}. @code{pretty} turn on JSON pretty printing
+easing human reading and debugging.
ETEXI
DEF("debugcon", HAS_ARG, QEMU_OPTION_debugcon, \
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Document mon's pretty parameter
2017-11-13 18:27 [Qemu-devel] [PATCH] Document mon's pretty parameter Vicente Jimenez Aguilar
@ 2017-11-13 19:33 ` John Snow
0 siblings, 0 replies; 2+ messages in thread
From: John Snow @ 2017-11-13 19:33 UTC (permalink / raw)
To: Vicente Jimenez Aguilar, qemu-devel; +Cc: qemu-trivial, Markus Armbruster
Vicente,
Thanks for helping to improve our documentation.
On 11/13/2017 01:27 PM, Vicente Jimenez Aguilar wrote:
> ---
This patch is missing a signed-off-by line, which we require for
contributions to the project. If you'd like, you can reply to your patch
email to add said line if further edits to the patch aren't required.
[See https://wiki.qemu.org/Contribute/SubmitAPatch; this page is very
long, so here's the relevant excerpt: "You must provide a Signed-off-by:
line (this is a hard requirement because it's how you say "I'm legally
okay to contribute this and happy for it to go into QEMU", modeled after
the Linux kernel policy.) git commit -s or git format-patch -s will add
one."]
Every patch also needs a commit message of some kind, something akin to:
"Documentation: document pretty parameter for mon option"
> qemu-options.hx | 7 ++++---> 1 file changed, 4 insertions(+), 3 deletions(-)> > diff --git
a/qemu-options.hx b/qemu-options.hx> index 3728e9b4dd..f06002689d
100644> --- a/qemu-options.hx> +++ b/qemu-options.hx> @@ -3477,11
+3477,12 @@ Like -qmp but uses pretty JSON formatting.> ETEXI> >
DEF("mon", HAS_ARG, QEMU_OPTION_mon, \> - "-mon
[chardev=]name[,mode=readline|control]\n", QEMU_ARCH_ALL)> + "-mon
[chardev=]name[,mode=readline|control][,pretty[=on|off]]\n",
QEMU_ARCH_ALL)> STEXI> -@item -mon
[chardev=]name[,mode=readline|control]> +@item -mon
[chardev=]name[,mode=readline|control][,pretty[=on|off]]> @findex -mon>
-Setup monitor on chardev @var{name}.> +Setup monitor on chardev
@var{name}. @code{pretty} turn on JSON pretty printing> +easing human
reading and debugging.> ETEXI> > DEF("debugcon", HAS_ARG,
QEMU_OPTION_debugcon, \>
I'm not sure if any other changes are needed or not; it looks OK to me
based on vl.c:2522 where the option is added at runtime.
Thanks,
John
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-13 19:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-13 18:27 [Qemu-devel] [PATCH] Document mon's pretty parameter Vicente Jimenez Aguilar
2017-11-13 19:33 ` John Snow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.