All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
	Laszlo Ersek <lersek@redhat.com>,
	qemu-devel@nongnu.org
Cc: mst@redhat.com, pbonzini@redhat.com, ehabkost@redhat.com,
	Igor Mammedov <imammedo@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole
Date: Thu, 19 Oct 2017 16:34:46 +0300	[thread overview]
Message-ID: <d231ac0a-bb7d-78aa-ddb4-8048cc7bdfd8@redhat.com> (raw)
In-Reply-To: <1508418225.18146.1.camel@redhat.com>

On 19/10/2017 16:03, Gerd Hoffmann wrote:
>    Hi,
> 
>>    - commit 39848901818 pc: limit 64 bit hole to 2G by default
>>    shows us QEMU had the 64bit PCI hole, so it is a regression.
> 
> commit message says:
> 
> <quote>
>      It turns out that some 32 bit windows guests crash
>      if 64 bit PCI hole size is >2G.
> </quote>
> 
> Why this suddenly isn't a problem any more?
> 

I suppose it is, so we need a way to turn it "off".

> Also: how about just using the existing pci_hole64_size property?
> 

This is how I started, however Eduardo and (and maybe Michael ?)
where against letting the upper management software to deal with
such a low low level detail. They simply can't take such a decision.
This is why the property you mentioned is not ever linked
in code anywhere! It is simply not implemented and not used.

What about renaming the added compat property
from x-pci-hole64-fix to pci-hole64? Users using 32-bit Windows
guests having the mentioned issue guests will disable it.

Thanks,
Marcel

> cheers,
>    Gerd
> 

  reply	other threads:[~2017-10-19 13:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-18  9:58 [Qemu-devel] [PATCH] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole Marcel Apfelbaum
2017-10-18 10:45 ` Igor Mammedov
2017-10-18 10:57   ` Marcel Apfelbaum
2017-10-18 11:40 ` Laszlo Ersek
2017-10-19  9:30   ` Marcel Apfelbaum
2017-10-19 10:41     ` Laszlo Ersek
2017-10-19 11:29       ` Marcel Apfelbaum
2017-10-19 11:52         ` Laszlo Ersek
2017-10-19 13:03     ` Gerd Hoffmann
2017-10-19 13:34       ` Marcel Apfelbaum [this message]
2017-10-20  6:55         ` Gerd Hoffmann
2017-10-20  9:32           ` Laszlo Ersek
2017-10-20 10:59             ` Gerd Hoffmann
2017-10-20 14:06               ` Marcel Apfelbaum
2017-10-20 13:47           ` Marcel Apfelbaum
2017-10-23  5:45             ` Gerd Hoffmann
2017-10-23  8:46               ` Marcel Apfelbaum
2017-10-23  9:16                 ` Gerd Hoffmann
2017-10-23  9:35                   ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d231ac0a-bb7d-78aa-ddb4-8048cc7bdfd8@redhat.com \
    --to=marcel@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.