[Qemu-devel] [PATCH 0/2] qemu-iotests fixes

[Qemu-devel] [PATCH 0/2] qemu-iotests fixes

[Amador Pahim]

- Skipping test 205 for unsupported formats.
- Setting execution permission on test files.

Amador Pahim (2):
  qemu-iotests: skip test 205 for unsupported formats
  qemu-iotests: set exec permission for tests lacking it

 tests/qemu-iotests/096 | 0
 tests/qemu-iotests/124 | 0
 tests/qemu-iotests/129 | 0
 tests/qemu-iotests/132 | 0
 tests/qemu-iotests/136 | 0
 tests/qemu-iotests/139 | 0
 tests/qemu-iotests/148 | 0
 tests/qemu-iotests/152 | 0
 tests/qemu-iotests/163 | 0
 tests/qemu-iotests/205 | 3 +++
 10 files changed, 3 insertions(+)
 mode change 100644 => 100755 tests/qemu-iotests/096
 mode change 100644 => 100755 tests/qemu-iotests/124
 mode change 100644 => 100755 tests/qemu-iotests/129
 mode change 100644 => 100755 tests/qemu-iotests/132
 mode change 100644 => 100755 tests/qemu-iotests/136
 mode change 100644 => 100755 tests/qemu-iotests/139
 mode change 100644 => 100755 tests/qemu-iotests/148
 mode change 100644 => 100755 tests/qemu-iotests/152
 mode change 100644 => 100755 tests/qemu-iotests/163
 mode change 100644 => 100755 tests/qemu-iotests/205

-- 
2.14.3

[Qemu-devel] [PATCH 1/2] qemu-iotests: skip test 205 for unsupported formats

[Amador Pahim]

Using bochs or cloop, qemu-img will fail with:

  Format driver 'bochs' does not support image creation

Signed-off-by: Amador Pahim <apahim@redhat.com>
---
 tests/qemu-iotests/205 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
index e7b2eae51d..fff9be97d2 100644
--- a/tests/qemu-iotests/205
+++ b/tests/qemu-iotests/205
@@ -24,6 +24,9 @@ import iotests
 import time
 from iotests import qemu_img_create, qemu_io, filter_qemu_io, QemuIoInteractive
 
+
+iotests.verify_image_format(unsupported_fmts=['bochs', 'cloop'])
+
 nbd_sock = 'nbd_sock'
 nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock
 disk = os.path.join(iotests.test_dir, 'disk')
-- 
2.14.3

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] qemu-iotests: skip test 205 for unsupported formats

[Eric Blake]

On 03/09/2018 04:41 AM, Amador Pahim wrote:
> Using bochs or cloop, qemu-img will fail with:
> 
>    Format driver 'bochs' does not support image creation
> 
> Signed-off-by: Amador Pahim <apahim@redhat.com>
> ---
>   tests/qemu-iotests/205 | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
> index e7b2eae51d..fff9be97d2 100644
> --- a/tests/qemu-iotests/205
> +++ b/tests/qemu-iotests/205
> @@ -24,6 +24,9 @@ import iotests
>   import time
>   from iotests import qemu_img_create, qemu_io, filter_qemu_io, QemuIoInteractive
>   
> +
> +iotests.verify_image_format(unsupported_fmts=['bochs', 'cloop'])
> +
>   nbd_sock = 'nbd_sock'
>   nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock
>   disk = os.path.join(iotests.test_dir, 'disk')
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

[Qemu-devel] [PATCH 2/2] qemu-iotests: set exec permission for tests lacking it

[Amador Pahim]

Some tests are not executables. This patch sets the executable
permission for those tests lacking that.

Signed-off-by: Amador Pahim <apahim@redhat.com>
---
 tests/qemu-iotests/096 | 0
 tests/qemu-iotests/124 | 0
 tests/qemu-iotests/129 | 0
 tests/qemu-iotests/132 | 0
 tests/qemu-iotests/136 | 0
 tests/qemu-iotests/139 | 0
 tests/qemu-iotests/148 | 0
 tests/qemu-iotests/152 | 0
 tests/qemu-iotests/163 | 0
 tests/qemu-iotests/205 | 0
 10 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tests/qemu-iotests/096
 mode change 100644 => 100755 tests/qemu-iotests/124
 mode change 100644 => 100755 tests/qemu-iotests/129
 mode change 100644 => 100755 tests/qemu-iotests/132
 mode change 100644 => 100755 tests/qemu-iotests/136
 mode change 100644 => 100755 tests/qemu-iotests/139
 mode change 100644 => 100755 tests/qemu-iotests/148
 mode change 100644 => 100755 tests/qemu-iotests/152
 mode change 100644 => 100755 tests/qemu-iotests/163
 mode change 100644 => 100755 tests/qemu-iotests/205

diff --git a/tests/qemu-iotests/096 b/tests/qemu-iotests/096
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/132 b/tests/qemu-iotests/132
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/136 b/tests/qemu-iotests/136
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/139 b/tests/qemu-iotests/139
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/148 b/tests/qemu-iotests/148
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/152 b/tests/qemu-iotests/152
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/163 b/tests/qemu-iotests/163
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
old mode 100644
new mode 100755
-- 
2.14.3

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: set exec permission for tests lacking it

[Eric Blake]

On 03/09/2018 04:41 AM, Amador Pahim wrote:
> Some tests are not executables. This patch sets the executable
> permission for those tests lacking that.
> 
> Signed-off-by: Amador Pahim <apahim@redhat.com>
> ---

Duplicate of a patch already on Max's tree:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg01167.html

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org