* [trace:for-next 38/40] kernel/trace/trace_osnoise.c:1584:2: error: void function 'osnoise_init_hotplug_support' should not return a value
@ 2021-06-26 20:39 kernel test robot
2021-06-28 3:21 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2021-06-26 20:39 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 8106 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
head: 6a2cbc58d6c9d90cd74288cc497c2b45815bc064
commit: c8895e271f7994a3ecb13b8a280e39aa53879545 [38/40] trace/osnoise: Support hotplug operations
config: powerpc-randconfig-r031-20210626 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 557b101ce714e39438ba1d39c4c50b03e12fcb96)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git/commit/?id=c8895e271f7994a3ecb13b8a280e39aa53879545
git remote add trace https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
git fetch --no-tags trace for-next
git checkout c8895e271f7994a3ecb13b8a280e39aa53879545
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from kernel/trace/trace_osnoise.c:19:
In file included from include/linux/kthread.h:6:
In file included from include/linux/sched.h:14:
In file included from include/linux/pid.h:5:
In file included from include/linux/rculist.h:10:
In file included from include/linux/list.h:9:
In file included from include/linux/kernel.h:12:
In file included from include/linux/bitops.h:32:
In file included from arch/powerpc/include/asm/bitops.h:62:
arch/powerpc/include/asm/barrier.h:49:9: warning: '__lwsync' macro redefined [-Wmacro-redefined]
#define __lwsync() __asm__ __volatile__ (stringify_in_c(LWSYNC) : : :"memory")
^
<built-in>:308:9: note: previous definition is here
#define __lwsync __builtin_ppc_lwsync
^
kernel/trace/trace_osnoise.c:657:6: warning: no previous prototype for function 'osnoise_trace_irq_entry' [-Wmissing-prototypes]
void osnoise_trace_irq_entry(int id)
^
kernel/trace/trace_osnoise.c:657:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void osnoise_trace_irq_entry(int id)
^
static
kernel/trace/trace_osnoise.c:680:6: warning: no previous prototype for function 'osnoise_trace_irq_exit' [-Wmissing-prototypes]
void osnoise_trace_irq_exit(int id, const char *desc)
^
kernel/trace/trace_osnoise.c:680:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void osnoise_trace_irq_exit(int id, const char *desc)
^
static
kernel/trace/trace_osnoise.c:739:5: warning: no previous prototype for function 'hook_irq_events' [-Wmissing-prototypes]
int hook_irq_events(void)
^
kernel/trace/trace_osnoise.c:739:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int hook_irq_events(void)
^
static
kernel/trace/trace_osnoise.c:771:6: warning: no previous prototype for function 'unhook_irq_events' [-Wmissing-prototypes]
void unhook_irq_events(void)
^
kernel/trace/trace_osnoise.c:771:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void unhook_irq_events(void)
^
static
kernel/trace/trace_osnoise.c:788:6: warning: no previous prototype for function 'trace_softirq_entry_callback' [-Wmissing-prototypes]
void trace_softirq_entry_callback(void *data, unsigned int vec_nr)
^
kernel/trace/trace_osnoise.c:788:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void trace_softirq_entry_callback(void *data, unsigned int vec_nr)
^
static
kernel/trace/trace_osnoise.c:811:6: warning: no previous prototype for function 'trace_softirq_exit_callback' [-Wmissing-prototypes]
void trace_softirq_exit_callback(void *data, unsigned int vec_nr)
^
kernel/trace/trace_osnoise.c:811:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void trace_softirq_exit_callback(void *data, unsigned int vec_nr)
^
static
kernel/trace/trace_osnoise.c:953:1: warning: no previous prototype for function 'trace_sched_switch_callback' [-Wmissing-prototypes]
trace_sched_switch_callback(void *data, bool preempt, struct task_struct *p,
^
kernel/trace/trace_osnoise.c:952:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void
^
static
kernel/trace/trace_osnoise.c:971:5: warning: no previous prototype for function 'hook_thread_events' [-Wmissing-prototypes]
int hook_thread_events(void)
^
kernel/trace/trace_osnoise.c:971:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int hook_thread_events(void)
^
static
kernel/trace/trace_osnoise.c:988:6: warning: no previous prototype for function 'unhook_thread_events' [-Wmissing-prototypes]
void unhook_thread_events(void)
^
kernel/trace/trace_osnoise.c:988:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void unhook_thread_events(void)
^
static
kernel/trace/trace_osnoise.c:1000:6: warning: no previous prototype for function 'save_osn_sample_stats' [-Wmissing-prototypes]
void save_osn_sample_stats(struct osnoise_variables *osn_var, struct osnoise_sample *s)
^
kernel/trace/trace_osnoise.c:1000:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void save_osn_sample_stats(struct osnoise_variables *osn_var, struct osnoise_sample *s)
^
static
kernel/trace/trace_osnoise.c:1015:6: warning: no previous prototype for function 'diff_osn_sample_stats' [-Wmissing-prototypes]
void diff_osn_sample_stats(struct osnoise_variables *osn_var, struct osnoise_sample *s)
^
kernel/trace/trace_osnoise.c:1015:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void diff_osn_sample_stats(struct osnoise_variables *osn_var, struct osnoise_sample *s)
^
static
kernel/trace/trace_osnoise.c:1213:3: warning: comparison of distinct pointer types ('typeof ((interval)) *' (aka 'long long *') and 'uint64_t *' (aka 'unsigned long long *')) [-Wcompare-distinct-pointer-types]
do_div(interval, USEC_PER_MSEC);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/div64.h:228:28: note: expanded from macro 'do_div'
(void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~
>> kernel/trace/trace_osnoise.c:1584:2: error: void function 'osnoise_init_hotplug_support' should not return a value [-Wreturn-type]
return 0;
^ ~
13 warnings and 1 error generated.
vim +/osnoise_init_hotplug_support +1584 kernel/trace/trace_osnoise.c
1569
1570 static void osnoise_init_hotplug_support(void)
1571 {
1572 int ret;
1573
1574 ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "trace/osnoise:online",
1575 osnoise_cpu_init, osnoise_cpu_die);
1576 if (ret < 0)
1577 pr_warn(BANNER "Error to init cpu hotplug support\n");
1578
1579 return;
1580 }
1581 #else /* CONFIG_HOTPLUG_CPU */
1582 static void osnoise_init_hotplug_support(void)
1583 {
> 1584 return 0;
1585 }
1586 #endif /* CONFIG_HOTPLUG_CPU */
1587
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34330 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [trace:for-next 38/40] kernel/trace/trace_osnoise.c:1584:2: error: void function 'osnoise_init_hotplug_support' should not return a value
2021-06-26 20:39 [trace:for-next 38/40] kernel/trace/trace_osnoise.c:1584:2: error: void function 'osnoise_init_hotplug_support' should not return a value kernel test robot
@ 2021-06-28 3:21 ` Steven Rostedt
2021-06-28 9:13 ` Daniel Bristot de Oliveira
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2021-06-28 3:21 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]
Daniel,
Can you fix this too.
Thanks,
-- Steve
On Sun, 27 Jun 2021 04:39:35 +0800
kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
> head: 6a2cbc58d6c9d90cd74288cc497c2b45815bc064
> commit: c8895e271f7994a3ecb13b8a280e39aa53879545 [38/40] trace/osnoise: Support hotplug operations
> config: powerpc-randconfig-r031-20210626 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 557b101ce714e39438ba1d39c4c50b03e12fcb96)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install powerpc cross compiling tool for clang build
> # apt-get install binutils-powerpc-linux-gnu
> # https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git/commit/?id=c8895e271f7994a3ecb13b8a280e39aa53879545
> git remote add trace https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> git fetch --no-tags trace for-next
> git checkout c8895e271f7994a3ecb13b8a280e39aa53879545
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [trace:for-next 38/40] kernel/trace/trace_osnoise.c:1584:2: error: void function 'osnoise_init_hotplug_support' should not return a value
2021-06-28 3:21 ` Steven Rostedt
@ 2021-06-28 9:13 ` Daniel Bristot de Oliveira
2021-06-28 12:02 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Bristot de Oliveira @ 2021-06-28 9:13 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
On 6/28/21 5:21 AM, Steven Rostedt wrote:
> Daniel,
>
> Can you fix this too.
Fixing...
Regarding the "return 0" on void functions, I am making two patches because one
Fixes: bce29ac9ce0b ("trace: Add osnoise tracer"), and another that Fixes
c8895e271f79 ("trace/osnoise: Support hotplug operations").
Thoughts?
-- Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [trace:for-next 38/40] kernel/trace/trace_osnoise.c:1584:2: error: void function 'osnoise_init_hotplug_support' should not return a value
2021-06-28 9:13 ` Daniel Bristot de Oliveira
@ 2021-06-28 12:02 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2021-06-28 12:02 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
On June 28, 2021 5:13:12 AM EDT, Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
>On 6/28/21 5:21 AM, Steven Rostedt wrote:
>> Daniel,
>>
>> Can you fix this too.
>
>Fixing...
>
>Regarding the "return 0" on void functions, I am making two patches
>because one
>Fixes: bce29ac9ce0b ("trace: Add osnoise tracer"), and another that
>Fixes
>c8895e271f79 ("trace/osnoise: Support hotplug operations").
>
>Thoughts?
>
Two patches are fit.
-- Steve
>-- Daniel
--
Sent from my Android device with K-9 Mail. Please excuse my brevity and top posting.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-28 12:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-26 20:39 [trace:for-next 38/40] kernel/trace/trace_osnoise.c:1584:2: error: void function 'osnoise_init_hotplug_support' should not return a value kernel test robot
2021-06-28 3:21 ` Steven Rostedt
2021-06-28 9:13 ` Daniel Bristot de Oliveira
2021-06-28 12:02 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.