[PATCH] bluetooth: Add support for EP-B3536 USB Bluetooth adapter

[PATCH] bluetooth: Add support for EP-B3536 USB Bluetooth adapter

[Jack Murray]

From: Jack Murray <kernel@c0rporation.com>

This patch adds support for the EP-B3536 USB bluetooth 5.1 adapter based
on the 8761B chipset. The existing driver and firmware work fine for this
device from what I can tell, so this patch just adds the vendor/product IDs
for it to the supported device list.

Signed-off-by: Jack Murray <kernel@c0rporation.com>
---
  drivers/bluetooth/btusb.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 60d2fce59a71..207c8289c5c2 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -436,6 +436,8 @@ static const struct usb_device_id blacklist_table[] = {
         /* Additional Realtek 8761BU Bluetooth devices */
         { USB_DEVICE(0x0b05, 0x190e), .driver_info = BTUSB_REALTEK |
BTUSB_WIDEBAND_SPEECH },
+       { USB_DEVICE(0x2550, 0x8761), .driver_info = BTUSB_REALTEK |
+ BTUSB_WIDEBAND_SPEECH },

         /* Additional Realtek 8821AE Bluetooth devices */
         { USB_DEVICE(0x0b05, 0x17dc), .driver_info = BTUSB_REALTEK },

Re: [PATCH] bluetooth: Add support for EP-B3536 USB Bluetooth adapter

[Paul Menzel]

Dear Jack,


Am 15.01.22 um 22:30 schrieb Jack Murray:
> From: Jack Murray <kernel@c0rporation.com>
> 
> This patch adds support for the EP-B3536 USB bluetooth 5.1 adapter based

Who manufactures that device? Is it Teledyne? 0x2550 is 9552 (decimal), 
and according to [1] that is Teledyne. Maybe, add that to the commit 
message.

> on the 8761B chipset. The existing driver and firmware work fine for this
> device from what I can tell, so this patch just adds the vendor/product IDs
> for it to the supported device list.
> 
> Signed-off-by: Jack Murray <kernel@c0rporation.com>
> ---
>   drivers/bluetooth/btusb.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 60d2fce59a71..207c8289c5c2 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -436,6 +436,8 @@ static const struct usb_device_id blacklist_table[] = {
>          /* Additional Realtek 8761BU Bluetooth devices */
>          { USB_DEVICE(0x0b05, 0x190e), .driver_info = BTUSB_REALTEK |
> BTUSB_WIDEBAND_SPEECH },
> +       { USB_DEVICE(0x2550, 0x8761), .driver_info = BTUSB_REALTEK |
> + BTUSB_WIDEBAND_SPEECH }, >
>          /* Additional Realtek 8821AE Bluetooth devices */
>          { USB_DEVICE(0x0b05, 0x17dc), .driver_info = BTUSB_REALTEK },


Kind regards,

Paul


[1]: https://www.usb.org/sites/default/files/vendor_ids082119_0.pdf

Re: [PATCH] bluetooth: Add support for EP-B3536 USB Bluetooth adapter

[Jack Murray]

It's actually EDUP (https://www.szedup.com/) that make it, not Teledyne 
(unless there's some link between the companies that I couldn't see). 
I'm happy to add EDUP to the commit message though if that's not going 
to cause any confusion by the names not matching?

On 16/01/2022 06:07, Paul Menzel wrote:
> Dear Jack,
>
>
> Am 15.01.22 um 22:30 schrieb Jack Murray:
>> From: Jack Murray <kernel@c0rporation.com>
>>
>> This patch adds support for the EP-B3536 USB bluetooth 5.1 adapter based
>
> Who manufactures that device? Is it Teledyne? 0x2550 is 9552 
> (decimal), and according to [1] that is Teledyne. Maybe, add that to 
> the commit message.
>
>> on the 8761B chipset. The existing driver and firmware work fine for 
>> this
>> device from what I can tell, so this patch just adds the 
>> vendor/product IDs
>> for it to the supported device list.
>>
>> Signed-off-by: Jack Murray <kernel@c0rporation.com>
>> ---
>>   drivers/bluetooth/btusb.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index 60d2fce59a71..207c8289c5c2 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -436,6 +436,8 @@ static const struct usb_device_id 
>> blacklist_table[] = {
>>          /* Additional Realtek 8761BU Bluetooth devices */
>>          { USB_DEVICE(0x0b05, 0x190e), .driver_info = BTUSB_REALTEK |
>> BTUSB_WIDEBAND_SPEECH },
>> +       { USB_DEVICE(0x2550, 0x8761), .driver_info = BTUSB_REALTEK |
>> + BTUSB_WIDEBAND_SPEECH }, >
>>          /* Additional Realtek 8821AE Bluetooth devices */
>>          { USB_DEVICE(0x0b05, 0x17dc), .driver_info = BTUSB_REALTEK },
>
>
> Kind regards,
>
> Paul
>
>
> [1]: https://www.usb.org/sites/default/files/vendor_ids082119_0.pdf

Re: [PATCH] bluetooth: Add support for EP-B3536 USB Bluetooth adapter

[Marcel Holtmann]

Hi Jack,

> This patch adds support for the EP-B3536 USB bluetooth 5.1 adapter based
> on the 8761B chipset. The existing driver and firmware work fine for this
> device from what I can tell, so this patch just adds the vendor/product IDs
> for it to the supported device list.
> 
> Signed-off-by: Jack Murray <kernel@c0rporation.com>
> ---
>  drivers/bluetooth/btusb.c | 2 ++
>  1 file changed, 2 insertions(+)

please send an updated version addressing the comments and include /sys/kernel/debug/usb/devices.

Regards

Marcel

Re: [PATCH] bluetooth: Add support for EP-B3536 USB Bluetooth adapter

[Jack Murray]

Sorry I'd forgotten all about this as I actually ended up returning the 
device since it didn't have sufficient range for what I wanted it for 
anyway, so I can't include the /sys/kernel/debug/usb/devices output. 
Here's an updated commit though if it's ok to merge without that.


From: Jack Murray <kernel@c0rporation.com>

This patch adds support for the EDUP EP-B3536 USB bluetooth 5.1 adapter 
based
on the Realtek 8761B chipset. The existing driver and firmware work fine 
for this
device from what I can tell, so this patch just adds the vendor/product IDs
for it to the supported device list.


Signed-off-by: Jack Murray <kernel@c0rporation.com>
---
   drivers/bluetooth/btusb.c | 2 ++
   1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 60d2fce59a71..207c8289c5c2 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -436,6 +436,8 @@ static const struct usb_device_id blacklist_table[] = {
          /* Additional Realtek 8761BU Bluetooth devices */
          { USB_DEVICE(0x0b05, 0x190e), .driver_info = BTUSB_REALTEK |
BTUSB_WIDEBAND_SPEECH },
+       { USB_DEVICE(0x2550, 0x8761), .driver_info = BTUSB_REALTEK |
+ BTUSB_WIDEBAND_SPEECH }, >
          /* Additional Realtek 8821AE Bluetooth devices */
          { USB_DEVICE(0x0b05, 0x17dc), .driver_info = BTUSB_REALTEK },

On 07/02/2022 15:40, Marcel Holtmann wrote:
> Hi Jack,
>
>> This patch adds support for the EP-B3536 USB bluetooth 5.1 adapter based
>> on the 8761B chipset. The existing driver and firmware work fine for this
>> device from what I can tell, so this patch just adds the vendor/product IDs
>> for it to the supported device list.
>>
>> Signed-off-by: Jack Murray <kernel@c0rporation.com>
>> ---
>>   drivers/bluetooth/btusb.c | 2 ++
>>   1 file changed, 2 insertions(+)
> please send an updated version addressing the comments and include /sys/kernel/debug/usb/devices.
>
> Regards
>
> Marcel
>