* [PATCH] drm/i915: Enable fastboot by default on VLV and CHV
@ 2019-01-29 14:22 Hans de Goede
2019-01-29 16:31 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Hans de Goede @ 2019-01-29 14:22 UTC (permalink / raw)
To: Maarten Lankhorst, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: Hans de Goede, intel-gfx, dri-devel
We really want to have fastboot enabled by default to avoid an ugly
modeset during boot.
Currently we are enabling fastboot by default on gen9+ (Skylake and newer).
The intention is to enable it on older generations after it has seen more
testing on gen9+.
VLV and CHV devices are still being sold in stores today, as such it is
desirable to also enable fastboot by default on these now.
I've extensively tested fastboot=1 support on over 50 different
Bay- and Cherry-Trail devices. Testing DSI and eDP panels as well as
HDMI output (and even DP over Type-C on one device).
All 50 devices work fine with fastboot=1. On 2 devices their DSI panel
turns black as soon as the i915 driver loads when fastboot=0, so having
fastboot enabled is required for these 2 to work properly (for lack of
a better fix).
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/gpu/drm/i915/intel_display.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index d756d7358292..0ff42a38023c 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11672,7 +11672,15 @@ static bool fastboot_enabled(struct drm_i915_private *dev_priv)
return i915_modparams.fastboot;
/* Enable fastboot by default on Skylake and newer */
- return INTEL_GEN(dev_priv) >= 9;
+ if (INTEL_GEN(dev_priv) >= 9)
+ return true;
+
+ /* Enable fastboot by default on VLV and CHV */
+ if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
+ return true;
+
+ /* Disabled by default on all others */
+ return false;
}
static bool
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Enable fastboot by default on VLV and CHV
2019-01-29 14:22 [PATCH] drm/i915: Enable fastboot by default on VLV and CHV Hans de Goede
@ 2019-01-29 16:31 ` Patchwork
2019-01-29 20:07 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-31 13:36 ` [PATCH] " Maarten Lankhorst
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-01-29 16:31 UTC (permalink / raw)
To: Hans de Goede; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Enable fastboot by default on VLV and CHV
URL : https://patchwork.freedesktop.org/series/55911/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5501 -> Patchwork_12071
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55911/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12071 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: NOTRUN -> FAIL [fdo#103182]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (46 -> 40)
------------------------------
Additional (1): fi-gdg-551
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5501 -> Patchwork_12071
CI_DRM_5501: 5aac0b69f3a3085b9b8a9924cb19cb94f7860dbe @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4798: 998e0a4aedf10fb5f7c271018cd80d874668bf55 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12071: e62714cbe893deec958c6ee91b95f407ae8d2132 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e62714cbe893 drm/i915: Enable fastboot by default on VLV and CHV
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12071/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Enable fastboot by default on VLV and CHV
2019-01-29 14:22 [PATCH] drm/i915: Enable fastboot by default on VLV and CHV Hans de Goede
2019-01-29 16:31 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-29 20:07 ` Patchwork
2019-01-31 13:36 ` [PATCH] " Maarten Lankhorst
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-01-29 20:07 UTC (permalink / raw)
To: Hans de Goede; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Enable fastboot by default on VLV and CHV
URL : https://patchwork.freedesktop.org/series/55911/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5501_full -> Patchwork_12071_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12071_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-glk: PASS -> FAIL [fdo#103232]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#105363] +1
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166]
- shard-glk: PASS -> FAIL [fdo#103166]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-apl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-apl: FAIL [fdo#105010] -> PASS
* igt@prime_busy@hang-bsd:
- shard-hsw: FAIL [fdo#108807] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108807]: https://bugs.freedesktop.org/show_bug.cgi?id=108807
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* Linux: CI_DRM_5501 -> Patchwork_12071
CI_DRM_5501: 5aac0b69f3a3085b9b8a9924cb19cb94f7860dbe @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4798: 998e0a4aedf10fb5f7c271018cd80d874668bf55 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12071: e62714cbe893deec958c6ee91b95f407ae8d2132 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12071/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Enable fastboot by default on VLV and CHV
2019-01-29 14:22 [PATCH] drm/i915: Enable fastboot by default on VLV and CHV Hans de Goede
2019-01-29 16:31 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-29 20:07 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-01-31 13:36 ` Maarten Lankhorst
2019-02-01 9:18 ` Hans de Goede
2 siblings, 1 reply; 5+ messages in thread
From: Maarten Lankhorst @ 2019-01-31 13:36 UTC (permalink / raw)
To: Hans de Goede, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, dri-devel
Op 29-01-2019 om 15:22 schreef Hans de Goede:
> We really want to have fastboot enabled by default to avoid an ugly
> modeset during boot.
>
> Currently we are enabling fastboot by default on gen9+ (Skylake and newer).
> The intention is to enable it on older generations after it has seen more
> testing on gen9+.
>
> VLV and CHV devices are still being sold in stores today, as such it is
> desirable to also enable fastboot by default on these now.
>
> I've extensively tested fastboot=1 support on over 50 different
> Bay- and Cherry-Trail devices. Testing DSI and eDP panels as well as
> HDMI output (and even DP over Type-C on one device).
>
> All 50 devices work fine with fastboot=1. On 2 devices their DSI panel
> turns black as soon as the i915 driver loads when fastboot=0, so having
> fastboot enabled is required for these 2 to work properly (for lack of
> a better fix).
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index d756d7358292..0ff42a38023c 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11672,7 +11672,15 @@ static bool fastboot_enabled(struct drm_i915_private *dev_priv)
> return i915_modparams.fastboot;
>
> /* Enable fastboot by default on Skylake and newer */
> - return INTEL_GEN(dev_priv) >= 9;
> + if (INTEL_GEN(dev_priv) >= 9)
> + return true;
> +
> + /* Enable fastboot by default on VLV and CHV */
> + if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
> + return true;
> +
> + /* Disabled by default on all others */
> + return false;
> }
>
> static bool
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Enable fastboot by default on VLV and CHV
2019-01-31 13:36 ` [PATCH] " Maarten Lankhorst
@ 2019-02-01 9:18 ` Hans de Goede
0 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2019-02-01 9:18 UTC (permalink / raw)
To: Maarten Lankhorst, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, dri-devel
Hi,
On 31-01-19 14:36, Maarten Lankhorst wrote:
> Op 29-01-2019 om 15:22 schreef Hans de Goede:
>> We really want to have fastboot enabled by default to avoid an ugly
>> modeset during boot.
>>
>> Currently we are enabling fastboot by default on gen9+ (Skylake and newer).
>> The intention is to enable it on older generations after it has seen more
>> testing on gen9+.
>>
>> VLV and CHV devices are still being sold in stores today, as such it is
>> desirable to also enable fastboot by default on these now.
>>
>> I've extensively tested fastboot=1 support on over 50 different
>> Bay- and Cherry-Trail devices. Testing DSI and eDP panels as well as
>> HDMI output (and even DP over Type-C on one device).
>>
>> All 50 devices work fine with fastboot=1. On 2 devices their DSI panel
>> turns black as soon as the i915 driver loads when fastboot=0, so having
>> fastboot enabled is required for these 2 to work properly (for lack of
>> a better fix).
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> drivers/gpu/drm/i915/intel_display.c | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index d756d7358292..0ff42a38023c 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -11672,7 +11672,15 @@ static bool fastboot_enabled(struct drm_i915_private *dev_priv)
>> return i915_modparams.fastboot;
>>
>> /* Enable fastboot by default on Skylake and newer */
>> - return INTEL_GEN(dev_priv) >= 9;
>> + if (INTEL_GEN(dev_priv) >= 9)
>> + return true;
>> +
>> + /* Enable fastboot by default on VLV and CHV */
>> + if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
>> + return true;
>> +
>> + /* Disabled by default on all others */
>> + return false;
>> }
>>
>> static bool
>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Thank you, pushed.
Regards,
Hans
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-01 9:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 14:22 [PATCH] drm/i915: Enable fastboot by default on VLV and CHV Hans de Goede
2019-01-29 16:31 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-29 20:07 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-31 13:36 ` [PATCH] " Maarten Lankhorst
2019-02-01 9:18 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.