All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH] spi-tools: Add version info.
@ 2017-10-27 10:14 Fan Xin
  2017-10-27 10:18 ` Philip Balister
  0 siblings, 1 reply; 7+ messages in thread
From: Fan Xin @ 2017-10-27 10:14 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Fan Xin <fan.xin@jp.fujitsu.com>
---
 meta-oe/recipes-support/spitools/spitools_git.bb | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/spitools/spitools_git.bb b/meta-oe/recipes-support/spitools/spitools_git.bb
index f808125..2eedf8c 100644
--- a/meta-oe/recipes-support/spitools/spitools_git.bb
+++ b/meta-oe/recipes-support/spitools/spitools_git.bb
@@ -4,11 +4,16 @@ AUTHOR = "Christophe BLAESS"
 LICENSE="GPLv2"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=8c16666ae6c159876a0ba63099614381"
 
+PR = "r0"
+
+BPV = "0.8.1"
+PV = "${BPV}"
+SRCREV = "03405ab45884e4264dfa0371c032b2baaeeaaa98"
+
 S = "${WORKDIR}/git"
 
 SRC_URI = "git://github.com/cpb-/spi-tools.git;protocol=git"
 
-SRCREV = "03405ab45884e4264dfa0371c032b2baaeeaaa98"
 
 inherit autotools
 
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [meta-oe][PATCH] spi-tools: Add version info.
  2017-10-27 10:14 [meta-oe][PATCH] spi-tools: Add version info Fan Xin
@ 2017-10-27 10:18 ` Philip Balister
  2017-10-30  1:35   ` [PATCH v2] " Fan Xin
  0 siblings, 1 reply; 7+ messages in thread
From: Philip Balister @ 2017-10-27 10:18 UTC (permalink / raw)
  To: Fan Xin, openembedded-devel

On 10/27/2017 12:14 PM, Fan Xin wrote:
> Signed-off-by: Fan Xin <fan.xin@jp.fujitsu.com>
> ---
>  meta-oe/recipes-support/spitools/spitools_git.bb | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-support/spitools/spitools_git.bb b/meta-oe/recipes-support/spitools/spitools_git.bb
> index f808125..2eedf8c 100644
> --- a/meta-oe/recipes-support/spitools/spitools_git.bb
> +++ b/meta-oe/recipes-support/spitools/spitools_git.bb
> @@ -4,11 +4,16 @@ AUTHOR = "Christophe BLAESS"
>  LICENSE="GPLv2"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=8c16666ae6c159876a0ba63099614381"
>  
> +PR = "r0"

Drop the PR.

Philip

> +
> +BPV = "0.8.1"
> +PV = "${BPV}"
> +SRCREV = "03405ab45884e4264dfa0371c032b2baaeeaaa98"
> +
>  S = "${WORKDIR}/git"
>  
>  SRC_URI = "git://github.com/cpb-/spi-tools.git;protocol=git"
>  
> -SRCREV = "03405ab45884e4264dfa0371c032b2baaeeaaa98"
>  
>  inherit autotools
>  
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2] spi-tools: Add version info
  2017-10-27 10:18 ` Philip Balister
@ 2017-10-30  1:35   ` Fan Xin
  2017-10-30  3:17     ` Khem Raj
  0 siblings, 1 reply; 7+ messages in thread
From: Fan Xin @ 2017-10-30  1:35 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Fan Xin <fan.xin@jp.fujitsu.com>
---
 meta-oe/recipes-support/spitools/spitools_git.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-oe/recipes-support/spitools/spitools_git.bb b/meta-oe/recipes-support/spitools/spitools_git.bb
index f808125..6ca6ad7 100644
--- a/meta-oe/recipes-support/spitools/spitools_git.bb
+++ b/meta-oe/recipes-support/spitools/spitools_git.bb
@@ -4,6 +4,9 @@ AUTHOR = "Christophe BLAESS"
 LICENSE="GPLv2"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=8c16666ae6c159876a0ba63099614381"
 
+BPV = "0.8.1"
+PV = "${BPV}"
+
 S = "${WORKDIR}/git"
 
 SRC_URI = "git://github.com/cpb-/spi-tools.git;protocol=git"
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] spi-tools: Add version info
  2017-10-30  1:35   ` [PATCH v2] " Fan Xin
@ 2017-10-30  3:17     ` Khem Raj
  2017-10-30  4:45       ` [PATCH v3] " Fan Xin
  0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2017-10-30  3:17 UTC (permalink / raw)
  To: Fan Xin; +Cc: openembeded-devel

On Sun, Oct 29, 2017 at 6:35 PM, Fan Xin <fan.xin@jp.fujitsu.com> wrote:
> Signed-off-by: Fan Xin <fan.xin@jp.fujitsu.com>
> ---
>  meta-oe/recipes-support/spitools/spitools_git.bb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta-oe/recipes-support/spitools/spitools_git.bb b/meta-oe/recipes-support/spitools/spitools_git.bb
> index f808125..6ca6ad7 100644
> --- a/meta-oe/recipes-support/spitools/spitools_git.bb
> +++ b/meta-oe/recipes-support/spitools/spitools_git.bb
> @@ -4,6 +4,9 @@ AUTHOR = "Christophe BLAESS"
>  LICENSE="GPLv2"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=8c16666ae6c159876a0ba63099614381"
>
> +BPV = "0.8.1"
> +PV = "${BPV}"
> +

why do we need BPV ?


>  S = "${WORKDIR}/git"
>
>  SRC_URI = "git://github.com/cpb-/spi-tools.git;protocol=git"
> --
> 2.7.4
>
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v3] spi-tools: Add version info
  2017-10-30  3:17     ` Khem Raj
@ 2017-10-30  4:45       ` Fan Xin
  2017-10-30 20:06         ` akuster808
  0 siblings, 1 reply; 7+ messages in thread
From: Fan Xin @ 2017-10-30  4:45 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Fan Xin <fan.xin@jp.fujitsu.com>
---
 meta-oe/recipes-support/spitools/spitools_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-oe/recipes-support/spitools/spitools_git.bb b/meta-oe/recipes-support/spitools/spitools_git.bb
index f808125..168f0f3 100644
--- a/meta-oe/recipes-support/spitools/spitools_git.bb
+++ b/meta-oe/recipes-support/spitools/spitools_git.bb
@@ -4,6 +4,8 @@ AUTHOR = "Christophe BLAESS"
 LICENSE="GPLv2"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=8c16666ae6c159876a0ba63099614381"
 
+PV = "0.8.1"
+
 S = "${WORKDIR}/git"
 
 SRC_URI = "git://github.com/cpb-/spi-tools.git;protocol=git"
-- 
2.7.4




^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v3] spi-tools: Add version info
  2017-10-30  4:45       ` [PATCH v3] " Fan Xin
@ 2017-10-30 20:06         ` akuster808
  2017-10-30 23:15           ` Khem Raj
  0 siblings, 1 reply; 7+ messages in thread
From: akuster808 @ 2017-10-30 20:06 UTC (permalink / raw)
  To: Fan Xin, openembedded-devel



On 10/29/2017 09:45 PM, Fan Xin wrote:
> Signed-off-by: Fan Xin <fan.xin@jp.fujitsu.com>
> ---
>  meta-oe/recipes-support/spitools/spitools_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-support/spitools/spitools_git.bb b/meta-oe/recipes-support/spitools/spitools_git.bb
> index f808125..168f0f3 100644
> --- a/meta-oe/recipes-support/spitools/spitools_git.bb
> +++ b/meta-oe/recipes-support/spitools/spitools_git.bb
> @@ -4,6 +4,8 @@ AUTHOR = "Christophe BLAESS"
>  LICENSE="GPLv2"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=8c16666ae6c159876a0ba63099614381"
>  
> +PV = "0.8.1"
> +
>  S = "${WORKDIR}/git"

Should we think of converting these kinds recipes to spitools_0.8.1.bb
to avoid the need for PV ?  Maybe a best practices on the recipes naming??

- armin
>  
>  SRC_URI = "git://github.com/cpb-/spi-tools.git;protocol=git"



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v3] spi-tools: Add version info
  2017-10-30 20:06         ` akuster808
@ 2017-10-30 23:15           ` Khem Raj
  0 siblings, 0 replies; 7+ messages in thread
From: Khem Raj @ 2017-10-30 23:15 UTC (permalink / raw)
  To: akuster808; +Cc: openembeded-devel

On Mon, Oct 30, 2017 at 1:06 PM, akuster808 <akuster808@gmail.com> wrote:
>
>
> On 10/29/2017 09:45 PM, Fan Xin wrote:
>> Signed-off-by: Fan Xin <fan.xin@jp.fujitsu.com>
>> ---
>>  meta-oe/recipes-support/spitools/spitools_git.bb | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/meta-oe/recipes-support/spitools/spitools_git.bb b/meta-oe/recipes-support/spitools/spitools_git.bb
>> index f808125..168f0f3 100644
>> --- a/meta-oe/recipes-support/spitools/spitools_git.bb
>> +++ b/meta-oe/recipes-support/spitools/spitools_git.bb
>> @@ -4,6 +4,8 @@ AUTHOR = "Christophe BLAESS"
>>  LICENSE="GPLv2"
>>  LIC_FILES_CHKSUM = "file://LICENSE;md5=8c16666ae6c159876a0ba63099614381"
>>
>> +PV = "0.8.1"
>> +
>>  S = "${WORKDIR}/git"
>
> Should we think of converting these kinds recipes to spitools_0.8.1.bb
> to avoid the need for PV ?  Maybe a best practices on the recipes naming??
>

I think yes. on the downside its convenient for git log to have same
file name but then we do have
git log --follow

> - armin
>>
>>  SRC_URI = "git://github.com/cpb-/spi-tools.git;protocol=git"
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-10-30 23:15 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-27 10:14 [meta-oe][PATCH] spi-tools: Add version info Fan Xin
2017-10-27 10:18 ` Philip Balister
2017-10-30  1:35   ` [PATCH v2] " Fan Xin
2017-10-30  3:17     ` Khem Raj
2017-10-30  4:45       ` [PATCH v3] " Fan Xin
2017-10-30 20:06         ` akuster808
2017-10-30 23:15           ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.