From: Hari Bathini <hbathini@linux.vnet.ibm.com>
To: msuchanek <msuchanek@suse.de>
Cc: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH v5 2/2] powerpc/fadump: update documentation about 'fadump_append=' parameter
Date: Wed, 12 Jul 2017 17:45:07 +0530 [thread overview]
Message-ID: <d2f8bc2f-5e5f-436b-b9fc-5912af7c7ab7@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170712133102.2145e393@naga>
On Wednesday 12 July 2017 05:01 PM, msuchanek wrote:
> Hello,
>
> On Wed, 12 Jul 2017 00:00:57 +0530
> Hari Bathini <hbathini@linux.vnet.ibm.com> wrote:
>
>> Hi Michal,
>>
>>
>> Thanks for the review..
>>
>>
>> On Monday 26 June 2017 05:45 PM, Michal Suchánek wrote:
>>> Hello,
>>>
>>> On Tue, 20 Jun 2017 21:14:08 +0530
>>> Hari Bathini <hbathini@linux.vnet.ibm.com> wrote:
>>>
>> I would prefer documenting over a complex implementation. Actually, I
>> am considering a simple approach of replacing every occurrence of
>> "fadump_extra_args=" with "fadump_extra_args " in fadump capture
>> kernel. The cmdline
>>
>> "root=/dev/sda2 ro fadump_extra_args="a b c" crashkernel=512M
>> fadump_extra_args=d"
>>
>> becomes
>>
>> "root=/dev/sda2 ro fadump_extra_args "a b c" crashkernel=512M
>> fadump_extra_args d"
> which is totally broken
My bad! I don't know what I was thinking when I expected that to work.. :-[
>> in fadump capture kernel. This must take care of the pitfalls with
>> the current approach and also,
>> doesn't rely on parse_args() which was not designed for this scenario
>> to start with..?
> It was designed for parsing arguments. To handle replacing arguments
> you have to extend it. You need to get more information from it for
> this case.
I will try to work on this. Also, want to replace in-place without
moving other parameters.
I guess, I could do that by replacing the leftover length after
processing with spaces..
Thanks
Hari
next prev parent reply other threads:[~2017-07-12 13:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 18:22 [PATCH v5 1/2] powerpc/fadump: reduce memory consumption for capture kernel Hari Bathini
2017-05-03 18:22 ` [PATCH v5 2/2] powerpc/fadump: update documentation about 'fadump_append=' parameter Hari Bathini
2017-05-10 16:01 ` Michal Suchánek
2017-05-10 20:30 ` Hari Bathini
2017-05-11 13:16 ` Michal Suchánek
2017-05-12 9:45 ` Hari Bathini
2017-05-12 15:42 ` Michal Suchánek
2017-05-15 7:29 ` Hari Bathini
2017-05-15 9:29 ` Michal Suchánek
2017-06-08 18:00 ` Hari Bathini
2017-06-09 12:04 ` Michal Suchánek
2017-06-20 15:44 ` Hari Bathini
2017-06-26 12:15 ` Michal Suchánek
2017-07-11 18:30 ` Hari Bathini
2017-07-12 11:31 ` msuchanek
2017-07-12 12:15 ` Hari Bathini [this message]
2017-05-11 15:07 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2f8bc2f-5e5f-436b-b9fc-5912af7c7ab7@linux.vnet.ibm.com \
--to=hbathini@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.