* [PATCH] build: correct usage comments in Kbuild.include
@ 2022-01-12 11:28 Jan Beulich
2022-01-12 11:29 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2022-01-12 11:28 UTC (permalink / raw)
To: xen-devel
Cc: Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini,
Wei Liu, Anthony Perard
Macros with arguments need to be invoked via $(call ...); don't misguide
people looking up usage of such macros.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/scripts/Kbuild.include
+++ b/xen/scripts/Kbuild.include
@@ -43,15 +43,15 @@ define as-option-add-closure
endif
endef
-# $(if-success,<command>,<then>,<else>)
+# $(call if-success,<command>,<then>,<else>)
# Return <then> if <command> exits with 0, <else> otherwise.
if-success = $(shell { $(1); } >/dev/null 2>&1 && echo "$(2)" || echo "$(3)")
-# $(success,<command>)
+# $(call success,<command>)
# Return y if <command> exits with 0, n otherwise
success = $(call if-success,$(1),y,n)
-# $(ld-option,<flag>)
+# $(call ld-option,<flag>)
# Return y if the linker supports <flag>, n otherwise
ld-option = $(call success,$(LD) -v $(1))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] build: correct usage comments in Kbuild.include
2022-01-12 11:28 [PATCH] build: correct usage comments in Kbuild.include Jan Beulich
@ 2022-01-12 11:29 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2022-01-12 11:29 UTC (permalink / raw)
To: Jan Beulich, xen-devel
Cc: Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini,
Wei Liu, Anthony Perard
On 12/01/2022 11:28, Jan Beulich wrote:
> Macros with arguments need to be invoked via $(call ...); don't misguide
> people looking up usage of such macros.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-12 11:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 11:28 [PATCH] build: correct usage comments in Kbuild.include Jan Beulich
2022-01-12 11:29 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.