All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture
@ 2018-05-09 16:42 Larry Finger
  2018-05-09 16:57 ` Jeff Johnson
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Larry Finger @ 2018-05-09 16:42 UTC (permalink / raw)
  To: kvalo; +Cc: linux-wireless, Larry Finger, Michael Büsch

Some MPIS-based SoCs use chips driven by b43 for wireless capability.
When ssb is configured as a module, build errors happen on these
platforms as described in the commit 882164a4a928 ("ssb: Prevent build
of PCI host features in module"). Unfortunately that change leads to
the removal of code needed for correct operation on platforms that use
PCI cores on the chip bus. The fix allows ssb to be build as a module
for all architectures other than MIPS. This approach is ad-hoc, but it
is the same as done in commit a9e6d44ddecc ("ssb: Do not disable PCI
host on non-Mips").

This problem was reported and discussed in
https://bugzilla.redhat.com/show_bug.cgi?id=1572349.

Fixes: commit 882164a4a928 ("ssb: Prevent build of PCI host features in module")
Tested-by: Matt Redfearn <matt.redfearn@mips.com>
Tested-by: Bruno Wolff III <bruno@wolff.to>
Cc: Michael Büsch <m@bues.ch>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---

Kalle,

This patch fixes the regression in 4.17 that was discussed on the
wireless mailing list. I'm not really happy about the ad-hoc rejection
of ssb as a module only on MIPS; however, that seems to be a unique
implementation of this hardware.

Larry

Michael,

Although I think your version of the patch is superior, this is the one that
Matt tested, thus I'm submitting this version.

Larry

---
 drivers/ssb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 9371651d8017..3743533c8057 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -117,7 +117,7 @@ config SSB_SERIAL
 
 config SSB_DRIVER_PCICORE_POSSIBLE
 	bool
-	depends on SSB_PCIHOST && SSB = y
+	depends on SSB_PCIHOST && (SSB = y || !MIPS)
 	default y
 
 config SSB_DRIVER_PCICORE
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture
  2018-05-09 16:42 [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture Larry Finger
@ 2018-05-09 16:57 ` Jeff Johnson
  2018-05-09 18:57   ` Larry Finger
  2018-05-09 21:53 ` Rafał Miłecki
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Jeff Johnson @ 2018-05-09 16:57 UTC (permalink / raw)
  To: Larry Finger
  Cc: kvalo, linux-wireless, Michael Büsch, linux-wireless-owner

On 2018-05-09 09:42, Larry Finger wrote:
> Some MPIS-based SoCs use chips driven by b43 for wireless capability.
typo: MPIS=>MIPS

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture
  2018-05-09 16:57 ` Jeff Johnson
@ 2018-05-09 18:57   ` Larry Finger
  0 siblings, 0 replies; 6+ messages in thread
From: Larry Finger @ 2018-05-09 18:57 UTC (permalink / raw)
  To: Jeff Johnson
  Cc: kvalo, linux-wireless, Michael Büsch, linux-wireless-owner

On 05/09/2018 11:57 AM, Jeff Johnson wrote:
> On 2018-05-09 09:42, Larry Finger wrote:
>> Some MPIS-based SoCs use chips driven by b43 for wireless capability.
> typo: MPIS=>MIPS

Jeff,

Thanks. I will fix this with V2.

Larry

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture
  2018-05-09 16:42 [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture Larry Finger
  2018-05-09 16:57 ` Jeff Johnson
@ 2018-05-09 21:53 ` Rafał Miłecki
  2018-05-10 10:44 ` Rafał Miłecki
  2018-05-11 10:18 ` Kalle Valo
  3 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2018-05-09 21:53 UTC (permalink / raw)
  To: Larry Finger; +Cc: Kalle Valo, linux-wireless, Michael Büsch

On 9 May 2018 at 18:42, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Some MPIS-based SoCs use chips driven by b43 for wireless capability.
> When ssb is configured as a module, build errors happen on these
> platforms as described in the commit 882164a4a928 ("ssb: Prevent build
> of PCI host features in module"). Unfortunately that change leads to
> the removal of code needed for correct operation on platforms that use
> PCI cores on the chip bus. The fix allows ssb to be build as a module
> for all architectures other than MIPS. This approach is ad-hoc, but it
> is the same as done in commit a9e6d44ddecc ("ssb: Do not disable PCI
> host on non-Mips").
>
> This problem was reported and discussed in
> https://bugzilla.redhat.com/show_bug.cgi?id=1572349.

I'll try to look at that tomorrow

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture
  2018-05-09 16:42 [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture Larry Finger
  2018-05-09 16:57 ` Jeff Johnson
  2018-05-09 21:53 ` Rafał Miłecki
@ 2018-05-10 10:44 ` Rafał Miłecki
  2018-05-11 10:18 ` Kalle Valo
  3 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2018-05-10 10:44 UTC (permalink / raw)
  To: Larry Finger; +Cc: Kalle Valo, linux-wireless, Michael Büsch

On 9 May 2018 at 18:42, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Some MPIS-based SoCs use chips driven by b43 for wireless capability.
> When ssb is configured as a module, build errors happen on these
> platforms as described in the commit 882164a4a928 ("ssb: Prevent build
> of PCI host features in module"). Unfortunately that change leads to
> the removal of code needed for correct operation on platforms that use
> PCI cores on the chip bus. The fix allows ssb to be build as a module
> for all architectures other than MIPS. This approach is ad-hoc, but it
> is the same as done in commit a9e6d44ddecc ("ssb: Do not disable PCI
> host on non-Mips").
>
> This problem was reported and discussed in
> https://bugzilla.redhat.com/show_bug.cgi?id=3D1572349.
>
> Fixes: commit 882164a4a928 ("ssb: Prevent build of PCI host features in m=
odule")
> Tested-by: Matt Redfearn <matt.redfearn@mips.com>
> Tested-by: Bruno Wolff III <bruno@wolff.to>
> Cc: Michael B=C3=BCsch <m@bues.ch>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Kalle,
>
> This patch fixes the regression in 4.17 that was discussed on the
> wireless mailing list. I'm not really happy about the ad-hoc rejection
> of ssb as a module only on MIPS; however, that seems to be a unique
> implementation of this hardware.
>
> Larry
>
> Michael,
>
> Although I think your version of the patch is superior, this is the one t=
hat
> Matt tested, thus I'm submitting this version.
>
> Larry
>
> ---
>  drivers/ssb/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
> index 9371651d8017..3743533c8057 100644
> --- a/drivers/ssb/Kconfig
> +++ b/drivers/ssb/Kconfig
> @@ -117,7 +117,7 @@ config SSB_SERIAL
>
>  config SSB_DRIVER_PCICORE_POSSIBLE
>         bool
> -       depends on SSB_PCIHOST && SSB =3D y
> +       depends on SSB_PCIHOST && (SSB =3D y || !MIPS)
>         default y
>
>  config SSB_DRIVER_PCICORE

I don't like hacking SSB_DRIVER_PCICORE_POSSIBLE while the original
problem seems to be related to the SSB_PCICORE_HOSTMODE.

We should rather revert breaking commit & fix original problem properly.

--=20
Rafa=C5=82

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture
  2018-05-09 16:42 [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture Larry Finger
                   ` (2 preceding siblings ...)
  2018-05-10 10:44 ` Rafał Miłecki
@ 2018-05-11 10:18 ` Kalle Valo
  3 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2018-05-11 10:18 UTC (permalink / raw)
  To: Larry Finger; +Cc: linux-wireless, Larry Finger, Michael Büsch

Larry Finger <Larry.Finger@lwfinger.net> wrote:

> Some MPIS-based SoCs use chips driven by b43 for wireless capability.
> When ssb is configured as a module, build errors happen on these
> platforms as described in the commit 882164a4a928 ("ssb: Prevent build
> of PCI host features in module"). Unfortunately that change leads to
> the removal of code needed for correct operation on platforms that use
> PCI cores on the chip bus. The fix allows ssb to be build as a module
> for all architectures other than MIPS. This approach is ad-hoc, but it
> is the same as done in commit a9e6d44ddecc ("ssb: Do not disable PCI
> host on non-Mips").
> 
> This problem was reported and discussed in
> https://bugzilla.redhat.com/show_bug.cgi?id=1572349.
> 
> Fixes: commit 882164a4a928 ("ssb: Prevent build of PCI host features in module")
> Tested-by: Matt Redfearn <matt.redfearn@mips.com>
> Tested-by: Bruno Wolff III <bruno@wolff.to>
> Cc: Michael Büsch <m@bues.ch>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Dropped per Larry's request (on the other thread).

Patch set to Rejected.

-- 
https://patchwork.kernel.org/patch/10390053/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-11 10:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 16:42 [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture Larry Finger
2018-05-09 16:57 ` Jeff Johnson
2018-05-09 18:57   ` Larry Finger
2018-05-09 21:53 ` Rafał Miłecki
2018-05-10 10:44 ` Rafał Miłecki
2018-05-11 10:18 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.