From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, linus.walleij@linaro.org,
linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] pinctrl: meson: Add support to set direction with a secure monitor call
Date: Thu, 2 Aug 2018 09:52:53 +0200 [thread overview]
Message-ID: <d319d871-ba93-ab1d-dae4-b44916161e85@baylibre.com> (raw)
In-Reply-To: <CAFBinCBcUijFGdLoQwkzioX7MF0H_gH1rbcvxG+UWc1rA2pRiQ@mail.gmail.com>
On 01/08/2018 22:23, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Wed, Aug 1, 2018 at 12:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> The Amlogic Meson GX and AXG SoCs needs to do a Secure Monitor call to
>> set the TEST_N pin direction.
>> This patch adds a "smc" boolean to the bank structure to differentiate
>> the TEST_N bank and call the Secure Monitor in the _input/_output functions.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> drivers/pinctrl/meson/Kconfig | 1 +
>> drivers/pinctrl/meson/pinctrl-meson.c | 31 ++++++++++++++++++++++++++-----
>> drivers/pinctrl/meson/pinctrl-meson.h | 10 +++++++++-
>> 3 files changed, 36 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/pinctrl/meson/Kconfig b/drivers/pinctrl/meson/Kconfig
>> index c80951d..1b90470 100644
>> --- a/drivers/pinctrl/meson/Kconfig
>> +++ b/drivers/pinctrl/meson/Kconfig
>> @@ -8,6 +8,7 @@ menuconfig PINCTRL_MESON
>> select GPIOLIB
>> select OF_GPIO
>> select REGMAP_MMIO
>> + select MESON_SM
> I wonder why PINCTRL_MESON has to select MESON_SM - shouldn't
> PINCTRL_MESON_GXBB, PINCTRL_MESON_GXL and PINCTRL_MESON_AXG select it
> instead?
> selecting MESON_SM is probably no-op on Meson8 and Meson8b (which
> don't have the GX secure monitor), but I haven't tested it yet
Hi Martin, you are right !
I will fix it on v2..
Neil
>
>
> Regards
> Martin
>
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] pinctrl: meson: Add support to set direction with a secure monitor call
Date: Thu, 2 Aug 2018 09:52:53 +0200 [thread overview]
Message-ID: <d319d871-ba93-ab1d-dae4-b44916161e85@baylibre.com> (raw)
In-Reply-To: <CAFBinCBcUijFGdLoQwkzioX7MF0H_gH1rbcvxG+UWc1rA2pRiQ@mail.gmail.com>
On 01/08/2018 22:23, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Wed, Aug 1, 2018 at 12:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> The Amlogic Meson GX and AXG SoCs needs to do a Secure Monitor call to
>> set the TEST_N pin direction.
>> This patch adds a "smc" boolean to the bank structure to differentiate
>> the TEST_N bank and call the Secure Monitor in the _input/_output functions.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> drivers/pinctrl/meson/Kconfig | 1 +
>> drivers/pinctrl/meson/pinctrl-meson.c | 31 ++++++++++++++++++++++++++-----
>> drivers/pinctrl/meson/pinctrl-meson.h | 10 +++++++++-
>> 3 files changed, 36 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/pinctrl/meson/Kconfig b/drivers/pinctrl/meson/Kconfig
>> index c80951d..1b90470 100644
>> --- a/drivers/pinctrl/meson/Kconfig
>> +++ b/drivers/pinctrl/meson/Kconfig
>> @@ -8,6 +8,7 @@ menuconfig PINCTRL_MESON
>> select GPIOLIB
>> select OF_GPIO
>> select REGMAP_MMIO
>> + select MESON_SM
> I wonder why PINCTRL_MESON has to select MESON_SM - shouldn't
> PINCTRL_MESON_GXBB, PINCTRL_MESON_GXL and PINCTRL_MESON_AXG select it
> instead?
> selecting MESON_SM is probably no-op on Meson8 and Meson8b (which
> don't have the GX secure monitor), but I haven't tested it yet
Hi Martin, you are right !
I will fix it on v2..
Neil
>
>
> Regards
> Martin
>
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/5] pinctrl: meson: Add support to set direction with a secure monitor call
Date: Thu, 2 Aug 2018 09:52:53 +0200 [thread overview]
Message-ID: <d319d871-ba93-ab1d-dae4-b44916161e85@baylibre.com> (raw)
In-Reply-To: <CAFBinCBcUijFGdLoQwkzioX7MF0H_gH1rbcvxG+UWc1rA2pRiQ@mail.gmail.com>
On 01/08/2018 22:23, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Wed, Aug 1, 2018 at 12:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> The Amlogic Meson GX and AXG SoCs needs to do a Secure Monitor call to
>> set the TEST_N pin direction.
>> This patch adds a "smc" boolean to the bank structure to differentiate
>> the TEST_N bank and call the Secure Monitor in the _input/_output functions.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> drivers/pinctrl/meson/Kconfig | 1 +
>> drivers/pinctrl/meson/pinctrl-meson.c | 31 ++++++++++++++++++++++++++-----
>> drivers/pinctrl/meson/pinctrl-meson.h | 10 +++++++++-
>> 3 files changed, 36 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/pinctrl/meson/Kconfig b/drivers/pinctrl/meson/Kconfig
>> index c80951d..1b90470 100644
>> --- a/drivers/pinctrl/meson/Kconfig
>> +++ b/drivers/pinctrl/meson/Kconfig
>> @@ -8,6 +8,7 @@ menuconfig PINCTRL_MESON
>> select GPIOLIB
>> select OF_GPIO
>> select REGMAP_MMIO
>> + select MESON_SM
> I wonder why PINCTRL_MESON has to select MESON_SM - shouldn't
> PINCTRL_MESON_GXBB, PINCTRL_MESON_GXL and PINCTRL_MESON_AXG select it
> instead?
> selecting MESON_SM is probably no-op on Meson8 and Meson8b (which
> don't have the GX secure monitor), but I haven't tested it yet
Hi Martin, you are right !
I will fix it on v2..
Neil
>
>
> Regards
> Martin
>
next prev parent reply other threads:[~2018-08-02 7:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 10:00 [PATCH 0/5] pinctrl: meson: Add support for TEST_N gpio Neil Armstrong
2018-08-01 10:00 ` Neil Armstrong
2018-08-01 10:00 ` Neil Armstrong
2018-08-01 10:00 ` [PATCH 2/5] pinctrl: meson: Add support to set direction with a secure monitor call Neil Armstrong
2018-08-01 10:00 ` Neil Armstrong
2018-08-01 10:00 ` Neil Armstrong
2018-08-01 20:23 ` Martin Blumenstingl
2018-08-01 20:23 ` Martin Blumenstingl
2018-08-01 20:23 ` Martin Blumenstingl
2018-08-01 20:23 ` Martin Blumenstingl
2018-08-02 7:52 ` Neil Armstrong [this message]
2018-08-02 7:52 ` Neil Armstrong
2018-08-02 7:52 ` Neil Armstrong
2018-08-02 11:21 ` Jerome Brunet
2018-08-02 11:21 ` Jerome Brunet
2018-08-02 11:21 ` Jerome Brunet
2018-08-02 20:42 ` Martin Blumenstingl
2018-08-02 20:42 ` Martin Blumenstingl
2018-08-02 20:42 ` Martin Blumenstingl
2018-08-03 8:10 ` Neil Armstrong
2018-08-03 8:10 ` Neil Armstrong
2018-08-03 8:10 ` Neil Armstrong
2018-08-01 10:00 ` [PATCH 3/5] meson: pinctrl-gxbb: add support for TEST_N pin Neil Armstrong
2018-08-01 10:00 ` Neil Armstrong
2018-08-01 10:00 ` Neil Armstrong
2018-08-01 10:00 ` [PATCH 4/5] meson: pinctrl-gxl: " Neil Armstrong
2018-08-01 10:00 ` Neil Armstrong
2018-08-01 10:00 ` Neil Armstrong
2018-08-01 10:00 ` [PATCH 5/5] meson: pinctrl-axg: " Neil Armstrong
2018-08-01 10:00 ` Neil Armstrong
2018-08-01 10:00 ` Neil Armstrong
2018-08-01 10:04 ` [PATCH 1/5] meson_sm: add TEST_N pin direction call Neil Armstrong
2018-08-01 10:04 ` Neil Armstrong
2018-08-01 10:04 ` Neil Armstrong
2018-08-03 17:06 ` Linus Walleij
2018-08-03 17:06 ` Linus Walleij
2018-08-03 17:06 ` Linus Walleij
2018-08-03 17:10 ` [PATCH 0/5] pinctrl: meson: Add support for TEST_N gpio Linus Walleij
2018-08-03 17:10 ` Linus Walleij
2018-08-03 17:10 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d319d871-ba93-ab1d-dae4-b44916161e85@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.