* [PATCH] vicodec: lower minimum height to 360
@ 2018-10-10 7:03 Hans Verkuil
2018-10-10 9:24 ` Kieran Bingham
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2018-10-10 7:03 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Helen Koike
Lower the minimum height to 360 to be consistent with the webcam input of vivid.
The 480 was rather arbitrary but it made it harder to use vivid as a source for
encoding since the default resolution when you load vivid is 640x360.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c
index 1eb9132bfc85..b292cff26c86 100644
--- a/drivers/media/platform/vicodec/vicodec-core.c
+++ b/drivers/media/platform/vicodec/vicodec-core.c
@@ -42,7 +42,7 @@ MODULE_PARM_DESC(debug, " activates debug info");
#define MAX_WIDTH 4096U
#define MIN_WIDTH 640U
#define MAX_HEIGHT 2160U
-#define MIN_HEIGHT 480U
+#define MIN_HEIGHT 360U
#define dprintk(dev, fmt, arg...) \
v4l2_dbg(1, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vicodec: lower minimum height to 360
2018-10-10 7:03 [PATCH] vicodec: lower minimum height to 360 Hans Verkuil
@ 2018-10-10 9:24 ` Kieran Bingham
0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2018-10-10 9:24 UTC (permalink / raw)
To: Hans Verkuil, Linux Media Mailing List; +Cc: Helen Koike
Hi Hans,
Thank you for the patch,
On 10/10/18 08:03, Hans Verkuil wrote:
> Lower the minimum height to 360 to be consistent with the webcam input of vivid.
>
> The 480 was rather arbitrary but it made it harder to use vivid as a source for
> encoding since the default resolution when you load vivid is 640x360.
As this is a virtual codec, is the minimum width and height really so
'large' ?
What about 320x240 or such? (or even 32x32...)
Or is the aim to provide minimum frame sizes and a means to verify
userspace correctly handles the minimum frame sizes too ?
I could certainly acknowledge it's worth providing a means for a
userspace app to test that it handles minimum sizes correctly.
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
If the minimum is desired:
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c
> index 1eb9132bfc85..b292cff26c86 100644
> --- a/drivers/media/platform/vicodec/vicodec-core.c
> +++ b/drivers/media/platform/vicodec/vicodec-core.c
> @@ -42,7 +42,7 @@ MODULE_PARM_DESC(debug, " activates debug info");
> #define MAX_WIDTH 4096U
> #define MIN_WIDTH 640U
> #define MAX_HEIGHT 2160U
> -#define MIN_HEIGHT 480U
> +#define MIN_HEIGHT 360U
>
> #define dprintk(dev, fmt, arg...) \
> v4l2_dbg(1, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-10 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-10 7:03 [PATCH] vicodec: lower minimum height to 360 Hans Verkuil
2018-10-10 9:24 ` Kieran Bingham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.