* [Buildroot] [PATCH 1/1] package/libssh2: bump version
@ 2018-09-11 20:56 Bernd Kuhls
2018-09-12 8:30 ` Thomas Petazzoni
2018-09-12 14:33 ` Thomas Petazzoni
0 siblings, 2 replies; 7+ messages in thread
From: Bernd Kuhls @ 2018-09-11 20:56 UTC (permalink / raw)
To: buildroot
Added license hash.
This bump includes "ECDSA key types are now explicit"
https://github.com/libssh2/libssh2/commit/62b825c8afb9e5efb6ea9c05b40b309590249fb6
which is needed by vlc since
http://git.videolan.org/?p=vlc.git;a=commitdiff;h=afee1e72a8e08866bbe35d1a57e859cac81052b4
Fixes
http://autobuild.buildroot.net/results/579/579e2418e59680ad4bf3dc85f2918457b6221bfa/
http://autobuild.buildroot.net/results/c73/c7348c442d3f585ace0bc62860f802dc08150776/
http://autobuild.buildroot.net/results/731/73187b883d7fe14b08a4903b326706c9d1f8b519/
http://autobuild.buildroot.net/results/f6d/f6d4fca6063c81a8e240fed4db89269e455f057e/
http://autobuild.buildroot.net/results/371/371f4f017f4a5af0ac6d6a8b1b8276858ad47f75/
http://autobuild.buildroot.net/results/d6a/d6a3b43211eb740bdebbb339668b854d26e878b7/
http://autobuild.buildroot.net/results/a05/a0576aeeb57a49958e5229d9ec08f2bd792d48b6/
http://autobuild.buildroot.net/results/57a/57a9ae2f157183a86fbf1b2cc5cbb38e948690ce/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/libssh2/libssh2.hash | 3 ++-
package/libssh2/libssh2.mk | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/package/libssh2/libssh2.hash b/package/libssh2/libssh2.hash
index d36262ad9a..d57c8d7062 100644
--- a/package/libssh2/libssh2.hash
+++ b/package/libssh2/libssh2.hash
@@ -1,2 +1,3 @@
# Locally calculated
-sha256 e73d55cd512863aa6423c6e137039e3e1bcbf5ba87f130e7441132c2c78a5425 libssh2-616fd4d1b3e4a55de67c48819fefca83132126b5.tar.gz
+sha256 ec2b32b44ae5f8fe094f663f63953fb31314de838eb36e8c47e5a89137b5a1bc libssh2-8b870ad771cbd9cd29edbb3dbb0878e950f868ab.tar.gz
+sha256 e15ed284a15e80115467d6d7f030f0d89d8fabbecd78fb6e0f861f0cfc128fd9 COPYING
diff --git a/package/libssh2/libssh2.mk b/package/libssh2/libssh2.mk
index c5b0bd855e..0e13701b29 100644
--- a/package/libssh2/libssh2.mk
+++ b/package/libssh2/libssh2.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LIBSSH2_VERSION = 616fd4d1b3e4a55de67c48819fefca83132126b5
+LIBSSH2_VERSION = 8b870ad771cbd9cd29edbb3dbb0878e950f868ab
LIBSSH2_SITE = $(call github,libssh2,libssh2,$(LIBSSH2_VERSION))
LIBSSH2_LICENSE = BSD
LIBSSH2_LICENSE_FILES = COPYING
--
2.18.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/libssh2: bump version
2018-09-11 20:56 [Buildroot] [PATCH 1/1] package/libssh2: bump version Bernd Kuhls
@ 2018-09-12 8:30 ` Thomas Petazzoni
2018-09-12 14:33 ` Thomas Petazzoni
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2018-09-12 8:30 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 11 Sep 2018 22:56:13 +0200, Bernd Kuhls wrote:
> Added license hash.
>
> This bump includes "ECDSA key types are now explicit"
> https://github.com/libssh2/libssh2/commit/62b825c8afb9e5efb6ea9c05b40b309590249fb6
>
> which is needed by vlc since
> http://git.videolan.org/?p=vlc.git;a=commitdiff;h=afee1e72a8e08866bbe35d1a57e859cac81052b4
>
> Fixes
> http://autobuild.buildroot.net/results/579/579e2418e59680ad4bf3dc85f2918457b6221bfa/
> http://autobuild.buildroot.net/results/c73/c7348c442d3f585ace0bc62860f802dc08150776/
> http://autobuild.buildroot.net/results/731/73187b883d7fe14b08a4903b326706c9d1f8b519/
> http://autobuild.buildroot.net/results/f6d/f6d4fca6063c81a8e240fed4db89269e455f057e/
> http://autobuild.buildroot.net/results/371/371f4f017f4a5af0ac6d6a8b1b8276858ad47f75/
> http://autobuild.buildroot.net/results/d6a/d6a3b43211eb740bdebbb339668b854d26e878b7/
> http://autobuild.buildroot.net/results/a05/a0576aeeb57a49958e5229d9ec08f2bd792d48b6/
> http://autobuild.buildroot.net/results/57a/57a9ae2f157183a86fbf1b2cc5cbb38e948690ce/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/libssh2/libssh2.hash | 3 ++-
> package/libssh2/libssh2.mk | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/libssh2: bump version
2018-09-11 20:56 [Buildroot] [PATCH 1/1] package/libssh2: bump version Bernd Kuhls
2018-09-12 8:30 ` Thomas Petazzoni
@ 2018-09-12 14:33 ` Thomas Petazzoni
2018-09-13 6:16 ` Bernd Kuhls
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2018-09-12 14:33 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 11 Sep 2018 22:56:13 +0200, Bernd Kuhls wrote:
> -LIBSSH2_VERSION = 616fd4d1b3e4a55de67c48819fefca83132126b5
> +LIBSSH2_VERSION = 8b870ad771cbd9cd29edbb3dbb0878e950f868ab
Looks like this new version has issues:
http://autobuild.buildroot.net/?reason=libssh2-8b870ad771cbd9cd29edbb3dbb0878e950f868ab
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/libssh2: bump version
2018-09-12 14:33 ` Thomas Petazzoni
@ 2018-09-13 6:16 ` Bernd Kuhls
2018-09-13 6:56 ` Giulio Benetti
0 siblings, 1 reply; 7+ messages in thread
From: Bernd Kuhls @ 2018-09-13 6:16 UTC (permalink / raw)
To: buildroot
Am Wed, 12 Sep 2018 16:33:44 +0200 schrieb Thomas Petazzoni:
> Hello,
>
> On Tue, 11 Sep 2018 22:56:13 +0200, Bernd Kuhls wrote:
>
>> -LIBSSH2_VERSION = 616fd4d1b3e4a55de67c48819fefca83132126b5
>> +LIBSSH2_VERSION = 8b870ad771cbd9cd29edbb3dbb0878e950f868ab
>
> Looks like this new version has issues:
>
> http://autobuild.buildroot.net/?
reason=libssh2-8b870ad771cbd9cd29edbb3dbb0878e950f868ab
>
> Thomas
Hi Thomas,
tried both defconfigs from Sep, 12th, both build without issues. I can
not reproduce the problem here (Debian buster), sorry.
Regards, Bernd
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/libssh2: bump version
2018-09-13 6:16 ` Bernd Kuhls
@ 2018-09-13 6:56 ` Giulio Benetti
2018-09-13 8:08 ` [Buildroot] [PATCH] libssh2: fix build failure due to pointer dereferencing ambiguity Giulio Benetti
0 siblings, 1 reply; 7+ messages in thread
From: Giulio Benetti @ 2018-09-13 6:56 UTC (permalink / raw)
To: buildroot
Hello,
Il 13/09/2018 08:16, Bernd Kuhls ha scritto:
> Am Wed, 12 Sep 2018 16:33:44 +0200 schrieb Thomas Petazzoni:
>
>> Hello,
>>
>> On Tue, 11 Sep 2018 22:56:13 +0200, Bernd Kuhls wrote:
>>
>>> -LIBSSH2_VERSION = 616fd4d1b3e4a55de67c48819fefca83132126b5
>>> +LIBSSH2_VERSION = 8b870ad771cbd9cd29edbb3dbb0878e950f868ab
>>
>> Looks like this new version has issues:
>>
>> http://autobuild.buildroot.net/?
> reason=libssh2-8b870ad771cbd9cd29edbb3dbb0878e950f868ab
>>
>> Thomas
>
> Hi Thomas,
>
> tried both defconfigs from Sep, 12th, both build without issues. I can
> not reproduce the problem here (Debian buster), sorry.
I can reproduce, gonna try to fix this.
Best regards
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] libssh2: fix build failure due to pointer dereferencing ambiguity
2018-09-13 6:56 ` Giulio Benetti
@ 2018-09-13 8:08 ` Giulio Benetti
2018-09-16 14:11 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Giulio Benetti @ 2018-09-13 8:08 UTC (permalink / raw)
To: buildroot
When dereferencing from *aes_ctr_cipher, being a pointer itself,
ambiguity can occur with compiler and build can fail reporting:
openssl.c:574:20: error: ?*aes_ctr_cipher? is a pointer; did you mean to use ?->??
*aes_ctr_cipher->nid = type;
Add a patch to sorround every *aes_ctr_cipher-> occurence with
paranthesis like this (*aes_ctr_cipher)->
Fixes:
http://autobuild.buildroot.net/results/97c/97c43dd2122f55f3166683aa1b29ce1ca54bcb9c/
http://autobuild.buildroot.net/results/4b7/4b728d275f1399e3cb72d40482076ee54b35852a/
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
...ferencing-ambiguity-potentially-caus.patch | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
create mode 100644 package/libssh2/0003-openssl-fix-dereferencing-ambiguity-potentially-caus.patch
diff --git a/package/libssh2/0003-openssl-fix-dereferencing-ambiguity-potentially-caus.patch b/package/libssh2/0003-openssl-fix-dereferencing-ambiguity-potentially-caus.patch
new file mode 100644
index 0000000000..3d2a3580b2
--- /dev/null
+++ b/package/libssh2/0003-openssl-fix-dereferencing-ambiguity-potentially-caus.patch
@@ -0,0 +1,50 @@
+From 28fe5e4de437f8fce6e428b7db9bc8640cda4c61 Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <giulio.benetti@micronovasrl.com>
+Date: Thu, 13 Sep 2018 09:51:35 +0200
+Subject: [PATCH] openssl: fix dereferencing ambiguity potentially causing
+ build failure
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+When dereferencing from *aes_ctr_cipher, being a pointer itself,
+ambiguity can occur with compiler and build can fail reporting:
+openssl.c:574:20: error: ?*aes_ctr_cipher? is a pointer; did you mean to use ?->??
+ *aes_ctr_cipher->nid = type;
+
+Sorround every *aes_ctr_cipher-> occurence with paranthesis like this
+(*aes_ctr_cipher)->
+
+Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
+---
+ src/openssl.c | 14 +++++++-------
+ 1 file changed, 7 insertions(+), 7 deletions(-)
+
+diff --git a/src/openssl.c b/src/openssl.c
+index 678d5de..c26aaec 100644
+--- a/src/openssl.c
++++ b/src/openssl.c
+@@ -571,13 +571,13 @@ make_ctr_evp (size_t keylen, EVP_CIPHER **aes_ctr_cipher, int type)
+ EVP_CIPHER_meth_set_cleanup(*aes_ctr_cipher, aes_ctr_cleanup);
+ }
+ #else
+- *aes_ctr_cipher->nid = type;
+- *aes_ctr_cipher->block_size = 16;
+- *aes_ctr_cipher->key_len = keylen;
+- *aes_ctr_cipher->iv_len = 16;
+- *aes_ctr_cipher->init = aes_ctr_init;
+- *aes_ctr_cipher->do_cipher = aes_ctr_do_cipher;
+- *aes_ctr_cipher->cleanup = aes_ctr_cleanup;
++ (*aes_ctr_cipher)->nid = type;
++ (*aes_ctr_cipher)->block_size = 16;
++ (*aes_ctr_cipher)->key_len = keylen;
++ (*aes_ctr_cipher)->iv_len = 16;
++ (*aes_ctr_cipher)->init = aes_ctr_init;
++ (*aes_ctr_cipher)->do_cipher = aes_ctr_do_cipher;
++ (*aes_ctr_cipher)->cleanup = aes_ctr_cleanup;
+ #endif
+
+ return *aes_ctr_cipher;
+--
+2.17.1
+
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] libssh2: fix build failure due to pointer dereferencing ambiguity
2018-09-13 8:08 ` [Buildroot] [PATCH] libssh2: fix build failure due to pointer dereferencing ambiguity Giulio Benetti
@ 2018-09-16 14:11 ` Thomas Petazzoni
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2018-09-16 14:11 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 13 Sep 2018 10:08:54 +0200, Giulio Benetti wrote:
> When dereferencing from *aes_ctr_cipher, being a pointer itself,
> ambiguity can occur with compiler and build can fail reporting:
> openssl.c:574:20: error: ?*aes_ctr_cipher? is a pointer; did you mean to use ?->??
> *aes_ctr_cipher->nid = type;
>
> Add a patch to sorround every *aes_ctr_cipher-> occurence with
> paranthesis like this (*aes_ctr_cipher)->
>
> Fixes:
> http://autobuild.buildroot.net/results/97c/97c43dd2122f55f3166683aa1b29ce1ca54bcb9c/
> http://autobuild.buildroot.net/results/4b7/4b728d275f1399e3cb72d40482076ee54b35852a/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> ...ferencing-ambiguity-potentially-caus.patch | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 package/libssh2/0003-openssl-fix-dereferencing-ambiguity-potentially-caus.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-09-16 14:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-11 20:56 [Buildroot] [PATCH 1/1] package/libssh2: bump version Bernd Kuhls
2018-09-12 8:30 ` Thomas Petazzoni
2018-09-12 14:33 ` Thomas Petazzoni
2018-09-13 6:16 ` Bernd Kuhls
2018-09-13 6:56 ` Giulio Benetti
2018-09-13 8:08 ` [Buildroot] [PATCH] libssh2: fix build failure due to pointer dereferencing ambiguity Giulio Benetti
2018-09-16 14:11 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.