All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: mvpp2: setup link irqs for ports with in-band-status phylink
@ 2019-05-28 20:03 Yanko Kaneti
  0 siblings, 0 replies; only message in thread
From: Yanko Kaneti @ 2019-05-28 20:03 UTC (permalink / raw)
  To: netdev

Hello

This might be misguided but it seems to fix link status on my mcbin-
singleshot SFP+ ports

-Yanko

-- >8 --

MACCHIATObin Single-shot uses the direct-to-MAC SFP+ ports setup
which phylink supports in in-band-status mode. Don't assume
phylink means external phy and connect the link irqs.

Signed-off-by: Yanko Kaneti <yaneti@declera.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index d38952eb7aa9..2f6acc38087c 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -3447,7 +3447,7 @@ static int mvpp2_open(struct net_device *dev)
 		valid = true;
 	}
 
-	if (priv->hw_version == MVPP22 && port->link_irq && !port->phylink) {
+	if (priv->hw_version == MVPP22 && port->link_irq && !port->has_phy) {
 		err = request_irq(port->link_irq, mvpp2_link_status_isr, 0,
 				  dev->name, port);
 		if (err) {
-- 



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-05-28 20:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 20:03 [PATCH] net: mvpp2: setup link irqs for ports with in-band-status phylink Yanko Kaneti

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.