* [GIT PULL] Third Round of Renesas ARM64 Based SoC DT Updates for v4.5
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
Hi Olof, Hi Kevin, Hi Arnd,
Please consider these third round of Renesas ARM64 based SoC DT updates
for v4.5.
This pull request is based on the previous round of
such requests, tagged as renesas-arm64-dt2-for-v4.5,
which you have already pulled.
The following changes since commit 672b79312c04016481a11d4b996b4512207ffbd3:
arm64: renesas: salvator-x: Sound DVC support (2015-11-26 11:31:43 +0900)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm64-dt3-for-v4.5
for you to fetch changes up to 2eb2b5066197eab00c55dcd1132f17836e4975b2:
arm64: renesas: r8a7795: fix SATA clock assignment (2015-12-18 10:07:29 +0900)
----------------------------------------------------------------
Third Round of Renesas ARM64 Based SoC DT Updates for v4.5
* Enable SATA
* Add salvator-x part number to DT bindings documentation
* Enable all four A57 cores instead of just one
* Enhanced audio support:
- Use CS2000 as AUDIO_CLK_B
- Set ak4613 In/Out pin as single-end
----------------------------------------------------------------
Gaku Inami (2):
arm64: dts: r8a7795: Add PSCI node
arm64: dts: r8a7795: Add Cortex-A57 CPU cores
Geert Uytterhoeven (1):
arm64: renesas: salvator-x: Add board part number to DT bindings
Kouei Abe (2):
arm64: dts: r8a7795: Add SATA controller node
arm64: dts: salvator-x: Enable SATA controller
Kuninori Morimoto (2):
arm64: renesas: salvator-x: set ak4613 In/Out pin as single-end
arm64: renesas: salvator-x: use CS2000 as AUDIO_CLK_B
Ulrich Hecht (1):
arm64: renesas: r8a7795: fix SATA clock assignment
Wolfram Sang (1):
arm64: renesas: r8a7795: add internal delay for i2c IPs
Yoshifumi Hosoya (1):
arm64: dts: r8a7795: Add pmu device nodes
Documentation/devicetree/bindings/arm/shmobile.txt | 2 +-
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 51 +++++++++++++++++
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 64 ++++++++++++++++++++--
3 files changed, 110 insertions(+), 7 deletions(-)
^ permalink raw reply [flat|nested] 49+ messages in thread* [PATCH 01/10] arm64: renesas: salvator-x: set ak4613 In/Out pin as single-end
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 2:29 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index c5f709e7c0ba..beeacfaf18d0 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -141,6 +141,15 @@
#sound-dai-cells = <0>;
reg = <0x10>;
clocks = <&rcar_sound 3>;
+
+ asahi-kasei,in1-single-end;
+ asahi-kasei,in2-single-end;
+ asahi-kasei,out1-single-end;
+ asahi-kasei,out2-single-end;
+ asahi-kasei,out3-single-end;
+ asahi-kasei,out4-single-end;
+ asahi-kasei,out5-single-end;
+ asahi-kasei,out6-single-end;
};
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 01/10] arm64: renesas: salvator-x: set ak4613 In/Out pin as single-end
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index c5f709e7c0ba..beeacfaf18d0 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -141,6 +141,15 @@
#sound-dai-cells = <0>;
reg = <0x10>;
clocks = <&rcar_sound 3>;
+
+ asahi-kasei,in1-single-end;
+ asahi-kasei,in2-single-end;
+ asahi-kasei,out1-single-end;
+ asahi-kasei,out2-single-end;
+ asahi-kasei,out3-single-end;
+ asahi-kasei,out4-single-end;
+ asahi-kasei,out5-single-end;
+ asahi-kasei,out6-single-end;
};
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 02/10] arm64: renesas: salvator-x: use CS2000 as AUDIO_CLK_B
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 2:29 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
CS2000 needs AUDIO_CLKOUT as master clock which is generated
by Renesas sound, and Renesas sound needs CS2000 as ADUIO_CLK_B.
Because of this relationship, it will be dead-lock when driver probe.
cs2000: clk_multiplier@4f {
...
clocks = <&rcar_sound 0>, <&x12_clk>;
...
};
&rcar_sound {
...
assigned-clocks = <&cs2000>;
...
};
This patch is using dummy audio_clkout to avoid this issue.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 38 ++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index beeacfaf18d0..75af5ec5a4d4 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -61,6 +61,16 @@
clock-frequency = <24576000>;
};
+ audio_clkout: audio_clkout {
+ /*
+ * This is same as <&rcar_sound 0>
+ * but needed to avoid cs2000/rcar_sound probe dead-lock
+ */
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <11289600>;
+ };
+
rsnd_ak4613: sound {
compatible = "simple-audio-card";
@@ -151,6 +161,17 @@
asahi-kasei,out5-single-end;
asahi-kasei,out6-single-end;
};
+
+ cs2000: clk_multiplier@4f {
+ #clock-cells = <0>;
+ compatible = "cirrus,cs2000-cp";
+ reg = <0x4f>;
+ clocks = <&audio_clkout>, <&x12_clk>;
+ clock-names = "clk_in", "ref_clk";
+
+ assigned-clocks = <&cs2000>;
+ assigned-clock-rates = <24576000>; /* 1/1 divide */
+ };
};
&rcar_sound {
@@ -166,6 +187,23 @@
status = "okay";
+ /* update <audio_clk_b> to <cs2000> */
+ clocks = <&cpg CPG_MOD 1005>,
+ <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>,
+ <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>,
+ <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>,
+ <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>,
+ <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>,
+ <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>,
+ <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>,
+ <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
+ <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
+ <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
+ <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
+ <&audio_clk_a>, <&cs2000>,
+ <&audio_clk_c>,
+ <&cpg CPG_CORE R8A7795_CLK_S0D4>;
+
rcar_sound,dai {
dai0 {
playback = <&ssi0 &src0 &dvc0>;
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 02/10] arm64: renesas: salvator-x: use CS2000 as AUDIO_CLK_B
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
CS2000 needs AUDIO_CLKOUT as master clock which is generated
by Renesas sound, and Renesas sound needs CS2000 as ADUIO_CLK_B.
Because of this relationship, it will be dead-lock when driver probe.
cs2000: clk_multiplier at 4f {
...
clocks = <&rcar_sound 0>, <&x12_clk>;
...
};
&rcar_sound {
...
assigned-clocks = <&cs2000>;
...
};
This patch is using dummy audio_clkout to avoid this issue.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 38 ++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index beeacfaf18d0..75af5ec5a4d4 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -61,6 +61,16 @@
clock-frequency = <24576000>;
};
+ audio_clkout: audio_clkout {
+ /*
+ * This is same as <&rcar_sound 0>
+ * but needed to avoid cs2000/rcar_sound probe dead-lock
+ */
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <11289600>;
+ };
+
rsnd_ak4613: sound {
compatible = "simple-audio-card";
@@ -151,6 +161,17 @@
asahi-kasei,out5-single-end;
asahi-kasei,out6-single-end;
};
+
+ cs2000: clk_multiplier at 4f {
+ #clock-cells = <0>;
+ compatible = "cirrus,cs2000-cp";
+ reg = <0x4f>;
+ clocks = <&audio_clkout>, <&x12_clk>;
+ clock-names = "clk_in", "ref_clk";
+
+ assigned-clocks = <&cs2000>;
+ assigned-clock-rates = <24576000>; /* 1/1 divide */
+ };
};
&rcar_sound {
@@ -166,6 +187,23 @@
status = "okay";
+ /* update <audio_clk_b> to <cs2000> */
+ clocks = <&cpg CPG_MOD 1005>,
+ <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>,
+ <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>,
+ <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>,
+ <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>,
+ <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>,
+ <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>,
+ <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>,
+ <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
+ <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
+ <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
+ <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
+ <&audio_clk_a>, <&cs2000>,
+ <&audio_clk_c>,
+ <&cpg CPG_CORE R8A7795_CLK_S0D4>;
+
rcar_sound,dai {
dai0 {
playback = <&ssi0 &src0 &dvc0>;
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 03/10] arm64: dts: r8a7795: Add PSCI node
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 2:29 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Add PSCI node for r8a7795 SoC, and cpu node enable-method property is
set to "psci".
Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index b1902ea1dae4..051ff143506e 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -26,6 +26,11 @@
i2c6 = &i2c6;
};
+ psci {
+ compatible = "arm,psci-0.2";
+ method = "smc";
+ };
+
cpus {
#address-cells = <1>;
#size-cells = <0>;
@@ -35,6 +40,7 @@
compatible = "arm,cortex-a57", "arm,armv8";
reg = <0x0>;
device_type = "cpu";
+ enable-method = "psci";
};
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 03/10] arm64: dts: r8a7795: Add PSCI node
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Add PSCI node for r8a7795 SoC, and cpu node enable-method property is
set to "psci".
Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index b1902ea1dae4..051ff143506e 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -26,6 +26,11 @@
i2c6 = &i2c6;
};
+ psci {
+ compatible = "arm,psci-0.2";
+ method = "smc";
+ };
+
cpus {
#address-cells = <1>;
#size-cells = <0>;
@@ -35,6 +40,7 @@
compatible = "arm,cortex-a57", "arm,armv8";
reg = <0x0>;
device_type = "cpu";
+ enable-method = "psci";
};
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 04/10] arm64: dts: r8a7795: Add Cortex-A57 CPU cores
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 2:29 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Add Cortex-A57 CPU cores to r8a7795 SoC for a total of 4 x Cortex-A57.
Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Sigend-off-by: Dirk Behme <dirk.behme@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 31 +++++++++++++++++++++++++------
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 051ff143506e..4d43cf31418f 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -35,13 +35,31 @@
#address-cells = <1>;
#size-cells = <0>;
- /* 1 core only at this point */
a57_0: cpu@0 {
compatible = "arm,cortex-a57", "arm,armv8";
reg = <0x0>;
device_type = "cpu";
enable-method = "psci";
};
+
+ a57_1: cpu@1 {
+ compatible = "arm,cortex-a57","arm,armv8";
+ reg = <0x1>;
+ device_type = "cpu";
+ enable-method = "psci";
+ };
+ a57_2: cpu@2 {
+ compatible = "arm,cortex-a57","arm,armv8";
+ reg = <0x2>;
+ device_type = "cpu";
+ enable-method = "psci";
+ };
+ a57_3: cpu@3 {
+ compatible = "arm,cortex-a57","arm,armv8";
+ reg = <0x3>;
+ device_type = "cpu";
+ enable-method = "psci";
+ };
};
extal_clk: extal {
@@ -84,6 +102,7 @@
soc {
compatible = "simple-bus";
interrupt-parent = <&gic>;
+
#address-cells = <2>;
#size-cells = <2>;
ranges;
@@ -96,7 +115,7 @@
reg = <0x0 0xf1010000 0 0x1000>,
<0x0 0xf1020000 0 0x2000>;
interrupts = <GIC_PPI 9
- (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_HIGH)>;
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
};
gpio0: gpio@e6050000 {
@@ -214,13 +233,13 @@
timer {
compatible = "arm,armv8-timer";
interrupts = <GIC_PPI 13
- (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 14
- (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 11
- (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 10
- (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>;
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
};
cpg: clock-controller@e6150000 {
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 04/10] arm64: dts: r8a7795: Add Cortex-A57 CPU cores
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Add Cortex-A57 CPU cores to r8a7795 SoC for a total of 4 x Cortex-A57.
Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Sigend-off-by: Dirk Behme <dirk.behme@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 31 +++++++++++++++++++++++++------
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 051ff143506e..4d43cf31418f 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -35,13 +35,31 @@
#address-cells = <1>;
#size-cells = <0>;
- /* 1 core only at this point */
a57_0: cpu at 0 {
compatible = "arm,cortex-a57", "arm,armv8";
reg = <0x0>;
device_type = "cpu";
enable-method = "psci";
};
+
+ a57_1: cpu at 1 {
+ compatible = "arm,cortex-a57","arm,armv8";
+ reg = <0x1>;
+ device_type = "cpu";
+ enable-method = "psci";
+ };
+ a57_2: cpu at 2 {
+ compatible = "arm,cortex-a57","arm,armv8";
+ reg = <0x2>;
+ device_type = "cpu";
+ enable-method = "psci";
+ };
+ a57_3: cpu at 3 {
+ compatible = "arm,cortex-a57","arm,armv8";
+ reg = <0x3>;
+ device_type = "cpu";
+ enable-method = "psci";
+ };
};
extal_clk: extal {
@@ -84,6 +102,7 @@
soc {
compatible = "simple-bus";
interrupt-parent = <&gic>;
+
#address-cells = <2>;
#size-cells = <2>;
ranges;
@@ -96,7 +115,7 @@
reg = <0x0 0xf1010000 0 0x1000>,
<0x0 0xf1020000 0 0x2000>;
interrupts = <GIC_PPI 9
- (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_HIGH)>;
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
};
gpio0: gpio at e6050000 {
@@ -214,13 +233,13 @@
timer {
compatible = "arm,armv8-timer";
interrupts = <GIC_PPI 13
- (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 14
- (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 11
- (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 10
- (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>;
+ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
};
cpg: clock-controller at e6150000 {
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 2:29 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Enabling the performance monitor unit on r8a7795.
Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 4d43cf31418f..b9229a49dabc 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -230,6 +230,18 @@
power-domains = <&cpg>;
};
+ pmu {
+ compatible = "arm,armv8-pmuv3";
+ interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-affinity = <&a57_0>,
+ <&a57_1>,
+ <&a57_2>,
+ <&a57_3>;
+ };
+
timer {
compatible = "arm,armv8-timer";
interrupts = <GIC_PPI 13
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Enabling the performance monitor unit on r8a7795.
Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 4d43cf31418f..b9229a49dabc 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -230,6 +230,18 @@
power-domains = <&cpg>;
};
+ pmu {
+ compatible = "arm,armv8-pmuv3";
+ interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-affinity = <&a57_0>,
+ <&a57_1>,
+ <&a57_2>,
+ <&a57_3>;
+ };
+
timer {
compatible = "arm,armv8-timer";
interrupts = <GIC_PPI 13
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread* Re: [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 10:16 ` Sudeep Holla
-1 siblings, 0 replies; 49+ messages in thread
From: Sudeep Holla @ 2015-12-18 10:16 UTC (permalink / raw)
To: linux-arm-kernel
On 18/12/15 02:29, Simon Horman wrote:
> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>
> Enabling the performance monitor unit on r8a7795.
>
> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 4d43cf31418f..b9229a49dabc 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -230,6 +230,18 @@
> power-domains = <&cpg>;
> };
>
> + pmu {
> + compatible = "arm,armv8-pmuv3";
Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned this
for some shmobile platform recently.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 49+ messages in thread* [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
@ 2015-12-18 10:16 ` Sudeep Holla
0 siblings, 0 replies; 49+ messages in thread
From: Sudeep Holla @ 2015-12-18 10:16 UTC (permalink / raw)
To: linux-arm-kernel
On 18/12/15 02:29, Simon Horman wrote:
> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>
> Enabling the performance monitor unit on r8a7795.
>
> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 4d43cf31418f..b9229a49dabc 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -230,6 +230,18 @@
> power-domains = <&cpg>;
> };
>
> + pmu {
> + compatible = "arm,armv8-pmuv3";
Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned this
for some shmobile platform recently.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
2015-12-18 10:16 ` Sudeep Holla
@ 2015-12-18 10:44 ` Dirk Behme
-1 siblings, 0 replies; 49+ messages in thread
From: Dirk Behme @ 2015-12-18 10:44 UTC (permalink / raw)
To: linux-arm-kernel
On 18.12.2015 11:16, Sudeep Holla wrote:
>
>
> On 18/12/15 02:29, Simon Horman wrote:
>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>
>> Enabling the performance monitor unit on r8a7795.
>>
>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>> ---
>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> index 4d43cf31418f..b9229a49dabc 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -230,6 +230,18 @@
>> power-domains = <&cpg>;
>> };
>>
>> + pmu {
>> + compatible = "arm,armv8-pmuv3";
>
> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned this
> for some shmobile platform recently.
Yes. But as this patch has been applied already to some branches, I
incorporated your a57-pmu hint with an additional update patch:
http://marc.info/?l=linux-sh&m\x145011467914857
Feel free to squash if still possible.
Best regards
Dirk
^ permalink raw reply [flat|nested] 49+ messages in thread* [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
@ 2015-12-18 10:44 ` Dirk Behme
0 siblings, 0 replies; 49+ messages in thread
From: Dirk Behme @ 2015-12-18 10:44 UTC (permalink / raw)
To: linux-arm-kernel
On 18.12.2015 11:16, Sudeep Holla wrote:
>
>
> On 18/12/15 02:29, Simon Horman wrote:
>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>
>> Enabling the performance monitor unit on r8a7795.
>>
>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>> ---
>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> index 4d43cf31418f..b9229a49dabc 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -230,6 +230,18 @@
>> power-domains = <&cpg>;
>> };
>>
>> + pmu {
>> + compatible = "arm,armv8-pmuv3";
>
> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned this
> for some shmobile platform recently.
Yes. But as this patch has been applied already to some branches, I
incorporated your a57-pmu hint with an additional update patch:
http://marc.info/?l=linux-sh&m=145011467914857
Feel free to squash if still possible.
Best regards
Dirk
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
2015-12-18 10:44 ` Dirk Behme
@ 2015-12-18 10:47 ` Sudeep Holla
-1 siblings, 0 replies; 49+ messages in thread
From: Sudeep Holla @ 2015-12-18 10:47 UTC (permalink / raw)
To: linux-arm-kernel
On 18/12/15 10:44, Dirk Behme wrote:
> On 18.12.2015 11:16, Sudeep Holla wrote:
>>
>>
>> On 18/12/15 02:29, Simon Horman wrote:
>>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>
>>> Enabling the performance monitor unit on r8a7795.
>>>
>>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>> ---
>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> index 4d43cf31418f..b9229a49dabc 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> @@ -230,6 +230,18 @@
>>> power-domains = <&cpg>;
>>> };
>>>
>>> + pmu {
>>> + compatible = "arm,armv8-pmuv3";
>>
>> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned this
>> for some shmobile platform recently.
>
>
> Yes. But as this patch has been applied already to some branches, I
> incorporated your a57-pmu hint with an additional update patch:
>
> http://marc.info/?l=linux-sh&m\x145011467914857
>
> Feel free to squash if still possible.
>
Ah OK, I didn't know the exact dts name, sorry for the noise.
Better if it was posted as part of this series :)
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 49+ messages in thread* [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
@ 2015-12-18 10:47 ` Sudeep Holla
0 siblings, 0 replies; 49+ messages in thread
From: Sudeep Holla @ 2015-12-18 10:47 UTC (permalink / raw)
To: linux-arm-kernel
On 18/12/15 10:44, Dirk Behme wrote:
> On 18.12.2015 11:16, Sudeep Holla wrote:
>>
>>
>> On 18/12/15 02:29, Simon Horman wrote:
>>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>
>>> Enabling the performance monitor unit on r8a7795.
>>>
>>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>> ---
>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> index 4d43cf31418f..b9229a49dabc 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> @@ -230,6 +230,18 @@
>>> power-domains = <&cpg>;
>>> };
>>>
>>> + pmu {
>>> + compatible = "arm,armv8-pmuv3";
>>
>> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned this
>> for some shmobile platform recently.
>
>
> Yes. But as this patch has been applied already to some branches, I
> incorporated your a57-pmu hint with an additional update patch:
>
> http://marc.info/?l=linux-sh&m=145011467914857
>
> Feel free to squash if still possible.
>
Ah OK, I didn't know the exact dts name, sorry for the noise.
Better if it was posted as part of this series :)
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
2015-12-18 10:47 ` Sudeep Holla
@ 2016-01-09 6:36 ` Dirk Behme
-1 siblings, 0 replies; 49+ messages in thread
From: Dirk Behme @ 2016-01-09 6:36 UTC (permalink / raw)
To: linux-arm-kernel
On 18.12.2015 11:47, Sudeep Holla wrote:
>
>
> On 18/12/15 10:44, Dirk Behme wrote:
>> On 18.12.2015 11:16, Sudeep Holla wrote:
>>>
>>>
>>> On 18/12/15 02:29, Simon Horman wrote:
>>>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>>
>>>> Enabling the performance monitor unit on r8a7795.
>>>>
>>>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>>> ---
>>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> index 4d43cf31418f..b9229a49dabc 100644
>>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> @@ -230,6 +230,18 @@
>>>> power-domains = <&cpg>;
>>>> };
>>>>
>>>> + pmu {
>>>> + compatible = "arm,armv8-pmuv3";
>>>
>>> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned
>>> this
>>> for some shmobile platform recently.
>>
>>
>> Yes. But as this patch has been applied already to some branches, I
>> incorporated your a57-pmu hint with an additional update patch:
>>
>> http://marc.info/?l=linux-sh&m\x145011467914857
>>
>> Feel free to squash if still possible.
>>
>
> Ah OK, I didn't know the exact dts name, sorry for the noise.
> Better if it was posted as part of this series :)
I finally found some time to test this
http://marc.info/?l=linux-sh&m\x145011467914857
and surprisingly it doesn't seem to work:
Using "arm,cortex-a57-pmu" results in
hw perfevents: enabled with armv8_cortex_a57 PMU driver, 7 counters
available
hw perfevents: failed to probe PMU!
hw perfevents: failed to register PMU devices!
while switching back to "arm,armv8-pmuv3" successfully gives
hw perfevents: enabled with armv8_pmuv3 PMU driver, 7 counters available
without any further error messages.
Any idea?
Best regards
Dirk
^ permalink raw reply [flat|nested] 49+ messages in thread* [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
@ 2016-01-09 6:36 ` Dirk Behme
0 siblings, 0 replies; 49+ messages in thread
From: Dirk Behme @ 2016-01-09 6:36 UTC (permalink / raw)
To: linux-arm-kernel
On 18.12.2015 11:47, Sudeep Holla wrote:
>
>
> On 18/12/15 10:44, Dirk Behme wrote:
>> On 18.12.2015 11:16, Sudeep Holla wrote:
>>>
>>>
>>> On 18/12/15 02:29, Simon Horman wrote:
>>>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>>
>>>> Enabling the performance monitor unit on r8a7795.
>>>>
>>>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>>> ---
>>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> index 4d43cf31418f..b9229a49dabc 100644
>>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> @@ -230,6 +230,18 @@
>>>> power-domains = <&cpg>;
>>>> };
>>>>
>>>> + pmu {
>>>> + compatible = "arm,armv8-pmuv3";
>>>
>>> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned
>>> this
>>> for some shmobile platform recently.
>>
>>
>> Yes. But as this patch has been applied already to some branches, I
>> incorporated your a57-pmu hint with an additional update patch:
>>
>> http://marc.info/?l=linux-sh&m=145011467914857
>>
>> Feel free to squash if still possible.
>>
>
> Ah OK, I didn't know the exact dts name, sorry for the noise.
> Better if it was posted as part of this series :)
I finally found some time to test this
http://marc.info/?l=linux-sh&m=145011467914857
and surprisingly it doesn't seem to work:
Using "arm,cortex-a57-pmu" results in
hw perfevents: enabled with armv8_cortex_a57 PMU driver, 7 counters
available
hw perfevents: failed to probe PMU!
hw perfevents: failed to register PMU devices!
while switching back to "arm,armv8-pmuv3" successfully gives
hw perfevents: enabled with armv8_pmuv3 PMU driver, 7 counters available
without any further error messages.
Any idea?
Best regards
Dirk
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
2016-01-09 6:36 ` Dirk Behme
@ 2016-01-11 10:18 ` Sudeep Holla
-1 siblings, 0 replies; 49+ messages in thread
From: Sudeep Holla @ 2016-01-11 10:18 UTC (permalink / raw)
To: linux-arm-kernel
On 09/01/16 06:36, Dirk Behme wrote:
> On 18.12.2015 11:47, Sudeep Holla wrote:
>>
>>
>> On 18/12/15 10:44, Dirk Behme wrote:
>>> On 18.12.2015 11:16, Sudeep Holla wrote:
[...]
>>>>
>>>> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned
>>>> this for some shmobile platform recently.
>>>
>>> Yes. But as this patch has been applied already to some branches, I
>>> incorporated your a57-pmu hint with an additional update patch:
>>>
>>> http://marc.info/?l=linux-sh&m\x145011467914857
>>>
>>> Feel free to squash if still possible.
>>>
>>
>> Ah OK, I didn't know the exact dts name, sorry for the noise.
>> Better if it was posted as part of this series :)
>
>
> I finally found some time to test this
>
> http://marc.info/?l=linux-sh&m\x145011467914857
>
> and surprisingly it doesn't seem to work:
>
> Using "arm,cortex-a57-pmu" results in
>
> hw perfevents: enabled with armv8_cortex_a57 PMU driver, 7 counters available
I had a quick look at the DT in the link above and IIUC A57 PMU's are
successfully probed.
> hw perfevents: failed to probe PMU!
> hw perfevents: failed to register PMU devices!
>
This must be for A53 PMUs. So I suspect if the update DT is passed
correctly to the kernel.
> while switching back to "arm,armv8-pmuv3" successfully gives
>
> hw perfevents: enabled with armv8_pmuv3 PMU driver, 7 counters available
>
> without any further error messages.
>
> Any idea?
You need to check if of_pmu_irq_cfg is failing.
Is the updated DT picked up correctly ?
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
@ 2016-01-11 10:18 ` Sudeep Holla
0 siblings, 0 replies; 49+ messages in thread
From: Sudeep Holla @ 2016-01-11 10:18 UTC (permalink / raw)
To: linux-arm-kernel
On 09/01/16 06:36, Dirk Behme wrote:
> On 18.12.2015 11:47, Sudeep Holla wrote:
>>
>>
>> On 18/12/15 10:44, Dirk Behme wrote:
>>> On 18.12.2015 11:16, Sudeep Holla wrote:
[...]
>>>>
>>>> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned
>>>> this for some shmobile platform recently.
>>>
>>> Yes. But as this patch has been applied already to some branches, I
>>> incorporated your a57-pmu hint with an additional update patch:
>>>
>>> http://marc.info/?l=linux-sh&m=145011467914857
>>>
>>> Feel free to squash if still possible.
>>>
>>
>> Ah OK, I didn't know the exact dts name, sorry for the noise.
>> Better if it was posted as part of this series :)
>
>
> I finally found some time to test this
>
> http://marc.info/?l=linux-sh&m=145011467914857
>
> and surprisingly it doesn't seem to work:
>
> Using "arm,cortex-a57-pmu" results in
>
> hw perfevents: enabled with armv8_cortex_a57 PMU driver, 7 counters available
I had a quick look at the DT in the link above and IIUC A57 PMU's are
successfully probed.
> hw perfevents: failed to probe PMU!
> hw perfevents: failed to register PMU devices!
>
This must be for A53 PMUs. So I suspect if the update DT is passed
correctly to the kernel.
> while switching back to "arm,armv8-pmuv3" successfully gives
>
> hw perfevents: enabled with armv8_pmuv3 PMU driver, 7 counters available
>
> without any further error messages.
>
> Any idea?
You need to check if of_pmu_irq_cfg is failing.
Is the updated DT picked up correctly ?
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
2016-01-09 6:36 ` Dirk Behme
@ 2016-01-11 10:39 ` Mark Rutland
-1 siblings, 0 replies; 49+ messages in thread
From: Mark Rutland @ 2016-01-11 10:39 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Jan 09, 2016 at 07:36:42AM +0100, Dirk Behme wrote:
> On 18.12.2015 11:47, Sudeep Holla wrote:
> >
> >
> >On 18/12/15 10:44, Dirk Behme wrote:
> >>On 18.12.2015 11:16, Sudeep Holla wrote:
> >>>
> >>>
> >>>On 18/12/15 02:29, Simon Horman wrote:
> >>>>From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> >>>>
> >>>>Enabling the performance monitor unit on r8a7795.
> >>>>
> >>>>Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> >>>>Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> >>>>Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
> >>>>Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>>>---
> >>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
> >>>> 1 file changed, 12 insertions(+)
> >>>>
> >>>>diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>>b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>>index 4d43cf31418f..b9229a49dabc 100644
> >>>>--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>>+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>>@@ -230,6 +230,18 @@
> >>>> power-domains = <&cpg>;
> >>>> };
> >>>>
> >>>>+ pmu {
> >>>>+ compatible = "arm,armv8-pmuv3";
> >>>
> >>>Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned
> >>>this
> >>>for some shmobile platform recently.
> >>
> >>
> >>Yes. But as this patch has been applied already to some branches, I
> >>incorporated your a57-pmu hint with an additional update patch:
> >>
> >>http://marc.info/?l=linux-sh&m\x145011467914857
> >>
> >>Feel free to squash if still possible.
> >>
> >
> >Ah OK, I didn't know the exact dts name, sorry for the noise.
> >Better if it was posted as part of this series :)
>
>
> I finally found some time to test this
>
> http://marc.info/?l=linux-sh&m\x145011467914857
>
> and surprisingly it doesn't seem to work:
>
> Using "arm,cortex-a57-pmu" results in
>
> hw perfevents: enabled with armv8_cortex_a57 PMU driver, 7 counters
> available
This means all the probing logic worked for the A57 PMU.
> hw perfevents: failed to probe PMU!
> hw perfevents: failed to register PMU devices!
These are printed in arm_pmu_device_probe, and following the logic we
must have succesfully allocated the struct pmu, but failed in either
of_pmu_irq_cfg or init_fn (AKA armv8_a53_pmu_init).
In armv8_a53_pmu_init we call armv8pmu_probe_num_events, which will try
to SMP cross-call to an A53 core to probe the number of countesr
implemented. Perhaps the cross-call is failing.
Were the A53s online at this point?
Thanks,
Mark.
^ permalink raw reply [flat|nested] 49+ messages in thread* [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
@ 2016-01-11 10:39 ` Mark Rutland
0 siblings, 0 replies; 49+ messages in thread
From: Mark Rutland @ 2016-01-11 10:39 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Jan 09, 2016 at 07:36:42AM +0100, Dirk Behme wrote:
> On 18.12.2015 11:47, Sudeep Holla wrote:
> >
> >
> >On 18/12/15 10:44, Dirk Behme wrote:
> >>On 18.12.2015 11:16, Sudeep Holla wrote:
> >>>
> >>>
> >>>On 18/12/15 02:29, Simon Horman wrote:
> >>>>From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> >>>>
> >>>>Enabling the performance monitor unit on r8a7795.
> >>>>
> >>>>Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> >>>>Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> >>>>Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
> >>>>Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>>>---
> >>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
> >>>> 1 file changed, 12 insertions(+)
> >>>>
> >>>>diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>>b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>>index 4d43cf31418f..b9229a49dabc 100644
> >>>>--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>>+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>>@@ -230,6 +230,18 @@
> >>>> power-domains = <&cpg>;
> >>>> };
> >>>>
> >>>>+ pmu {
> >>>>+ compatible = "arm,armv8-pmuv3";
> >>>
> >>>Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned
> >>>this
> >>>for some shmobile platform recently.
> >>
> >>
> >>Yes. But as this patch has been applied already to some branches, I
> >>incorporated your a57-pmu hint with an additional update patch:
> >>
> >>http://marc.info/?l=linux-sh&m=145011467914857
> >>
> >>Feel free to squash if still possible.
> >>
> >
> >Ah OK, I didn't know the exact dts name, sorry for the noise.
> >Better if it was posted as part of this series :)
>
>
> I finally found some time to test this
>
> http://marc.info/?l=linux-sh&m=145011467914857
>
> and surprisingly it doesn't seem to work:
>
> Using "arm,cortex-a57-pmu" results in
>
> hw perfevents: enabled with armv8_cortex_a57 PMU driver, 7 counters
> available
This means all the probing logic worked for the A57 PMU.
> hw perfevents: failed to probe PMU!
> hw perfevents: failed to register PMU devices!
These are printed in arm_pmu_device_probe, and following the logic we
must have succesfully allocated the struct pmu, but failed in either
of_pmu_irq_cfg or init_fn (AKA armv8_a53_pmu_init).
In armv8_a53_pmu_init we call armv8pmu_probe_num_events, which will try
to SMP cross-call to an A53 core to probe the number of countesr
implemented. Perhaps the cross-call is failing.
Were the A53s online at this point?
Thanks,
Mark.
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
2016-01-11 10:39 ` Mark Rutland
@ 2016-01-12 8:37 ` Dirk Behme
-1 siblings, 0 replies; 49+ messages in thread
From: Dirk Behme @ 2016-01-12 8:37 UTC (permalink / raw)
To: linux-arm-kernel
On 11.01.2016 11:39, Mark Rutland wrote:
> On Sat, Jan 09, 2016 at 07:36:42AM +0100, Dirk Behme wrote:
>> On 18.12.2015 11:47, Sudeep Holla wrote:
>>>
>>>
>>> On 18/12/15 10:44, Dirk Behme wrote:
>>>> On 18.12.2015 11:16, Sudeep Holla wrote:
>>>>>
>>>>>
>>>>> On 18/12/15 02:29, Simon Horman wrote:
>>>>>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>>>>
>>>>>> Enabling the performance monitor unit on r8a7795.
>>>>>>
>>>>>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>>>>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>>>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>>>>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>>>>> ---
>>>>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>>>>>> 1 file changed, 12 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> index 4d43cf31418f..b9229a49dabc 100644
>>>>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> @@ -230,6 +230,18 @@
>>>>>> power-domains = <&cpg>;
>>>>>> };
>>>>>>
>>>>>> + pmu {
>>>>>> + compatible = "arm,armv8-pmuv3";
>>>>>
>>>>> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned
>>>>> this
>>>>> for some shmobile platform recently.
>>>>
>>>>
>>>> Yes. But as this patch has been applied already to some branches, I
>>>> incorporated your a57-pmu hint with an additional update patch:
>>>>
>>>> http://marc.info/?l=linux-sh&m\x145011467914857
>>>>
>>>> Feel free to squash if still possible.
>>>>
>>>
>>> Ah OK, I didn't know the exact dts name, sorry for the noise.
>>> Better if it was posted as part of this series :)
>>
>>
>> I finally found some time to test this
>>
>> http://marc.info/?l=linux-sh&m\x145011467914857
>>
>> and surprisingly it doesn't seem to work:
>>
>> Using "arm,cortex-a57-pmu" results in
>>
>> hw perfevents: enabled with armv8_cortex_a57 PMU driver, 7 counters
>> available
>
> This means all the probing logic worked for the A57 PMU.
>
>> hw perfevents: failed to probe PMU!
>> hw perfevents: failed to register PMU devices!
>
> These are printed in arm_pmu_device_probe, and following the logic we
> must have succesfully allocated the struct pmu, but failed in either
> of_pmu_irq_cfg or init_fn (AKA armv8_a53_pmu_init).
>
> In armv8_a53_pmu_init we call armv8pmu_probe_num_events, which will try
> to SMP cross-call to an A53 core to probe the number of countesr
> implemented. Perhaps the cross-call is failing.
>
> Were the A53s online at this point?
Ah, indeed, the A53s failed to run.
Maybe anything like
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/398773.html
helps to make this more obvious, then?
Thanks!
Best regards
Dirk
^ permalink raw reply [flat|nested] 49+ messages in thread* [PATCH 05/10] arm64: dts: r8a7795: Add pmu device nodes
@ 2016-01-12 8:37 ` Dirk Behme
0 siblings, 0 replies; 49+ messages in thread
From: Dirk Behme @ 2016-01-12 8:37 UTC (permalink / raw)
To: linux-arm-kernel
On 11.01.2016 11:39, Mark Rutland wrote:
> On Sat, Jan 09, 2016 at 07:36:42AM +0100, Dirk Behme wrote:
>> On 18.12.2015 11:47, Sudeep Holla wrote:
>>>
>>>
>>> On 18/12/15 10:44, Dirk Behme wrote:
>>>> On 18.12.2015 11:16, Sudeep Holla wrote:
>>>>>
>>>>>
>>>>> On 18/12/15 02:29, Simon Horman wrote:
>>>>>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>>>>
>>>>>> Enabling the performance monitor unit on r8a7795.
>>>>>>
>>>>>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>>>>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>>>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>>>>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>>>>> ---
>>>>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>>>>>> 1 file changed, 12 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> index 4d43cf31418f..b9229a49dabc 100644
>>>>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> @@ -230,6 +230,18 @@
>>>>>> power-domains = <&cpg>;
>>>>>> };
>>>>>>
>>>>>> + pmu {
>>>>>> + compatible = "arm,armv8-pmuv3";
>>>>>
>>>>> Please use arm,cortex-a57-pmu to be more specific. IIRC I mentioned
>>>>> this
>>>>> for some shmobile platform recently.
>>>>
>>>>
>>>> Yes. But as this patch has been applied already to some branches, I
>>>> incorporated your a57-pmu hint with an additional update patch:
>>>>
>>>> http://marc.info/?l=linux-sh&m=145011467914857
>>>>
>>>> Feel free to squash if still possible.
>>>>
>>>
>>> Ah OK, I didn't know the exact dts name, sorry for the noise.
>>> Better if it was posted as part of this series :)
>>
>>
>> I finally found some time to test this
>>
>> http://marc.info/?l=linux-sh&m=145011467914857
>>
>> and surprisingly it doesn't seem to work:
>>
>> Using "arm,cortex-a57-pmu" results in
>>
>> hw perfevents: enabled with armv8_cortex_a57 PMU driver, 7 counters
>> available
>
> This means all the probing logic worked for the A57 PMU.
>
>> hw perfevents: failed to probe PMU!
>> hw perfevents: failed to register PMU devices!
>
> These are printed in arm_pmu_device_probe, and following the logic we
> must have succesfully allocated the struct pmu, but failed in either
> of_pmu_irq_cfg or init_fn (AKA armv8_a53_pmu_init).
>
> In armv8_a53_pmu_init we call armv8pmu_probe_num_events, which will try
> to SMP cross-call to an A53 core to probe the number of countesr
> implemented. Perhaps the cross-call is failing.
>
> Were the A53s online at this point?
Ah, indeed, the A53s failed to run.
Maybe anything like
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/398773.html
helps to make this more obvious, then?
Thanks!
Best regards
Dirk
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH 06/10] arm64: renesas: salvator-x: Add board part number to DT bindings
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 2:29 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
Documentation/devicetree/bindings/arm/shmobile.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index 678a8184da24..9cf67e48f222 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -59,7 +59,7 @@ Boards:
compatible = "renesas,marzen", "renesas,r8a7779"
- Porter (M2-LCDP)
compatible = "renesas,porter", "renesas,r8a7791"
- - Salvator-X
+ - Salvator-X (RTP0RC7795SIPB0010S)
compatible = "renesas,salvator-x", "renesas,r8a7795";
- SILK (RTP0RC7794LCB00011S)
compatible = "renesas,silk", "renesas,r8a7794"
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 06/10] arm64: renesas: salvator-x: Add board part number to DT bindings
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
Documentation/devicetree/bindings/arm/shmobile.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index 678a8184da24..9cf67e48f222 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -59,7 +59,7 @@ Boards:
compatible = "renesas,marzen", "renesas,r8a7779"
- Porter (M2-LCDP)
compatible = "renesas,porter", "renesas,r8a7791"
- - Salvator-X
+ - Salvator-X (RTP0RC7795SIPB0010S)
compatible = "renesas,salvator-x", "renesas,r8a7795";
- SILK (RTP0RC7794LCB00011S)
compatible = "renesas,silk", "renesas,r8a7794"
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 07/10] arm64: renesas: r8a7795: add internal delay for i2c IPs
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 2:29 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index b9229a49dabc..e14251164480 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -526,6 +526,7 @@
interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 931>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <110>;
status = "disabled";
};
@@ -537,6 +538,7 @@
interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 930>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <6>;
status = "disabled";
};
@@ -548,6 +550,7 @@
interrupts = <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 929>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <6>;
status = "disabled";
};
@@ -559,6 +562,7 @@
interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 928>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <110>;
status = "disabled";
};
@@ -570,6 +574,7 @@
interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 927>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <110>;
status = "disabled";
};
@@ -581,6 +586,7 @@
interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 919>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <110>;
status = "disabled";
};
@@ -592,6 +598,7 @@
interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 918>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <6>;
status = "disabled";
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 07/10] arm64: renesas: r8a7795: add internal delay for i2c IPs
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index b9229a49dabc..e14251164480 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -526,6 +526,7 @@
interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 931>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <110>;
status = "disabled";
};
@@ -537,6 +538,7 @@
interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 930>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <6>;
status = "disabled";
};
@@ -548,6 +550,7 @@
interrupts = <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 929>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <6>;
status = "disabled";
};
@@ -559,6 +562,7 @@
interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 928>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <110>;
status = "disabled";
};
@@ -570,6 +574,7 @@
interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 927>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <110>;
status = "disabled";
};
@@ -581,6 +586,7 @@
interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 919>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <110>;
status = "disabled";
};
@@ -592,6 +598,7 @@
interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 918>;
power-domains = <&cpg>;
+ i2c-scl-internal-delay-ns = <6>;
status = "disabled";
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 08/10] arm64: dts: r8a7795: Add SATA controller node
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 2:29 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Kouei Abe <kouei.abe.cp@renesas.com>
This adds SATA device node to r8a7795.dtsi.
Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
[uli: adjusted for new MSTP clock scheme]
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index e14251164480..9ce6a5ea6629 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -767,5 +767,13 @@
};
};
};
+
+ sata: sata@ee300000 {
+ compatible = "renesas,sata-r8a7795";
+ reg = <0 0xee300000 0 0x1fff>;
+ interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 915>;
+ status = "disabled";
+ };
};
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 08/10] arm64: dts: r8a7795: Add SATA controller node
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Kouei Abe <kouei.abe.cp@renesas.com>
This adds SATA device node to r8a7795.dtsi.
Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
[uli: adjusted for new MSTP clock scheme]
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index e14251164480..9ce6a5ea6629 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -767,5 +767,13 @@
};
};
};
+
+ sata: sata at ee300000 {
+ compatible = "renesas,sata-r8a7795";
+ reg = <0 0xee300000 0 0x1fff>;
+ interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 915>;
+ status = "disabled";
+ };
};
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 09/10] arm64: dts: salvator-x: Enable SATA controller
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 2:29 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Kouei Abe <kouei.abe.cp@renesas.com>
This enables SATA device in r8a7795-salvator-x.dts.
Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index 75af5ec5a4d4..265d12ff6022 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -212,6 +212,10 @@
};
};
+&sata {
+ status = "okay";
+};
+
&ssi1 {
shared-pin;
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread* [PATCH 09/10] arm64: dts: salvator-x: Enable SATA controller
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Kouei Abe <kouei.abe.cp@renesas.com>
This enables SATA device in r8a7795-salvator-x.dts.
Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index 75af5ec5a4d4..265d12ff6022 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -212,6 +212,10 @@
};
};
+&sata {
+ status = "okay";
+};
+
&ssi1 {
shared-pin;
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 10/10] arm64: renesas: r8a7795: fix SATA clock assignment
2015-12-18 2:29 ` Simon Horman
@ 2015-12-18 2:29 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
SATA clock is 815, not 915.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 9ce6a5ea6629..bb353cde1253 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -772,7 +772,7 @@
compatible = "renesas,sata-r8a7795";
reg = <0 0xee300000 0 0x1fff>;
interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&cpg CPG_MOD 915>;
+ clocks = <&cpg CPG_MOD 815>;
status = "disabled";
};
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* [PATCH 10/10] arm64: renesas: r8a7795: fix SATA clock assignment
@ 2015-12-18 2:29 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-18 2:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
SATA clock is 815, not 915.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 9ce6a5ea6629..bb353cde1253 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -772,7 +772,7 @@
compatible = "renesas,sata-r8a7795";
reg = <0 0xee300000 0 0x1fff>;
interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&cpg CPG_MOD 915>;
+ clocks = <&cpg CPG_MOD 815>;
status = "disabled";
};
};
--
2.1.4
^ permalink raw reply related [flat|nested] 49+ messages in thread
* Re: [GIT PULL] Third Round of Renesas ARM64 Based SoC DT Updates for v4.5
2015-12-18 2:29 ` Simon Horman
@ 2015-12-22 20:52 ` Olof Johansson
-1 siblings, 0 replies; 49+ messages in thread
From: Olof Johansson @ 2015-12-22 20:52 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 18, 2015 at 11:29:14AM +0900, Simon Horman wrote:
> Hi Olof, Hi Kevin, Hi Arnd,
>
> Please consider these third round of Renesas ARM64 based SoC DT updates
> for v4.5.
>
> This pull request is based on the previous round of
> such requests, tagged as renesas-arm64-dt2-for-v4.5,
> which you have already pulled.
>
>
> The following changes since commit 672b79312c04016481a11d4b996b4512207ffbd3:
>
> arm64: renesas: salvator-x: Sound DVC support (2015-11-26 11:31:43 +0900)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm64-dt3-for-v4.5
Merged, but:
> arm64: dts: r8a7795: Add PSCI node
> arm64: dts: r8a7795: Add Cortex-A57 CPU cores
> arm64: renesas: salvator-x: Add board part number to DT bindings
> arm64: dts: r8a7795: Add SATA controller node
> arm64: dts: salvator-x: Enable SATA controller
> arm64: renesas: salvator-x: set ak4613 In/Out pin as single-end
> arm64: renesas: salvator-x: use CS2000 as AUDIO_CLK_B
> arm64: renesas: r8a7795: fix SATA clock assignment
> arm64: renesas: r8a7795: add internal delay for i2c IPs
> arm64: dts: r8a7795: Add pmu device nodes
Please me more consistent in patch description prefixes.
-Olof
^ permalink raw reply [flat|nested] 49+ messages in thread
* [GIT PULL] Third Round of Renesas ARM64 Based SoC DT Updates for v4.5
@ 2015-12-22 20:52 ` Olof Johansson
0 siblings, 0 replies; 49+ messages in thread
From: Olof Johansson @ 2015-12-22 20:52 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 18, 2015 at 11:29:14AM +0900, Simon Horman wrote:
> Hi Olof, Hi Kevin, Hi Arnd,
>
> Please consider these third round of Renesas ARM64 based SoC DT updates
> for v4.5.
>
> This pull request is based on the previous round of
> such requests, tagged as renesas-arm64-dt2-for-v4.5,
> which you have already pulled.
>
>
> The following changes since commit 672b79312c04016481a11d4b996b4512207ffbd3:
>
> arm64: renesas: salvator-x: Sound DVC support (2015-11-26 11:31:43 +0900)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm64-dt3-for-v4.5
Merged, but:
> arm64: dts: r8a7795: Add PSCI node
> arm64: dts: r8a7795: Add Cortex-A57 CPU cores
> arm64: renesas: salvator-x: Add board part number to DT bindings
> arm64: dts: r8a7795: Add SATA controller node
> arm64: dts: salvator-x: Enable SATA controller
> arm64: renesas: salvator-x: set ak4613 In/Out pin as single-end
> arm64: renesas: salvator-x: use CS2000 as AUDIO_CLK_B
> arm64: renesas: r8a7795: fix SATA clock assignment
> arm64: renesas: r8a7795: add internal delay for i2c IPs
> arm64: dts: r8a7795: Add pmu device nodes
Please me more consistent in patch description prefixes.
-Olof
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [GIT PULL] Third Round of Renesas ARM64 Based SoC DT Updates for v4.5
2015-12-22 20:52 ` Olof Johansson
@ 2015-12-28 4:55 ` Simon Horman
-1 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-28 4:55 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 22, 2015 at 12:52:08PM -0800, Olof Johansson wrote:
> On Fri, Dec 18, 2015 at 11:29:14AM +0900, Simon Horman wrote:
> > Hi Olof, Hi Kevin, Hi Arnd,
> >
> > Please consider these third round of Renesas ARM64 based SoC DT updates
> > for v4.5.
> >
> > This pull request is based on the previous round of
> > such requests, tagged as renesas-arm64-dt2-for-v4.5,
> > which you have already pulled.
> >
> >
> > The following changes since commit 672b79312c04016481a11d4b996b4512207ffbd3:
> >
> > arm64: renesas: salvator-x: Sound DVC support (2015-11-26 11:31:43 +0900)
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm64-dt3-for-v4.5
>
> Merged, but:
>
> > arm64: dts: r8a7795: Add PSCI node
> > arm64: dts: r8a7795: Add Cortex-A57 CPU cores
> > arm64: renesas: salvator-x: Add board part number to DT bindings
> > arm64: dts: r8a7795: Add SATA controller node
> > arm64: dts: salvator-x: Enable SATA controller
> > arm64: renesas: salvator-x: set ak4613 In/Out pin as single-end
> > arm64: renesas: salvator-x: use CS2000 as AUDIO_CLK_B
> > arm64: renesas: r8a7795: fix SATA clock assignment
> > arm64: renesas: r8a7795: add internal delay for i2c IPs
> > arm64: dts: r8a7795: Add pmu device nodes
>
> Please me more consistent in patch description prefixes.
Sure, sorry for not being more attentive to that.
^ permalink raw reply [flat|nested] 49+ messages in thread
* [GIT PULL] Third Round of Renesas ARM64 Based SoC DT Updates for v4.5
@ 2015-12-28 4:55 ` Simon Horman
0 siblings, 0 replies; 49+ messages in thread
From: Simon Horman @ 2015-12-28 4:55 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 22, 2015 at 12:52:08PM -0800, Olof Johansson wrote:
> On Fri, Dec 18, 2015 at 11:29:14AM +0900, Simon Horman wrote:
> > Hi Olof, Hi Kevin, Hi Arnd,
> >
> > Please consider these third round of Renesas ARM64 based SoC DT updates
> > for v4.5.
> >
> > This pull request is based on the previous round of
> > such requests, tagged as renesas-arm64-dt2-for-v4.5,
> > which you have already pulled.
> >
> >
> > The following changes since commit 672b79312c04016481a11d4b996b4512207ffbd3:
> >
> > arm64: renesas: salvator-x: Sound DVC support (2015-11-26 11:31:43 +0900)
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm64-dt3-for-v4.5
>
> Merged, but:
>
> > arm64: dts: r8a7795: Add PSCI node
> > arm64: dts: r8a7795: Add Cortex-A57 CPU cores
> > arm64: renesas: salvator-x: Add board part number to DT bindings
> > arm64: dts: r8a7795: Add SATA controller node
> > arm64: dts: salvator-x: Enable SATA controller
> > arm64: renesas: salvator-x: set ak4613 In/Out pin as single-end
> > arm64: renesas: salvator-x: use CS2000 as AUDIO_CLK_B
> > arm64: renesas: r8a7795: fix SATA clock assignment
> > arm64: renesas: r8a7795: add internal delay for i2c IPs
> > arm64: dts: r8a7795: Add pmu device nodes
>
> Please me more consistent in patch description prefixes.
Sure, sorry for not being more attentive to that.
^ permalink raw reply [flat|nested] 49+ messages in thread