All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH stable 5.10 3/3] ARM: 9079/1: ftrace: Add MODULE_PLTS support
Date: Wed, 22 Sep 2021 08:53:12 +0200	[thread overview]
Message-ID: <d374a9ae-2dd0-3b11-d5f8-211ef3a6f991@nokia.com> (raw)
In-Reply-To: <20210922023947.59636-4-f.fainelli@gmail.com>

Hello Florian,

On 22/09/2021 04:39, Florian Fainelli wrote:
> From: Alex Sverdlin <alexander.sverdlin@nokia.com>
> 
> commit 79f32b221b18c15a98507b101ef4beb52444cc6f upstream
> 
> Teach ftrace_make_call() and ftrace_make_nop() about PLTs.
> Teach PLT code about FTRACE and all its callbacks.

sorry for inconvenience, but I'd propose to add 6fa630bf473827ae
"ARM: 9098/1: ftrace: MODULE_PLT: Fix build problem without DYNAMIC_FTRACE"
to all series on this topic, because of the below chunk which might
lead to build issues on some exotic configurations.

Link: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/ZUVCQBHDMFVR7CCB7JPESLJEWERZDJ3T/

> --- a/arch/arm/kernel/module-plts.c
> +++ b/arch/arm/kernel/module-plts.c
> @@ -20,19 +21,52 @@
>  						    (PLT_ENT_STRIDE - 8))
>  #endif
>  
> +static const u32 fixed_plts[] = {
> +#ifdef CONFIG_FUNCTION_TRACER
> +	FTRACE_ADDR,
> +	MCOUNT_ADDR,
> +#endif
> +};
> +
>  static bool in_init(const struct module *mod, unsigned long loc)
>  {
>  	return loc - (u32)mod->init_layout.base < mod->init_layout.size;

-- 
Best regards,
Alexander Sverdlin.

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH stable 5.10 3/3] ARM: 9079/1: ftrace: Add MODULE_PLTS support
Date: Wed, 22 Sep 2021 08:53:12 +0200	[thread overview]
Message-ID: <d374a9ae-2dd0-3b11-d5f8-211ef3a6f991@nokia.com> (raw)
In-Reply-To: <20210922023947.59636-4-f.fainelli@gmail.com>

Hello Florian,

On 22/09/2021 04:39, Florian Fainelli wrote:
> From: Alex Sverdlin <alexander.sverdlin@nokia.com>
> 
> commit 79f32b221b18c15a98507b101ef4beb52444cc6f upstream
> 
> Teach ftrace_make_call() and ftrace_make_nop() about PLTs.
> Teach PLT code about FTRACE and all its callbacks.

sorry for inconvenience, but I'd propose to add 6fa630bf473827ae
"ARM: 9098/1: ftrace: MODULE_PLT: Fix build problem without DYNAMIC_FTRACE"
to all series on this topic, because of the below chunk which might
lead to build issues on some exotic configurations.

Link: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/ZUVCQBHDMFVR7CCB7JPESLJEWERZDJ3T/

> --- a/arch/arm/kernel/module-plts.c
> +++ b/arch/arm/kernel/module-plts.c
> @@ -20,19 +21,52 @@
>  						    (PLT_ENT_STRIDE - 8))
>  #endif
>  
> +static const u32 fixed_plts[] = {
> +#ifdef CONFIG_FUNCTION_TRACER
> +	FTRACE_ADDR,
> +	MCOUNT_ADDR,
> +#endif
> +};
> +
>  static bool in_init(const struct module *mod, unsigned long loc)
>  {
>  	return loc - (u32)mod->init_layout.base < mod->init_layout.size;

-- 
Best regards,
Alexander Sverdlin.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-22  6:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  2:39 [PATCH stable 5.10 0/3] ARM: ftrace MODULE_PLTS warning fixes Florian Fainelli
2021-09-22  2:39 ` Florian Fainelli
2021-09-22  2:39 ` [PATCH stable 5.10 1/3] ARM: 9077/1: PLT: Move struct plt_entries definition to header Florian Fainelli
2021-09-22  2:39   ` Florian Fainelli
2021-09-22  2:39 ` [PATCH stable 5.10 2/3] ARM: 9078/1: Add warn suppress parameter to arm_gen_branch_link() Florian Fainelli
2021-09-22  2:39   ` Florian Fainelli
2021-09-22  2:39 ` [PATCH stable 5.10 3/3] ARM: 9079/1: ftrace: Add MODULE_PLTS support Florian Fainelli
2021-09-22  2:39   ` Florian Fainelli
2021-09-22  6:53   ` Alexander Sverdlin [this message]
2021-09-22  6:53     ` Alexander Sverdlin
2021-09-22 16:12     ` Florian Fainelli
2021-09-22 16:12       ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d374a9ae-2dd0-3b11-d5f8-211ef3a6f991@nokia.com \
    --to=alexander.sverdlin@nokia.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mingo@redhat.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=rostedt@goodmis.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.