[PATCH] drm/i915/selftests: Drop stale struct_mutex

[PATCH] drm/i915/selftests: Drop stale struct_mutex

[Chris Wilson]

A lately added test was missed when applying the struct_mutex removal
patches. Do so now.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/selftest_lrc.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index 1276da059dc6..9c1f34fb5882 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -107,7 +107,6 @@ static int live_unlite_restore(struct drm_i915_private *i915, int prio)
 	struct intel_engine_cs *engine;
 	struct i915_gem_context *ctx;
 	enum intel_engine_id id;
-	intel_wakeref_t wakeref;
 	struct igt_spinner spin;
 	int err = -ENOMEM;
 
@@ -116,11 +115,8 @@ static int live_unlite_restore(struct drm_i915_private *i915, int prio)
 	 * on the same engine from the same parent context.
 	 */
 
-	mutex_lock(&i915->drm.struct_mutex);
-	wakeref = intel_runtime_pm_get(&i915->runtime_pm);
-
 	if (igt_spinner_init(&spin, &i915->gt))
-		goto err_unlock;
+		return err;
 
 	ctx = kernel_context(i915);
 	if (!ctx)
@@ -264,9 +260,6 @@ static int live_unlite_restore(struct drm_i915_private *i915, int prio)
 	kernel_context_close(ctx);
 err_spin:
 	igt_spinner_fini(&spin);
-err_unlock:
-	intel_runtime_pm_put(&i915->runtime_pm, wakeref);
-	mutex_unlock(&i915->drm.struct_mutex);
 	return err;
 }
 
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/selftests: Drop stale struct_mutex

[Patchwork]

== Series Details ==

Series: drm/i915/selftests: Drop stale struct_mutex
URL   : https://patchwork.freedesktop.org/series/68011/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7093 -> Patchwork_14806
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/index.html

Known issues
------------

  Here are the changes found in Patchwork_14806 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_hangcheck:
    - fi-icl-u3:          [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108569])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/fi-icl-u3/igt@i915_selftest@live_hangcheck.html

  * igt@kms_addfb_basic@addfb25-x-tiled-mismatch:
    - fi-icl-u3:          [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/fi-icl-u3/igt@kms_addfb_basic@addfb25-x-tiled-mismatch.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/fi-icl-u3/igt@kms_addfb_basic@addfb25-x-tiled-mismatch.html

  
#### Possible fixes ####

  * igt@gem_ctx_create@basic-files:
    - {fi-icl-dsi}:       [INCOMPLETE][5] ([fdo#107713] / [fdo#109100]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/fi-icl-dsi/igt@gem_ctx_create@basic-files.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/fi-icl-dsi/igt@gem_ctx_create@basic-files.html

  * igt@kms_addfb_basic@framebuffer-vs-set-tiling:
    - fi-icl-u3:          [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/fi-icl-u3/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/fi-icl-u3/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html

  * igt@kms_chamelium@hdmi-crc-fast:
    - {fi-icl-u4}:        [FAIL][9] ([fdo#111045]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/fi-icl-u4/igt@kms_chamelium@hdmi-crc-fast.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/fi-icl-u4/igt@kms_chamelium@hdmi-crc-fast.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-blb-e6850:       [INCOMPLETE][11] ([fdo#107718]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
  [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736


Participating hosts (52 -> 44)
------------------------------

  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-icl-u2 fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7093 -> Patchwork_14806

  CI-20190529: 20190529
  CI_DRM_7093: 36b099821371a722f10d020cc5e86696a60f2651 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5225: 991ce4eede1c52f76378aebf162a13c20d6f6293 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_14806: 005b5380574cf5cedb51a15fbdea0aaed6bdcb68 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

005b5380574c drm/i915/selftests: Drop stale struct_mutex

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: failure for drm/i915/selftests: Drop stale struct_mutex

[Patchwork]

== Series Details ==

Series: drm/i915/selftests: Drop stale struct_mutex
URL   : https://patchwork.freedesktop.org/series/68011/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7093_full -> Patchwork_14806_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_14806_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_14806_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_14806_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_eio@in-flight-contexts-10ms:
    - shard-snb:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-snb7/igt@gem_eio@in-flight-contexts-10ms.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-snb1/igt@gem_eio@in-flight-contexts-10ms.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@kms_busy@extended-pageflip-hang-oldfb-render-f:
    - {shard-tglb}:       NOTRUN -> [SKIP][3] +11 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-tglb1/igt@kms_busy@extended-pageflip-hang-oldfb-render-f.html

  
Known issues
------------

  Here are the changes found in Patchwork_14806_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@rcs0-nonpriv:
    - shard-apl:          [PASS][4] -> [INCOMPLETE][5] ([fdo#103927])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-apl3/igt@gem_ctx_isolation@rcs0-nonpriv.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-apl2/igt@gem_ctx_isolation@rcs0-nonpriv.html

  * igt@gem_ctx_shared@exec-single-timeline-bsd:
    - shard-iclb:         [PASS][6] -> [SKIP][7] ([fdo#110841])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb6/igt@gem_ctx_shared@exec-single-timeline-bsd.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html

  * igt@gem_exec_schedule@preemptive-hang-bsd:
    - shard-iclb:         [PASS][8] -> [SKIP][9] ([fdo#111325]) +8 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html

  * igt@gem_wait@write-wait-bcs0:
    - shard-skl:          [PASS][10] -> [DMESG-WARN][11] ([fdo#106107])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-skl10/igt@gem_wait@write-wait-bcs0.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-skl2/igt@gem_wait@write-wait-bcs0.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-skl:          [PASS][12] -> [INCOMPLETE][13] ([fdo#104108])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-skl3/igt@gem_workarounds@suspend-resume-context.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-skl7/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [PASS][14] -> [DMESG-WARN][15] ([fdo#108566]) +5 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_cursor_legacy@cursor-vs-flip-atomic:
    - shard-hsw:          [PASS][16] -> [FAIL][17] ([fdo#103355])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-glk:          [PASS][18] -> [FAIL][19] ([fdo#102887])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [PASS][20] -> [FAIL][21] ([fdo#103167]) +4 similar issues
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [PASS][22] -> [FAIL][23] ([fdo#108145] / [fdo#110403])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [PASS][24] -> [FAIL][25] ([fdo#103166])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@psr2_no_drrs:
    - shard-iclb:         [PASS][26] -> [SKIP][27] ([fdo#109441]) +3 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb6/igt@kms_psr@psr2_no_drrs.html

  * igt@prime_busy@hang-bsd2:
    - shard-iclb:         [PASS][28] -> [SKIP][29] ([fdo#109276]) +27 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb2/igt@prime_busy@hang-bsd2.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb6/igt@prime_busy@hang-bsd2.html

  
#### Possible fixes ####

  * igt@gem_exec_schedule@preempt-queue-bsd:
    - shard-iclb:         [SKIP][30] ([fdo#111325]) -> [PASS][31] +4 similar issues
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd.html

  * igt@gem_exec_schedule@preempt-queue-bsd2:
    - shard-iclb:         [SKIP][32] ([fdo#109276]) -> [PASS][33] +22 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd2.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd2.html

  * igt@gem_softpin@noreloc-s3:
    - shard-kbl:          [DMESG-WARN][34] ([fdo#103313]) -> [PASS][35] +1 similar issue
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-kbl2/igt@gem_softpin@noreloc-s3.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-kbl1/igt@gem_softpin@noreloc-s3.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-glk:          [INCOMPLETE][36] ([fdo#103359] / [fdo#108686] / [k.org#198133]) -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-glk9/igt@gem_tiled_swapping@non-threaded.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-glk6/igt@gem_tiled_swapping@non-threaded.html

  * igt@gem_userptr_blits@dmabuf-unsync:
    - shard-snb:          [DMESG-WARN][38] ([fdo#111870]) -> [PASS][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-snb4/igt@gem_userptr_blits@dmabuf-unsync.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-snb5/igt@gem_userptr_blits@dmabuf-unsync.html

  * igt@i915_pm_rpm@gem-mmap-gtt:
    - shard-iclb:         [INCOMPLETE][40] ([fdo#107713] / [fdo#108840]) -> [PASS][41]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb7/igt@i915_pm_rpm@gem-mmap-gtt.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb3/igt@i915_pm_rpm@gem-mmap-gtt.html

  * igt@i915_pm_rpm@system-suspend:
    - shard-skl:          [INCOMPLETE][42] ([fdo#104108] / [fdo#107807]) -> [PASS][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-skl8/igt@i915_pm_rpm@system-suspend.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-skl4/igt@i915_pm_rpm@system-suspend.html

  * igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
    - shard-hsw:          [DMESG-WARN][44] ([fdo#102614]) -> [PASS][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-hsw5/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-hsw7/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-apl:          [DMESG-WARN][46] ([fdo#108566]) -> [PASS][47] +3 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          [FAIL][48] ([fdo#105363]) -> [PASS][49] +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-skl10/igt@kms_flip@flip-vs-expired-vblank.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
    - {shard-tglb}:       [FAIL][50] ([fdo#103167]) -> [PASS][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
    - shard-iclb:         [FAIL][52] ([fdo#103167]) -> [PASS][53] +6 similar issues
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [FAIL][54] ([fdo#108145] / [fdo#110403]) -> [PASS][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [SKIP][56] ([fdo#109441]) -> [PASS][57] +2 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_setmode@basic:
    - shard-hsw:          [FAIL][58] ([fdo#99912]) -> [PASS][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-hsw8/igt@kms_setmode@basic.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-hsw6/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
    - shard-skl:          [INCOMPLETE][60] ([fdo#104108]) -> [PASS][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-skl5/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-skl2/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html

  * igt@perf@oa-exponents:
    - shard-glk:          [FAIL][62] ([fdo#105483]) -> [PASS][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-glk8/igt@perf@oa-exponents.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-glk3/igt@perf@oa-exponents.html

  
#### Warnings ####

  * igt@gem_mocs_settings@mocs-reset-bsd2:
    - shard-iclb:         [FAIL][64] ([fdo#111330]) -> [SKIP][65] ([fdo#109276]) +2 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb2/igt@gem_mocs_settings@mocs-reset-bsd2.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb5/igt@gem_mocs_settings@mocs-reset-bsd2.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-apl:          [DMESG-WARN][66] ([fdo#108566]) -> [INCOMPLETE][67] ([fdo#103927])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-apl6/igt@kms_flip@flip-vs-suspend.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-apl6/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_psr@psr2_suspend:
    - shard-iclb:         [SKIP][68] ([fdo#109441]) -> [DMESG-WARN][69] ([fdo#107724])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7093/shard-iclb5/igt@kms_psr@psr2_suspend.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/shard-iclb2/igt@kms_psr@psr2_suspend.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105483]: https://bugs.freedesktop.org/show_bug.cgi?id=105483
  [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
  [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
  [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
  [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
  [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
  [fdo#111757]: https://bugs.freedesktop.org/show_bug.cgi?id=111757
  [fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795 
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (11 -> 11)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7093 -> Patchwork_14806

  CI-20190529: 20190529
  CI_DRM_7093: 36b099821371a722f10d020cc5e86696a60f2651 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5225: 991ce4eede1c52f76378aebf162a13c20d6f6293 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_14806: 005b5380574cf5cedb51a15fbdea0aaed6bdcb68 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14806/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/selftests: Drop stale struct_mutex

[Tvrtko Ursulin]

On 15/10/2019 09:59, Chris Wilson wrote:
> A lately added test was missed when applying the struct_mutex removal
> patches. Do so now.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/gt/selftest_lrc.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> index 1276da059dc6..9c1f34fb5882 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> @@ -107,7 +107,6 @@ static int live_unlite_restore(struct drm_i915_private *i915, int prio)
>   	struct intel_engine_cs *engine;
>   	struct i915_gem_context *ctx;
>   	enum intel_engine_id id;
> -	intel_wakeref_t wakeref;
>   	struct igt_spinner spin;
>   	int err = -ENOMEM;
>   
> @@ -116,11 +115,8 @@ static int live_unlite_restore(struct drm_i915_private *i915, int prio)
>   	 * on the same engine from the same parent context.
>   	 */
>   
> -	mutex_lock(&i915->drm.struct_mutex);
> -	wakeref = intel_runtime_pm_get(&i915->runtime_pm);
> -
>   	if (igt_spinner_init(&spin, &i915->gt))
> -		goto err_unlock;
> +		return err;
>   
>   	ctx = kernel_context(i915);
>   	if (!ctx)
> @@ -264,9 +260,6 @@ static int live_unlite_restore(struct drm_i915_private *i915, int prio)
>   	kernel_context_close(ctx);
>   err_spin:
>   	igt_spinner_fini(&spin);
> -err_unlock:
> -	intel_runtime_pm_put(&i915->runtime_pm, wakeref);
> -	mutex_unlock(&i915->drm.struct_mutex);
>   	return err;
>   }
>   
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx