All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Adam Ford <aford173@gmail.com>, Tim Harvey <tharvey@gateworks.com>
Cc: Fabio Estevam <festevam@gmail.com>,
	sbabic@denx.de, u-boot@lists.denx.de,
	 Fabio Estevam <festevam@denx.de>, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 3/3] arm: dts: imx8mp: Sync with Linux 6.3
Date: Mon, 22 May 2023 08:49:00 +0200	[thread overview]
Message-ID: <d3abcd57-f10c-885e-9f5d-8ae163a6df9f@prevas.dk> (raw)
In-Reply-To: <CAHCN7xJ05MWHBcu8HSLKNjsraYTeg1owpQb+p9q+XVsSe2mEDw@mail.gmail.com>

On 20/05/2023 00.26, Adam Ford wrote:
> On Fri, May 19, 2023 at 5:19 PM Tim Harvey <tharvey@gateworks.com> wrote:
>>
>> On Wed, May 3, 2023 at 9:11 AM Tim Harvey <tharvey@gateworks.com> wrote:
>>>
>> Fabio,
>>
>> Apparently I didn't do a very good job of testing this. This patch is
>> causing imx8mp-venice-* and imx8mp-evk boards to no longer boot with
>> no SPL banner. The specific change that causes breakage is the one
>> that encapsulates the spi/uart/flexcan children with
>> spba-bus@30800000.
> 
> The SPI, UART, and Flexcan are part of the spba-bus.
> 
> We'll need to add the spba bus to imx8mp-u-boot.dtsi. Since it had no
> node name, it'll have to fall under aip3.
> 
> Try this:
> 
> diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi b/arch/arm/dts/imx8mp-u-boot.dtsi
> index 18d1728e1d..0e6811b129 100644
> --- a/arch/arm/dts/imx8mp-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mp-u-boot.dtsi
> @@ -44,6 +44,10 @@
> 
>  &aips3 {
>         bootph-pre-ram;
> +
> +       spba-bus@30800000 {
> +               bootph-pre-ram;
> +       };
>  };
> 
>  &iomuxc {

This begs the question: Why don't these tags just implicitly propagate
to parent nodes? It's a U-Boot specific tool (fdtgrep) that makes use of
them, no? So making the rule be "keep this node if it _or any
descendant_ has that tag" should be possible.

This has probably been answered somewhere before.

Rasmus


  parent reply	other threads:[~2023-05-22  6:49 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 18:08 [PATCH 1/3] arm: dts: imx8mm: Sync with Linux 6.3 Fabio Estevam
2023-04-27 18:08 ` [PATCH 2/3] arm: dts: imx8mn: " Fabio Estevam
2023-04-27 19:21   ` Adam Ford
2023-05-03 16:12   ` Tim Harvey
2023-07-14  0:42     ` Tim Harvey
2023-04-27 18:08 ` [PATCH 3/3] arm: dts: imx8mp: " Fabio Estevam
2023-04-27 19:22   ` Adam Ford
2023-05-03 16:11   ` Tim Harvey
2023-05-19 22:19     ` Tim Harvey
2023-05-19 22:26       ` Adam Ford
2023-05-19 22:31         ` Tim Harvey
2023-05-19 22:33           ` Tim Harvey
2023-05-19 22:35             ` Adam Ford
2023-05-19 23:00               ` Tim Harvey
2023-05-22 20:48                 ` Fabio Estevam
2023-05-22 20:52                   ` Adam Ford
2023-05-25  2:02                 ` Fabio Estevam
2023-05-29 17:45                   ` Adam Ford
2023-05-30 17:23                     ` Tim Harvey
2023-05-30 17:28                       ` Adam Ford
2023-05-30 18:40                         ` Tim Harvey
2023-05-30 22:34                           ` Adam Ford
2023-05-30 23:13                             ` Fabio Estevam
2023-05-22  6:49         ` Rasmus Villemoes [this message]
2023-04-27 18:56 ` [PATCH 1/3] arm: dts: imx8mm: " Tim Harvey
2023-04-27 19:11   ` Fabio Estevam
2023-04-27 19:14     ` Tim Harvey
2023-04-27 19:19       ` Tim Harvey
2023-04-27 19:26         ` Fabio Estevam
2023-04-27 19:44           ` Tim Harvey
2023-04-27 19:49             ` Fabio Estevam
2023-04-27 22:25               ` Tim Harvey
2023-04-28 11:57                 ` Adam Ford
2023-04-28 15:27                   ` Tim Harvey
2023-04-28 15:32                     ` Adam Ford
2023-04-28 15:48                       ` Tim Harvey
2023-04-28 16:26                         ` Fabio Estevam
2023-04-28 16:44                           ` Adam Ford
2023-04-28 17:59                             ` Tim Harvey
2023-04-28 18:19                               ` Fabio Estevam
2023-05-03 16:11                                 ` Tim Harvey
2023-07-14  0:42                                   ` Tim Harvey
2023-07-14  5:17                                     ` Stefano Babic
2023-10-17 19:21                                       ` Tim Harvey
2023-10-17 20:28                                         ` Stefano Babic
2023-10-18  8:04                                           ` Stefano Babic
2023-04-27 19:23 ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3abcd57-f10c-885e-9f5d-8ae163a6df9f@prevas.dk \
    --to=rasmus.villemoes@prevas.dk \
    --cc=aford173@gmail.com \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=sbabic@denx.de \
    --cc=sjg@chromium.org \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.