* [PATCH] serial: Fix SIFIVE debug serial dependency
@ 2020-07-09 14:17 Michal Simek
2020-07-10 0:35 ` Simon Glass
0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2020-07-09 14:17 UTC (permalink / raw)
To: u-boot
The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for
debug consoles") has added incorrect dependency for SIFIVE debug uart which
should depend on SIFIVE driver instead of PL01x.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/serial/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 17d0e7362379..006cb5a50140 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX
config DEBUG_UART_SIFIVE
bool "SiFive UART"
- depends on PL01X_SERIAL
+ depends on SIFIVE_SERIAL
help
Select this to enable a debug UART using the serial_sifive driver. You
will need to provide parameters to make this work. The driver will
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] serial: Fix SIFIVE debug serial dependency
2020-07-09 14:17 [PATCH] serial: Fix SIFIVE debug serial dependency Michal Simek
@ 2020-07-10 0:35 ` Simon Glass
2020-07-10 6:21 ` Michal Simek
0 siblings, 1 reply; 6+ messages in thread
From: Simon Glass @ 2020-07-10 0:35 UTC (permalink / raw)
To: u-boot
Hi Michal,
On Thu, 9 Jul 2020 at 08:17, Michal Simek <michal.simek@xilinx.com> wrote:
>
> The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for
> debug consoles") has added incorrect dependency for SIFIVE debug uart which
> should depend on SIFIVE driver instead of PL01x.
Does that mean this should have a Fixes: tag?
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Regards,
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] serial: Fix SIFIVE debug serial dependency
2020-07-10 0:35 ` Simon Glass
@ 2020-07-10 6:21 ` Michal Simek
2020-07-15 1:05 ` Simon Glass
0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2020-07-10 6:21 UTC (permalink / raw)
To: u-boot
Hi Simon,
On 10. 07. 20 2:35, Simon Glass wrote:
> Hi Michal,
>
> On Thu, 9 Jul 2020 at 08:17, Michal Simek <michal.simek@xilinx.com> wrote:
>>
>> The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for
>> debug consoles") has added incorrect dependency for SIFIVE debug uart which
>> should depend on SIFIVE driver instead of PL01x.
>
> Does that mean this should have a Fixes: tag?
TBH I had it there but removed it because commit is pointing to it
anyway. And also I am not aware about any stable process in place.
Or is there any process around that people are looking for fixed tags
and picking them to any u-boot stable tree?
Thanks,
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] serial: Fix SIFIVE debug serial dependency
2020-07-10 6:21 ` Michal Simek
@ 2020-07-15 1:05 ` Simon Glass
2020-07-15 1:10 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Simon Glass @ 2020-07-15 1:05 UTC (permalink / raw)
To: u-boot
On Fri, 10 Jul 2020 at 00:21, Michal Simek <michal.simek@xilinx.com> wrote:
>
> Hi Simon,
>
> On 10. 07. 20 2:35, Simon Glass wrote:
> > Hi Michal,
> >
> > On Thu, 9 Jul 2020 at 08:17, Michal Simek <michal.simek@xilinx.com> wrote:
> >>
> >> The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for
> >> debug consoles") has added incorrect dependency for SIFIVE debug uart which
> >> should depend on SIFIVE driver instead of PL01x.
> >
> > Does that mean this should have a Fixes: tag?
>
> TBH I had it there but removed it because commit is pointing to it
> anyway. And also I am not aware about any stable process in place.
> Or is there any process around that people are looking for fixed tags
> and picking them to any u-boot stable tree?
>
+Tom Rini who may know
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] serial: Fix SIFIVE debug serial dependency
2020-07-15 1:05 ` Simon Glass
@ 2020-07-15 1:10 ` Tom Rini
2020-07-15 6:28 ` Michal Simek
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2020-07-15 1:10 UTC (permalink / raw)
To: u-boot
On Tue, Jul 14, 2020 at 07:05:54PM -0600, Simon Glass wrote:
> On Fri, 10 Jul 2020 at 00:21, Michal Simek <michal.simek@xilinx.com> wrote:
> >
> > Hi Simon,
> >
> > On 10. 07. 20 2:35, Simon Glass wrote:
> > > Hi Michal,
> > >
> > > On Thu, 9 Jul 2020 at 08:17, Michal Simek <michal.simek@xilinx.com> wrote:
> > >>
> > >> The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for
> > >> debug consoles") has added incorrect dependency for SIFIVE debug uart which
> > >> should depend on SIFIVE driver instead of PL01x.
> > >
> > > Does that mean this should have a Fixes: tag?
> >
> > TBH I had it there but removed it because commit is pointing to it
> > anyway. And also I am not aware about any stable process in place.
> > Or is there any process around that people are looking for fixed tags
> > and picking them to any u-boot stable tree?
>
> +Tom Rini who may know
We do fixes tags because it's good history.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200714/af6d9fbd/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] serial: Fix SIFIVE debug serial dependency
2020-07-15 1:10 ` Tom Rini
@ 2020-07-15 6:28 ` Michal Simek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2020-07-15 6:28 UTC (permalink / raw)
To: u-boot
On 15. 07. 20 3:10, Tom Rini wrote:
> On Tue, Jul 14, 2020 at 07:05:54PM -0600, Simon Glass wrote:
>> On Fri, 10 Jul 2020 at 00:21, Michal Simek <michal.simek@xilinx.com> wrote:
>>>
>>> Hi Simon,
>>>
>>> On 10. 07. 20 2:35, Simon Glass wrote:
>>>> Hi Michal,
>>>>
>>>> On Thu, 9 Jul 2020 at 08:17, Michal Simek <michal.simek@xilinx.com> wrote:
>>>>>
>>>>> The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for
>>>>> debug consoles") has added incorrect dependency for SIFIVE debug uart which
>>>>> should depend on SIFIVE driver instead of PL01x.
>>>>
>>>> Does that mean this should have a Fixes: tag?
>>>
>>> TBH I had it there but removed it because commit is pointing to it
>>> anyway. And also I am not aware about any stable process in place.
>>> Or is there any process around that people are looking for fixed tags
>>> and picking them to any u-boot stable tree?
>>
>> +Tom Rini who may know
>
> We do fixes tags because it's good history.
>
ok. Thx.
M
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-15 6:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 14:17 [PATCH] serial: Fix SIFIVE debug serial dependency Michal Simek
2020-07-10 0:35 ` Simon Glass
2020-07-10 6:21 ` Michal Simek
2020-07-15 1:05 ` Simon Glass
2020-07-15 1:10 ` Tom Rini
2020-07-15 6:28 ` Michal Simek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.