* Re: [Powertop] [PATCH] Make the wakeup toggle text clearer.
@ 2019-09-09 19:07 Auke Kok
0 siblings, 0 replies; 2+ messages in thread
From: Auke Kok @ 2019-09-09 19:07 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 2251 bytes --]
Ahh yes, +1, this has totally irked me and this is a good solution.
Auke
On 9/9/19 7:38 AM, Zane Zakraisek wrote:
> The text is currenly "Enable" or "Disable", which makes it seem like
> toggling is needed to get it in that state.
>
> Instead the text should be "Enabled" or "Disabled" which reflects the
> current state.
>
> Signed-off-by: Zane Zakraisek <zakraise(a)eng.utah.edu>
> ---
> src/wakeup/wakeup.cpp | 4 ++--
> src/wakeup/wakeup_ethernet.cpp | 2 +-
> src/wakeup/wakeup_usb.cpp | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/wakeup/wakeup.cpp b/src/wakeup/wakeup.cpp
> index 7ed074b..9d83a9a 100644
> --- a/src/wakeup/wakeup.cpp
> +++ b/src/wakeup/wakeup.cpp
> @@ -45,8 +45,8 @@ wakeup::wakeup(void)
> {
> score = 0;
> desc[0] = 0;
> - pt_strcpy(wakeup_enable, _("Enable"));
> - pt_strcpy(wakeup_disable, _("Disable"));
> + pt_strcpy(wakeup_enable, _("Enabled"));
> + pt_strcpy(wakeup_disable, _("Disabled"));
> pt_strcpy(wakeup_idle, _("Unknown"));
> }
>
> diff --git a/src/wakeup/wakeup_ethernet.cpp b/src/wakeup/wakeup_ethernet.cpp
> index 4df7be3..6ce1725 100644
> --- a/src/wakeup/wakeup_ethernet.cpp
> +++ b/src/wakeup/wakeup_ethernet.cpp
> @@ -44,7 +44,7 @@
> #include "../lib.h"
> #include "wakeup_ethernet.h"
>
> -ethernet_wakeup::ethernet_wakeup(const char *path, const char *iface) : wakeup("", 0.5, _("Enable"), _("Disable"))
> +ethernet_wakeup::ethernet_wakeup(const char *path, const char *iface) : wakeup("", 0.5, _("Enabled"), _("Disabled"))
> {
> memset(interf, 0, sizeof(interf));
> pt_strcpy(interf, iface);
> diff --git a/src/wakeup/wakeup_usb.cpp b/src/wakeup/wakeup_usb.cpp
> index 30dc3e6..e0e4567 100644
> --- a/src/wakeup/wakeup_usb.cpp
> +++ b/src/wakeup/wakeup_usb.cpp
> @@ -44,7 +44,7 @@
> #include "../lib.h"
> #include "wakeup_usb.h"
>
> -usb_wakeup::usb_wakeup(const char *path, const char *iface) : wakeup("", 0.5, _("Enable"), _("Disable"))
> +usb_wakeup::usb_wakeup(const char *path, const char *iface) : wakeup("", 0.5, _("Enabled"), _("Disabled"))
> {
> memset(interf, 0, sizeof(interf));
> pt_strcpy(interf, iface);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Powertop] [PATCH] Make the wakeup toggle text clearer.
@ 2019-09-09 14:38 Zane Zakraisek
0 siblings, 0 replies; 2+ messages in thread
From: Zane Zakraisek @ 2019-09-09 14:38 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]
The text is currenly "Enable" or "Disable", which makes it seem like
toggling is needed to get it in that state.
Instead the text should be "Enabled" or "Disabled" which reflects the
current state.
Signed-off-by: Zane Zakraisek <zakraise(a)eng.utah.edu>
---
src/wakeup/wakeup.cpp | 4 ++--
src/wakeup/wakeup_ethernet.cpp | 2 +-
src/wakeup/wakeup_usb.cpp | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/wakeup/wakeup.cpp b/src/wakeup/wakeup.cpp
index 7ed074b..9d83a9a 100644
--- a/src/wakeup/wakeup.cpp
+++ b/src/wakeup/wakeup.cpp
@@ -45,8 +45,8 @@ wakeup::wakeup(void)
{
score = 0;
desc[0] = 0;
- pt_strcpy(wakeup_enable, _("Enable"));
- pt_strcpy(wakeup_disable, _("Disable"));
+ pt_strcpy(wakeup_enable, _("Enabled"));
+ pt_strcpy(wakeup_disable, _("Disabled"));
pt_strcpy(wakeup_idle, _("Unknown"));
}
diff --git a/src/wakeup/wakeup_ethernet.cpp b/src/wakeup/wakeup_ethernet.cpp
index 4df7be3..6ce1725 100644
--- a/src/wakeup/wakeup_ethernet.cpp
+++ b/src/wakeup/wakeup_ethernet.cpp
@@ -44,7 +44,7 @@
#include "../lib.h"
#include "wakeup_ethernet.h"
-ethernet_wakeup::ethernet_wakeup(const char *path, const char *iface) : wakeup("", 0.5, _("Enable"), _("Disable"))
+ethernet_wakeup::ethernet_wakeup(const char *path, const char *iface) : wakeup("", 0.5, _("Enabled"), _("Disabled"))
{
memset(interf, 0, sizeof(interf));
pt_strcpy(interf, iface);
diff --git a/src/wakeup/wakeup_usb.cpp b/src/wakeup/wakeup_usb.cpp
index 30dc3e6..e0e4567 100644
--- a/src/wakeup/wakeup_usb.cpp
+++ b/src/wakeup/wakeup_usb.cpp
@@ -44,7 +44,7 @@
#include "../lib.h"
#include "wakeup_usb.h"
-usb_wakeup::usb_wakeup(const char *path, const char *iface) : wakeup("", 0.5, _("Enable"), _("Disable"))
+usb_wakeup::usb_wakeup(const char *path, const char *iface) : wakeup("", 0.5, _("Enabled"), _("Disabled"))
{
memset(interf, 0, sizeof(interf));
pt_strcpy(interf, iface);
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-09 19:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-09 19:07 [Powertop] [PATCH] Make the wakeup toggle text clearer Auke Kok
-- strict thread matches above, loose matches on Subject: below --
2019-09-09 14:38 Zane Zakraisek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.