From: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com> To: Alex Deucher <alexdeucher@gmail.com>, Greg KH <gregkh@linuxfoundation.org> Cc: "Christian König" <ckoenig.leichtzumerken@gmail.com>, "Maling list - DRI developers" <dri-devel@lists.freedesktop.org>, "amd-gfx list" <amd-gfx@lists.freedesktop.org>, "Qiang Yu" <yuq825@gmail.com>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, "Deucher, Alexander" <Alexander.Deucher@amd.com> Subject: Re: [PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr Date: Tue, 19 Jan 2021 14:16:04 -0500 [thread overview] Message-ID: <d3c3ebd9-e887-7f2a-16dd-cc6841fffdf9@amd.com> (raw) In-Reply-To: <CADnq5_PNFQ+3tmRXjY2m22Pnx=neqMC_PTtqrObrdeg0LQUo_w@mail.gmail.com> On 1/19/21 2:04 PM, Alex Deucher wrote: > On Tue, Jan 19, 2021 at 1:26 PM Greg KH <gregkh@linuxfoundation.org> wrote: >> On Tue, Jan 19, 2021 at 11:36:01AM -0500, Andrey Grodzovsky wrote: >>> On 1/19/21 2:34 AM, Greg KH wrote: >>>> On Mon, Jan 18, 2021 at 04:01:19PM -0500, Andrey Grodzovsky wrote: >>>>> static struct pci_driver amdgpu_kms_pci_driver = { >>>>> .name = DRIVER_NAME, >>>>> .id_table = pciidlist, >>>>> @@ -1595,6 +1607,7 @@ static struct pci_driver amdgpu_kms_pci_driver = { >>>>> .shutdown = amdgpu_pci_shutdown, >>>>> .driver.pm = &amdgpu_pm_ops, >>>>> .err_handler = &amdgpu_pci_err_handler, >>>>> + .driver.dev_groups = amdgpu_sysfs_groups, >>>> Shouldn't this just be: >>>> groups - amdgpu_sysfs_groups, >>>> >>>> Why go to the "driver root" here? >>> >>> Because I still didn't get to your suggestion to propose a patch to add groups to >>> pci_driver, it's located in 'base' driver struct. >> You are a pci driver, you should never have to mess with the "base" >> driver struct. Look at commit 92d50fc1602e ("PCI/IB: add support for >> pci driver attribute groups") which got merged in 4.14, way back in >> 2017 :) > Per the previous discussion of this patch set: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.mail-archive.com%2Famd-gfx%40lists.freedesktop.org%2Fmsg56019.html&data=04%7C01%7CAndrey.Grodzovsky%40amd.com%7C1b43efdc8a164169eee508d8bcad1ece%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637466799090087255%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=T462j96qC%2BXCZzgnJMG%2BbUEOG94GVuqkvTWfUB%2B3%2Fl8%3D&reserved=0 > > Alex Got it, Next iteration I will include a patch like the above to pci-devel as part of the series and will update this patch accordingly. Andrey > >> driver.pm also looks odd, but I'm just going to ignore that for now... >> >> thanks, >> >> greg k-h >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7CAndrey.Grodzovsky%40amd.com%7C1b43efdc8a164169eee508d8bcad1ece%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637466799090087255%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=reQqTGFCsEXvHOmSt8c4B6idrotIS4Q69WKw%2FRtpAEg%3D&reserved=0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com> To: Alex Deucher <alexdeucher@gmail.com>, Greg KH <gregkh@linuxfoundation.org> Cc: "Christian König" <ckoenig.leichtzumerken@gmail.com>, "Maling list - DRI developers" <dri-devel@lists.freedesktop.org>, "amd-gfx list" <amd-gfx@lists.freedesktop.org>, "Qiang Yu" <yuq825@gmail.com>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, "Deucher, Alexander" <Alexander.Deucher@amd.com> Subject: Re: [PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr Date: Tue, 19 Jan 2021 14:16:04 -0500 [thread overview] Message-ID: <d3c3ebd9-e887-7f2a-16dd-cc6841fffdf9@amd.com> (raw) In-Reply-To: <CADnq5_PNFQ+3tmRXjY2m22Pnx=neqMC_PTtqrObrdeg0LQUo_w@mail.gmail.com> On 1/19/21 2:04 PM, Alex Deucher wrote: > On Tue, Jan 19, 2021 at 1:26 PM Greg KH <gregkh@linuxfoundation.org> wrote: >> On Tue, Jan 19, 2021 at 11:36:01AM -0500, Andrey Grodzovsky wrote: >>> On 1/19/21 2:34 AM, Greg KH wrote: >>>> On Mon, Jan 18, 2021 at 04:01:19PM -0500, Andrey Grodzovsky wrote: >>>>> static struct pci_driver amdgpu_kms_pci_driver = { >>>>> .name = DRIVER_NAME, >>>>> .id_table = pciidlist, >>>>> @@ -1595,6 +1607,7 @@ static struct pci_driver amdgpu_kms_pci_driver = { >>>>> .shutdown = amdgpu_pci_shutdown, >>>>> .driver.pm = &amdgpu_pm_ops, >>>>> .err_handler = &amdgpu_pci_err_handler, >>>>> + .driver.dev_groups = amdgpu_sysfs_groups, >>>> Shouldn't this just be: >>>> groups - amdgpu_sysfs_groups, >>>> >>>> Why go to the "driver root" here? >>> >>> Because I still didn't get to your suggestion to propose a patch to add groups to >>> pci_driver, it's located in 'base' driver struct. >> You are a pci driver, you should never have to mess with the "base" >> driver struct. Look at commit 92d50fc1602e ("PCI/IB: add support for >> pci driver attribute groups") which got merged in 4.14, way back in >> 2017 :) > Per the previous discussion of this patch set: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.mail-archive.com%2Famd-gfx%40lists.freedesktop.org%2Fmsg56019.html&data=04%7C01%7CAndrey.Grodzovsky%40amd.com%7C1b43efdc8a164169eee508d8bcad1ece%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637466799090087255%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=T462j96qC%2BXCZzgnJMG%2BbUEOG94GVuqkvTWfUB%2B3%2Fl8%3D&reserved=0 > > Alex Got it, Next iteration I will include a patch like the above to pci-devel as part of the series and will update this patch accordingly. Andrey > >> driver.pm also looks odd, but I'm just going to ignore that for now... >> >> thanks, >> >> greg k-h >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7CAndrey.Grodzovsky%40amd.com%7C1b43efdc8a164169eee508d8bcad1ece%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637466799090087255%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=reQqTGFCsEXvHOmSt8c4B6idrotIS4Q69WKw%2FRtpAEg%3D&reserved=0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-01-19 19:16 UTC|newest] Thread overview: 196+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-18 21:01 [PATCH v4 00/14] RFC Support hot device unplug in amdgpu Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-18 21:01 ` [PATCH v4 01/14] drm/ttm: Remap all page faults to per process dummy page Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-18 21:48 ` Alex Deucher 2021-01-18 21:48 ` Alex Deucher 2021-01-19 8:41 ` Christian König 2021-01-19 8:41 ` Christian König 2021-01-19 13:56 ` Daniel Vetter 2021-01-19 13:56 ` Daniel Vetter 2021-01-25 15:28 ` Andrey Grodzovsky 2021-01-25 15:28 ` Andrey Grodzovsky 2021-01-27 14:29 ` Andrey Grodzovsky 2021-01-27 14:29 ` Andrey Grodzovsky 2021-02-02 14:21 ` Daniel Vetter 2021-02-02 14:21 ` Daniel Vetter 2021-01-18 21:01 ` [PATCH v4 02/14] drm: Unamp the entire device address space on device unplug Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-18 21:01 ` [PATCH v4 03/14] drm/ttm: Expose ttm_tt_unpopulate for driver use Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-18 21:01 ` [PATCH v4 04/14] drm/sched: Cancel and flush all oustatdning jobs before finish Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-18 21:49 ` Alex Deucher 2021-01-18 21:49 ` Alex Deucher 2021-01-19 8:42 ` Christian König 2021-01-19 8:42 ` Christian König 2021-01-19 9:50 ` Christian König 2021-01-19 9:50 ` Christian König 2021-01-18 21:01 ` [PATCH v4 05/14] drm/amdgpu: Split amdgpu_device_fini into early and late Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-19 8:45 ` Christian König 2021-01-19 8:45 ` Christian König 2021-01-18 21:01 ` [PATCH v4 06/14] drm/amdgpu: Add early fini callback Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-18 21:01 ` [PATCH v4 07/14] drm/amdgpu: Register IOMMU topology notifier per device Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-18 21:52 ` Alex Deucher 2021-01-18 21:52 ` Alex Deucher 2021-01-19 8:48 ` Christian König 2021-01-19 8:48 ` Christian König 2021-01-19 13:45 ` Daniel Vetter 2021-01-19 13:45 ` Daniel Vetter 2021-01-19 21:21 ` Andrey Grodzovsky 2021-01-19 21:21 ` Andrey Grodzovsky 2021-01-19 22:01 ` Daniel Vetter 2021-01-19 22:01 ` Daniel Vetter 2021-01-20 4:21 ` Andrey Grodzovsky 2021-01-20 4:21 ` Andrey Grodzovsky 2021-01-20 8:38 ` Daniel Vetter 2021-01-20 8:38 ` Daniel Vetter [not found] ` <1a5f7ccb-1f91-91be-1cb1-e7cb43ac2c13@amd.com> 2021-01-21 10:48 ` Daniel Vetter 2021-01-21 10:48 ` Daniel Vetter 2021-01-20 5:01 ` Andrey Grodzovsky 2021-01-20 5:01 ` Andrey Grodzovsky 2021-01-20 19:38 ` Andrey Grodzovsky 2021-01-20 19:38 ` Andrey Grodzovsky 2021-01-21 10:42 ` Christian König 2021-01-21 10:42 ` Christian König 2021-01-18 21:01 ` [PATCH v4 08/14] drm/amdgpu: Fix a bunch of sdma code crash post device unplug Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-19 8:51 ` Christian König 2021-01-19 8:51 ` Christian König 2021-01-18 21:01 ` [PATCH v4 09/14] drm/amdgpu: Remap all page faults to per process dummy page Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-19 8:52 ` Christian König 2021-01-19 8:52 ` Christian König 2021-01-18 21:01 ` [PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-19 7:34 ` Greg KH 2021-01-19 7:34 ` Greg KH 2021-01-19 16:36 ` Andrey Grodzovsky 2021-01-19 16:36 ` Andrey Grodzovsky 2021-01-19 17:47 ` Greg KH 2021-01-19 17:47 ` Greg KH 2021-01-19 19:04 ` Alex Deucher 2021-01-19 19:04 ` Alex Deucher 2021-01-19 19:16 ` Andrey Grodzovsky [this message] 2021-01-19 19:16 ` Andrey Grodzovsky 2021-01-19 19:41 ` Greg KH 2021-01-19 19:41 ` Greg KH 2021-01-19 8:53 ` Christian König 2021-01-19 8:53 ` Christian König 2021-01-18 21:01 ` [PATCH v4 11/14] drm/amdgpu: Guard against write accesses after device removal Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-19 8:55 ` Christian König 2021-01-19 8:55 ` Christian König 2021-01-19 15:35 ` Andrey Grodzovsky 2021-01-19 15:35 ` Andrey Grodzovsky 2021-01-19 15:39 ` Christian König 2021-01-19 15:39 ` Christian König 2021-01-19 18:05 ` Daniel Vetter 2021-01-19 18:05 ` Daniel Vetter 2021-01-19 18:22 ` Andrey Grodzovsky 2021-01-19 18:22 ` Andrey Grodzovsky 2021-01-19 18:59 ` Christian König 2021-01-19 18:59 ` Christian König 2021-01-19 19:16 ` Andrey Grodzovsky 2021-01-19 19:16 ` Andrey Grodzovsky 2021-01-20 19:34 ` Andrey Grodzovsky 2021-01-20 19:34 ` Andrey Grodzovsky 2021-01-28 17:23 ` Andrey Grodzovsky 2021-01-28 17:23 ` Andrey Grodzovsky 2021-01-29 15:16 ` Christian König 2021-01-29 15:16 ` Christian König 2021-01-29 17:35 ` Andrey Grodzovsky 2021-01-29 17:35 ` Andrey Grodzovsky 2021-01-29 19:25 ` Christian König 2021-01-29 19:25 ` Christian König 2021-02-05 16:22 ` Andrey Grodzovsky 2021-02-05 16:22 ` Andrey Grodzovsky 2021-02-05 22:10 ` Daniel Vetter 2021-02-05 22:10 ` Daniel Vetter 2021-02-05 23:09 ` Andrey Grodzovsky 2021-02-05 23:09 ` Andrey Grodzovsky 2021-02-06 14:18 ` Daniel Vetter 2021-02-06 14:18 ` Daniel Vetter 2021-02-07 21:28 ` Andrey Grodzovsky 2021-02-07 21:28 ` Andrey Grodzovsky 2021-02-07 21:50 ` Daniel Vetter 2021-02-07 21:50 ` Daniel Vetter 2021-02-08 9:37 ` Christian König 2021-02-08 9:37 ` Christian König 2021-02-08 9:48 ` Daniel Vetter 2021-02-08 9:48 ` Daniel Vetter 2021-02-08 10:03 ` Christian König 2021-02-08 10:03 ` Christian König 2021-02-08 10:11 ` Daniel Vetter 2021-02-08 10:11 ` Daniel Vetter 2021-02-08 13:59 ` Christian König 2021-02-08 13:59 ` Christian König 2021-02-08 16:23 ` Daniel Vetter 2021-02-08 16:23 ` Daniel Vetter 2021-02-08 22:15 ` Andrey Grodzovsky 2021-02-08 22:15 ` Andrey Grodzovsky 2021-02-09 7:58 ` Christian König 2021-02-09 7:58 ` Christian König 2021-02-09 14:30 ` Andrey Grodzovsky 2021-02-09 14:30 ` Andrey Grodzovsky 2021-02-09 15:40 ` Christian König 2021-02-09 15:40 ` Christian König 2021-02-10 22:01 ` Andrey Grodzovsky 2021-02-10 22:01 ` Andrey Grodzovsky 2021-02-12 15:00 ` Andrey Grodzovsky 2021-02-12 15:00 ` Andrey Grodzovsky 2021-02-08 22:09 ` Andrey Grodzovsky 2021-02-08 22:09 ` Andrey Grodzovsky 2021-02-09 8:27 ` Christian König 2021-02-09 8:27 ` Christian König 2021-02-09 9:46 ` Daniel Vetter 2021-02-09 9:46 ` Daniel Vetter 2021-01-18 21:01 ` [PATCH v4 12/14] drm/scheduler: Job timeout handler returns status Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-19 7:53 ` Christian König 2021-01-19 7:53 ` Christian König 2021-01-19 17:47 ` Luben Tuikov 2021-01-19 17:47 ` Luben Tuikov 2021-01-19 18:53 ` Christian König 2021-01-19 18:53 ` Christian König 2021-01-18 21:01 ` [PATCH v4 13/14] drm/sched: Make timeout timer rearm conditional Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-18 21:01 ` [PATCH v4 14/14] drm/amdgpu: Prevent any job recoveries after device is unplugged Andrey Grodzovsky 2021-01-18 21:01 ` Andrey Grodzovsky 2021-01-19 14:16 ` [PATCH v4 00/14] RFC Support hot device unplug in amdgpu Daniel Vetter 2021-01-19 14:16 ` Daniel Vetter 2021-01-19 17:31 ` Andrey Grodzovsky 2021-01-19 17:31 ` Andrey Grodzovsky 2021-01-19 18:08 ` Daniel Vetter 2021-01-19 18:08 ` Daniel Vetter 2021-01-19 18:18 ` Andrey Grodzovsky 2021-01-19 18:18 ` Andrey Grodzovsky 2021-01-20 9:05 ` Daniel Vetter 2021-01-20 9:05 ` Daniel Vetter 2021-01-20 14:19 ` Andrey Grodzovsky 2021-01-20 14:19 ` Andrey Grodzovsky 2021-01-20 15:59 ` Daniel Vetter 2021-01-20 15:59 ` Daniel Vetter 2021-02-08 5:59 ` Andrey Grodzovsky 2021-02-08 5:59 ` Andrey Grodzovsky 2021-02-08 7:27 ` Daniel Vetter 2021-02-08 7:27 ` Daniel Vetter 2021-02-09 4:01 ` Andrey Grodzovsky 2021-02-09 4:01 ` Andrey Grodzovsky 2021-02-09 9:50 ` Daniel Vetter 2021-02-09 9:50 ` Daniel Vetter 2021-02-09 15:34 ` Andrey Grodzovsky 2021-02-09 15:34 ` Andrey Grodzovsky 2021-02-18 20:03 ` Andrey Grodzovsky 2021-02-18 20:03 ` Andrey Grodzovsky 2021-02-19 10:24 ` Daniel Vetter 2021-02-19 10:24 ` Daniel Vetter 2021-02-24 16:30 ` Andrey Grodzovsky 2021-02-24 16:30 ` Andrey Grodzovsky 2021-02-25 10:25 ` Daniel Vetter 2021-02-25 10:25 ` Daniel Vetter 2021-02-25 16:12 ` Andrey Grodzovsky 2021-02-25 16:12 ` Andrey Grodzovsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d3c3ebd9-e887-7f2a-16dd-cc6841fffdf9@amd.com \ --to=andrey.grodzovsky@amd.com \ --cc=Alexander.Deucher@amd.com \ --cc=alexdeucher@gmail.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=ckoenig.leichtzumerken@gmail.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=yuq825@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.