All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] apple: Fix debug uart clock rate
@ 2022-02-05 23:14 Mark Kettenis
  2022-02-06  4:04 ` Sean Anderson
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2022-02-05 23:14 UTC (permalink / raw)
  To: u-boot; +Cc: trini, sjg, Mark Kettenis

The clock rate for the serial console on Apple M1 systems is 24 MHz
instead of 240 Hz.

Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
---
 configs/apple_m1_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
index cb235e4e7d..71ffbc6ec4 100644
--- a/configs/apple_m1_defconfig
+++ b/configs/apple_m1_defconfig
@@ -2,7 +2,7 @@ CONFIG_ARM=y
 CONFIG_ARCH_APPLE=y
 CONFIG_DEFAULT_DEVICE_TREE="t8103-j274"
 CONFIG_DEBUG_UART_BASE=0x235200000
-CONFIG_DEBUG_UART_CLOCK=240000
+CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART=y
 CONFIG_SYS_LOAD_ADDR=0x880000000
 CONFIG_USE_PREBOOT=y
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] apple: Fix debug uart clock rate
  2022-02-05 23:14 [PATCH] apple: Fix debug uart clock rate Mark Kettenis
@ 2022-02-06  4:04 ` Sean Anderson
  2022-02-06 12:22   ` Mark Kettenis
  0 siblings, 1 reply; 3+ messages in thread
From: Sean Anderson @ 2022-02-06  4:04 UTC (permalink / raw)
  To: Mark Kettenis, u-boot; +Cc: trini, sjg

On 2/5/22 6:14 PM, Mark Kettenis wrote:
> The clock rate for the serial console on Apple M1 systems is 24 MHz
> instead of 240 Hz.

nit: kHz?

> 
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
>   configs/apple_m1_defconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
> index cb235e4e7d..71ffbc6ec4 100644
> --- a/configs/apple_m1_defconfig
> +++ b/configs/apple_m1_defconfig
> @@ -2,7 +2,7 @@ CONFIG_ARM=y
>   CONFIG_ARCH_APPLE=y
>   CONFIG_DEFAULT_DEVICE_TREE="t8103-j274"
>   CONFIG_DEBUG_UART_BASE=0x235200000
> -CONFIG_DEBUG_UART_CLOCK=240000
> +CONFIG_DEBUG_UART_CLOCK=24000000
>   CONFIG_DEBUG_UART=y
>   CONFIG_SYS_LOAD_ADDR=0x880000000
>   CONFIG_USE_PREBOOT=y
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] apple: Fix debug uart clock rate
  2022-02-06  4:04 ` Sean Anderson
@ 2022-02-06 12:22   ` Mark Kettenis
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Kettenis @ 2022-02-06 12:22 UTC (permalink / raw)
  To: Sean Anderson; +Cc: kettenis, u-boot, trini, sjg

> From: Sean Anderson <seanga2@gmail.com>
> Date: Sat, 5 Feb 2022 23:04:07 -0500
> 
> On 2/5/22 6:14 PM, Mark Kettenis wrote:
> > The clock rate for the serial console on Apple M1 systems is 24 MHz
> > instead of 240 Hz.
> 
> nit: kHz?

Ah yes.  Brain slightly misfired when writing that commit message.
Thanks!  I've sent a v2 with that fixed.  And also fixed Simon's email
address on the CC.

> > Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> > ---
> >   configs/apple_m1_defconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
> > index cb235e4e7d..71ffbc6ec4 100644
> > --- a/configs/apple_m1_defconfig
> > +++ b/configs/apple_m1_defconfig
> > @@ -2,7 +2,7 @@ CONFIG_ARM=y
> >   CONFIG_ARCH_APPLE=y
> >   CONFIG_DEFAULT_DEVICE_TREE="t8103-j274"
> >   CONFIG_DEBUG_UART_BASE=0x235200000
> > -CONFIG_DEBUG_UART_CLOCK=240000
> > +CONFIG_DEBUG_UART_CLOCK=24000000
> >   CONFIG_DEBUG_UART=y
> >   CONFIG_SYS_LOAD_ADDR=0x880000000
> >   CONFIG_USE_PREBOOT=y
> > 
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-06 12:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-05 23:14 [PATCH] apple: Fix debug uart clock rate Mark Kettenis
2022-02-06  4:04 ` Sean Anderson
2022-02-06 12:22   ` Mark Kettenis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.