From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Keerthy <j-keerthy@ti.com>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Tony Lindgren <tony@atomide.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
open list <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Yangtao Li <tiny.windzz@gmail.com>
Subject: Re: [PATCH] clocksource: timer-ti-dm: Fix regression
Date: Thu, 16 Jan 2020 14:32:50 +0100 [thread overview]
Message-ID: <d42f0dbc-a93e-8ca0-978c-56c32f2362cd@linaro.org> (raw)
In-Reply-To: <3d6da16f-45e6-5acd-021c-bc87da99cdec@ti.com>
On 16/01/2020 04:46, Keerthy wrote:
>
>
> On 11/01/20 11:58 am, Naresh Kamboju wrote:
>> On Tue, 7 Jan 2020 at 02:07, Tony Lindgren <tony@atomide.com> wrote:
>>>
>>> Clean-up commit 8c82723414d5 ("clocksource/drivers/timer-ti-dm:
>>> Switch to
>>> platform_get_irq") caused a regression where we now try to access
>>> uninitialized data for timer:
>>>
>>> drivers/clocksource/timer-ti-dm.c: In function 'omap_dm_timer_probe':
>>> drivers/clocksource/timer-ti-dm.c:798:13: warning: 'timer' may be used
>>> uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> On boot we now get:
>>>
>>> Unable to handle kernel NULL pointer dereference at virtual address
>>> 00000004
>>> ...
>>> (omap_dm_timer_probe) from [<c061ac7c>] (platform_drv_probe+0x48/0x98)
>>> (platform_drv_probe) from [<c0618c04>] (really_probe+0x1dc/0x348)
>>> (really_probe) from [<c0618ef4>] (driver_probe_device+0x5c/0x160)
>>>
>>> Let's fix the issue by moving platform_get_irq to happen after timer has
>>> been allocated.
>>>
>>> Fixes: 8c82723414d5 ("clocksource/drivers/timer-ti-dm: Switch to
>>> platform_get_irq")
>>
>> Thanks for fixing this issue.
>> I have noticed arm BeagleBoard-X15 boot failed on linux next tree
>> (5.5.0-rc5-next-20200110).
>>
>> [ 6.157822] 8<--- cut here ---
>> [ 6.160911] Unable to handle kernel NULL pointer dereference at
>> virtual address 00000004
>> [ 6.169120] pgd = 25d83e32
>> [ 6.171903] [00000004] *pgd=80000080204003, *pmd=00000000
>> [ 6.177358] Internal error: Oops: a06 [#1] SMP ARM
>> [ 6.182179] Modules linked in:
>> [ 6.185260] CPU: 0 PID: 1 Comm: swapper/0 Not tainted
>> 5.5.0-rc5-next-20200110 #1
>> [ 6.192694] Hardware name: Generic DRA74X (Flattened Device Tree)
>> [ 6.198832] PC is at omap_dm_timer_probe+0x48/0x310
>
> Tony/Daniel,
>
> This is still not in linux-next. Any idea when this will be pushed to
> linux-next branch?
It should be actually.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Keerthy <j-keerthy@ti.com>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Tony Lindgren <tony@atomide.com>
Cc: Yangtao Li <tiny.windzz@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-omap@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clocksource: timer-ti-dm: Fix regression
Date: Thu, 16 Jan 2020 14:32:50 +0100 [thread overview]
Message-ID: <d42f0dbc-a93e-8ca0-978c-56c32f2362cd@linaro.org> (raw)
In-Reply-To: <3d6da16f-45e6-5acd-021c-bc87da99cdec@ti.com>
On 16/01/2020 04:46, Keerthy wrote:
>
>
> On 11/01/20 11:58 am, Naresh Kamboju wrote:
>> On Tue, 7 Jan 2020 at 02:07, Tony Lindgren <tony@atomide.com> wrote:
>>>
>>> Clean-up commit 8c82723414d5 ("clocksource/drivers/timer-ti-dm:
>>> Switch to
>>> platform_get_irq") caused a regression where we now try to access
>>> uninitialized data for timer:
>>>
>>> drivers/clocksource/timer-ti-dm.c: In function 'omap_dm_timer_probe':
>>> drivers/clocksource/timer-ti-dm.c:798:13: warning: 'timer' may be used
>>> uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> On boot we now get:
>>>
>>> Unable to handle kernel NULL pointer dereference at virtual address
>>> 00000004
>>> ...
>>> (omap_dm_timer_probe) from [<c061ac7c>] (platform_drv_probe+0x48/0x98)
>>> (platform_drv_probe) from [<c0618c04>] (really_probe+0x1dc/0x348)
>>> (really_probe) from [<c0618ef4>] (driver_probe_device+0x5c/0x160)
>>>
>>> Let's fix the issue by moving platform_get_irq to happen after timer has
>>> been allocated.
>>>
>>> Fixes: 8c82723414d5 ("clocksource/drivers/timer-ti-dm: Switch to
>>> platform_get_irq")
>>
>> Thanks for fixing this issue.
>> I have noticed arm BeagleBoard-X15 boot failed on linux next tree
>> (5.5.0-rc5-next-20200110).
>>
>> [ 6.157822] 8<--- cut here ---
>> [ 6.160911] Unable to handle kernel NULL pointer dereference at
>> virtual address 00000004
>> [ 6.169120] pgd = 25d83e32
>> [ 6.171903] [00000004] *pgd=80000080204003, *pmd=00000000
>> [ 6.177358] Internal error: Oops: a06 [#1] SMP ARM
>> [ 6.182179] Modules linked in:
>> [ 6.185260] CPU: 0 PID: 1 Comm: swapper/0 Not tainted
>> 5.5.0-rc5-next-20200110 #1
>> [ 6.192694] Hardware name: Generic DRA74X (Flattened Device Tree)
>> [ 6.198832] PC is at omap_dm_timer_probe+0x48/0x310
>
> Tony/Daniel,
>
> This is still not in linux-next. Any idea when this will be pushed to
> linux-next branch?
It should be actually.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-16 13:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 20:37 [PATCH] clocksource: timer-ti-dm: Fix regression Tony Lindgren
2020-01-06 20:37 ` Tony Lindgren
2020-01-06 21:07 ` Olof Johansson
2020-01-06 21:07 ` Olof Johansson
2020-01-07 19:14 ` Frank Lee
2020-01-07 19:14 ` Frank Lee
2020-01-07 19:14 ` Frank Lee
2020-01-09 11:42 ` Daniel Lezcano
2020-01-09 11:42 ` Daniel Lezcano
2020-01-11 6:28 ` Naresh Kamboju
2020-01-11 6:28 ` Naresh Kamboju
2020-01-11 6:28 ` Naresh Kamboju
2020-01-16 3:46 ` Keerthy
2020-01-16 3:46 ` Keerthy
2020-01-16 3:46 ` Keerthy
2020-01-16 13:32 ` Daniel Lezcano [this message]
2020-01-16 13:32 ` Daniel Lezcano
2020-01-16 21:31 ` [tip: timers/core] clocksource/drivers/timer-ti-dm: Fix uninitialized pointer access tip-bot2 for Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d42f0dbc-a93e-8ca0-978c-56c32f2362cd@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=tglx@linutronix.de \
--cc=tiny.windzz@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.