From: Christian Herber <christian.herber@oss.nxp.com>
To: Andrew Lunn <andrew@lunn.ch>,
"Radu-nicolae Pirea (OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc: "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH] phy: nxp-c45: add driver for tja1103
Date: Tue, 13 Apr 2021 08:56:30 +0200 [thread overview]
Message-ID: <d44a2c82-124c-8628-6149-1363bb7d4869@oss.nxp.com> (raw)
In-Reply-To: <YHR6sXvW959zY22K@lunn.ch>
Hi Andrew,
On 4/12/2021 6:52 PM, Andrew Lunn wrote:
>
> So what you are say is, you don't care if the IP is completely
> different, it all goes in one driver. So lets put this driver into
> nxp-tja11xx.c. And then we avoid all the naming issues.
>
> Andrew
>
As this seems to be a key question, let me try and shed some more light
on this.
The original series of BASE-T1 PHYs includes TJA110, TJA1101, and
TJA1102. They are covered by the existing driver, which has the
unfortunate naming TJA11xx. Unfortunate, because the use of wildcards is
a bit to generous. E.g. the naming would also include a TJA1145, which
is a high-speed CAN transceiver. The truth is, extrapolating wildcards
in product names doesn't work as there is not guarantee of future
product names.
The mentioned TJA1100/1/2 are *fairly* software-compatible, which is why
it makes sense to have a shared driver. When it gets to TJA1103, there
is no SW compatibility, which is why we decided to create a new driver.
We want to support all future Ethernet PHY devices with this codebase,
and that is why the naming is that generic. The common denominator of
the devices is that they are NXP products and use clause 45 addressing.
When you say we don't care that the IP is different, that doesn't quite
fit. Just because the MDI is different, the register map does not need
to change much, so it will be easy to support future PHYs also when
using different PHY technology.
Moving the code into TJA11xx is creating more issues, as it assumes that
the devices which are managed by the driver are always TJA... devices
which may not be true.
Christian
next prev parent reply other threads:[~2021-04-13 6:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 18:41 [PATCH] phy: nxp-c45: add driver for tja1103 Radu Pirea (NXP OSS)
2021-04-09 19:18 ` Heiner Kallweit
2021-04-12 9:10 ` Radu Nicolae Pirea (NXP OSS)
2021-04-09 19:31 ` Jakub Kicinski
2021-04-09 19:36 ` Andrew Lunn
2021-04-12 10:02 ` Radu Nicolae Pirea (NXP OSS)
2021-04-12 12:57 ` Andrew Lunn
2021-04-12 14:11 ` Radu Nicolae Pirea (NXP OSS)
2021-04-12 14:23 ` Andrew Lunn
2021-04-12 14:49 ` Radu Nicolae Pirea (NXP OSS)
2021-04-12 16:52 ` Andrew Lunn
2021-04-13 6:56 ` Christian Herber [this message]
2021-04-13 13:30 ` Andrew Lunn
2021-04-13 13:44 ` Christian Herber
2021-04-13 13:57 ` Andrew Lunn
2021-04-13 14:02 ` Christian Herber
2021-04-13 14:04 ` Andrew Lunn
2021-04-11 2:33 ` kernel test robot
2021-04-11 2:33 ` kernel test robot
2021-04-12 9:50 ` Russell King - ARM Linux admin
2021-04-13 13:44 ` Radu Nicolae Pirea (NXP OSS)
2021-04-12 18:04 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d44a2c82-124c-8628-6149-1363bb7d4869@oss.nxp.com \
--to=christian.herber@oss.nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=radu-nicolae.pirea@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.