All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Herber <christian.herber@oss.nxp.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Radu-nicolae Pirea (OSS)" <radu-nicolae.pirea@oss.nxp.com>,
	"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: nxp-c45: add driver for tja1103
Date: Tue, 13 Apr 2021 16:02:28 +0200	[thread overview]
Message-ID: <d8910e5f-bdbb-f127-2acb-a6277c53b568@oss.nxp.com> (raw)
In-Reply-To: <YHWjU2LEXTqEYCmZ@lunn.ch>

On 4/13/2021 3:57 PM, Andrew Lunn wrote:
>> Ok, we can agree that there will not be a perfect naming. Would it be a
>> possibility to rename the existing TJA11xx driver to TJA1100-1-2 or is that
>> unwanted?
> 
> It is generally a bad idea. It makes back porting fixing harder if the
> file changes name.
> 
>> If nxp-c45.c is to generic (I take from your comments that' your
>> conclusion), we could at least lean towards nxp-c45-bt1.c? Unfortunately,
>> the product naming schemes are not sufficiently methodical to have a a good
>> driver name based on product names.
> 
> And what does bt1 stand for?
> 
> How about nxp-c45-tja11xx.c. It is not ideal, but it does at least
> give an indication of what devices it does cover, even if there is a
> big overlap with nxp-tja11xx.c, in terms of pattern matching. And if
> you do decide to have a major change of registers, your can call the
> device tja1201 and have a new driver nxp-c45-tja12xx.
> 
>         Andrew
> 

bt1 standing for BASE-T1.

As you can see from the current situation, it could well happen that a 
future PHY is SW incompatible (right now I would say it is unlikely, but 
ok), and the device is still a TJA11xx.

nxp-c45-tja11xx is acceptable from my point of view.

  reply	other threads:[~2021-04-13 14:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 18:41 [PATCH] phy: nxp-c45: add driver for tja1103 Radu Pirea (NXP OSS)
2021-04-09 19:18 ` Heiner Kallweit
2021-04-12  9:10   ` Radu Nicolae Pirea (NXP OSS)
2021-04-09 19:31 ` Jakub Kicinski
2021-04-09 19:36 ` Andrew Lunn
2021-04-12 10:02   ` Radu Nicolae Pirea (NXP OSS)
2021-04-12 12:57     ` Andrew Lunn
2021-04-12 14:11       ` Radu Nicolae Pirea (NXP OSS)
2021-04-12 14:23         ` Andrew Lunn
2021-04-12 14:49           ` Radu Nicolae Pirea (NXP OSS)
2021-04-12 16:52             ` Andrew Lunn
2021-04-13  6:56               ` Christian Herber
2021-04-13 13:30                 ` Andrew Lunn
2021-04-13 13:44                   ` Christian Herber
2021-04-13 13:57                     ` Andrew Lunn
2021-04-13 14:02                       ` Christian Herber [this message]
2021-04-13 14:04                         ` Andrew Lunn
2021-04-11  2:33 ` kernel test robot
2021-04-11  2:33   ` kernel test robot
2021-04-12  9:50 ` Russell King - ARM Linux admin
2021-04-13 13:44   ` Radu Nicolae Pirea (NXP OSS)
2021-04-12 18:04 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8910e5f-bdbb-f127-2acb-a6277c53b568@oss.nxp.com \
    --to=christian.herber@oss.nxp.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=radu-nicolae.pirea@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.