All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Mike Kravetz <mike.kravetz@oracle.com>,
	Michal Hocko <mhocko@kernel.org>,
	Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH] mm/mremap: Document MREMAP_FIXED dependency on MREMAP_MAYMOVE
Date: Tue, 11 Jul 2017 07:45:32 +0530	[thread overview]
Message-ID: <d482a336-cc08-a47e-24b8-8d91316f1d0d@linux.vnet.ibm.com> (raw)
In-Reply-To: <40c61daf-da2c-bab9-99d0-a7d7147f4514@oracle.com>

On 07/10/2017 11:01 PM, Mike Kravetz wrote:
> On 07/10/2017 06:41 AM, Michal Hocko wrote:
>> On Mon 10-07-17 17:02:11, Anshuman Khandual wrote:
>>> In the header file, just specify the dependency of MREMAP_FIXED
>>> on MREMAP_MAYMOVE and make it explicit for the user space.
>> I really fail to see a point of this patch. The depency belongs to the
>> code and it seems that we already enforce it
>> 	if (flags & MREMAP_FIXED && !(flags & MREMAP_MAYMOVE))
>> 		return ret;
>>
>> So what is the point here?
> Agree, I am not sure of your reasoning.
> 
> If to assist the programmer, there is no need as this is clearly specified
> in the man page:
> 
> "If  MREMAP_FIXED  is  specified,  then MREMAP_MAYMOVE must also be
>  specified."

Yeah the idea was to assist the programmer and I missed the man page's
details on this. My bad.

WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Mike Kravetz <mike.kravetz@oracle.com>,
	Michal Hocko <mhocko@kernel.org>,
	Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH] mm/mremap: Document MREMAP_FIXED dependency on MREMAP_MAYMOVE
Date: Tue, 11 Jul 2017 07:45:32 +0530	[thread overview]
Message-ID: <d482a336-cc08-a47e-24b8-8d91316f1d0d@linux.vnet.ibm.com> (raw)
In-Reply-To: <40c61daf-da2c-bab9-99d0-a7d7147f4514@oracle.com>

On 07/10/2017 11:01 PM, Mike Kravetz wrote:
> On 07/10/2017 06:41 AM, Michal Hocko wrote:
>> On Mon 10-07-17 17:02:11, Anshuman Khandual wrote:
>>> In the header file, just specify the dependency of MREMAP_FIXED
>>> on MREMAP_MAYMOVE and make it explicit for the user space.
>> I really fail to see a point of this patch. The depency belongs to the
>> code and it seems that we already enforce it
>> 	if (flags & MREMAP_FIXED && !(flags & MREMAP_MAYMOVE))
>> 		return ret;
>>
>> So what is the point here?
> Agree, I am not sure of your reasoning.
> 
> If to assist the programmer, there is no need as this is clearly specified
> in the man page:
> 
> "If  MREMAP_FIXED  is  specified,  then MREMAP_MAYMOVE must also be
>  specified."

Yeah the idea was to assist the programmer and I missed the man page's
details on this. My bad.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-07-11  2:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10 11:32 [PATCH] mm/mremap: Document MREMAP_FIXED dependency on MREMAP_MAYMOVE Anshuman Khandual
2017-07-10 11:32 ` Anshuman Khandual
2017-07-10 13:41 ` Michal Hocko
2017-07-10 13:41   ` Michal Hocko
2017-07-10 17:31   ` Mike Kravetz
2017-07-10 17:31     ` Mike Kravetz
2017-07-11  2:15     ` Anshuman Khandual [this message]
2017-07-11  2:15       ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d482a336-cc08-a47e-24b8-8d91316f1d0d@linux.vnet.ibm.com \
    --to=khandual@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mike.kravetz@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.