All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Schmelzer <hannes@schmelzer.or.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board/BuR/common: incorrect check of dtb
Date: Thu, 4 May 2017 12:35:37 +0200	[thread overview]
Message-ID: <d4ac1781-5045-dad0-4b35-4fac7e4d50f1@schmelzer.or.at> (raw)
In-Reply-To: <20170503214411.14270-1-xypron.glpk@gmx.de>

On 05/03/2017 11:44 PM, Heinrich Schuchardt wrote:
> The logical expression to check the dtb is incorrect in
> load_devicetree.
>
> The problem was indicated by cppcheck.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> I do not have a board for testing.
> Please, review carefully.
> ---
>   board/BuR/common/common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/BuR/common/common.c b/board/BuR/common/common.c
> index 876150402c..c0316b9ebd 100644
> --- a/board/BuR/common/common.c
> +++ b/board/BuR/common/common.c
> @@ -265,7 +265,7 @@ static int load_devicetree(void)
>   	char *dtbname = getenv("dtb");
>   	char *dtbdev = getenv("dtbdev");
>   	char *dtppart = getenv("dtbpart");
> -	if (!dtbdev || !dtbdev || !dtbname) {
> +	if (!dtbdev || !dtbpart || !dtbname) {
>   		printf("%s: <dtbdev>/<dtbpart>/<dtb> missing.\n", __func__);
>   		return -1;
>   	}
Reviewed-by: Hannes Schmelzer <oe5hpm@oevsv.at>
Acked-by: Hannes Schmelzer <oe5hpm@oevsv.at>

Thanks!

  reply	other threads:[~2017-05-04 10:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 21:44 [U-Boot] [PATCH] board/BuR/common: incorrect check of dtb Heinrich Schuchardt
2017-05-04 10:35 ` Hannes Schmelzer [this message]
2017-05-05 16:38 ` [U-Boot] " Tom Rini
2017-05-05 18:11   ` Anatolij Gustschin
2017-05-05 18:14     ` Tom Rini
2017-05-05 18:44       ` Hannes Schmelzer
2017-05-05 18:57         ` [U-Boot] [PATCH v2 1/1] " Heinrich Schuchardt
2017-05-05 19:45           ` Hannes Schmelzer
2017-05-07  1:28           ` [U-Boot] [U-Boot, v2, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4ac1781-5045-dad0-4b35-4fac7e4d50f1@schmelzer.or.at \
    --to=hannes@schmelzer.or.at \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.