From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] board/BuR/common: incorrect check of dtb
Date: Fri, 5 May 2017 14:14:33 -0400 [thread overview]
Message-ID: <20170505181433.GV12511@bill-the-cat> (raw)
In-Reply-To: <20170505201154.01b8aaed@crub>
On Fri, May 05, 2017 at 08:11:54PM +0200, Anatolij Gustschin wrote:
> On Fri, 5 May 2017 12:38:06 -0400
> Tom Rini trini at konsulko.com wrote:
> ...
> > > char *dtbname = getenv("dtb");
> > > char *dtbdev = getenv("dtbdev");
> > > char *dtppart = getenv("dtbpart");
> > > - if (!dtbdev || !dtbdev || !dtbname) {
> > > + if (!dtbdev || !dtbpart || !dtbname) {
> > > printf("%s: <dtbdev>/<dtbpart>/<dtb> missing.\n", __func__);
> > > return -1;
> > > }
> >
> > This breaks some boards such as brppt1_mmc, which I agree doesn't make a
> > lot of sense with just the above context, can you please test building
> > 'BuR' via buildman? Thanks!
>
> dtbpart is wrong here, the defined variable is dtppart.
Ah-ha! Time to clean off the laptop screen...
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170505/d9525728/attachment.sig>
next prev parent reply other threads:[~2017-05-05 18:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 21:44 [U-Boot] [PATCH] board/BuR/common: incorrect check of dtb Heinrich Schuchardt
2017-05-04 10:35 ` Hannes Schmelzer
2017-05-05 16:38 ` [U-Boot] " Tom Rini
2017-05-05 18:11 ` Anatolij Gustschin
2017-05-05 18:14 ` Tom Rini [this message]
2017-05-05 18:44 ` Hannes Schmelzer
2017-05-05 18:57 ` [U-Boot] [PATCH v2 1/1] " Heinrich Schuchardt
2017-05-05 19:45 ` Hannes Schmelzer
2017-05-07 1:28 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505181433.GV12511@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.