From: Hans Verkuil <hverkuil@xs4all.nl> To: Kevin Hilman <khilman@baylibre.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sakari Ailus <sakari.ailus@iki.fi>, linux-media@vger.kernel.org Cc: "Sekhar Nori" <nsekhar@ti.com>, "Axel Haslam" <ahaslam@baylibre.com>, "Bartosz Gołaszewski" <bgolaszewski@baylibre.com>, "Alexandre Bailon" <abailon@baylibre.com>, "David Lechner" <david@lechnology.com>, "Patrick Titiano" <ptitiano@baylibre.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 0/5] davinci: VPIF: add DT support Date: Fri, 16 Dec 2016 10:47:09 +0100 [thread overview] Message-ID: <d4b0501a-f83a-c8b1-e460-1ba50f68cca7@xs4all.nl> (raw) In-Reply-To: <20161207183025.20684-1-khilman@baylibre.com> On 07/12/16 19:30, Kevin Hilman wrote: > Prepare the groundwork for adding DT support for davinci VPIF drivers. > This series does some fixups/cleanups and then adds the DT binding and > DT compatible string matching for DT probing. > > The controversial part from previous versions around async subdev > parsing, and specifically hard-coding the input/output routing of > subdevs, has been left out of this series. That part can be done as a > follow-on step after agreement has been reached on the path forward. > With this version, platforms can still use the VPIF capture/display > drivers, but must provide platform_data for the subdevs and subdev > routing. > > Tested video capture to memory on da850-lcdk board using composite > input. Other than the comment for the first patch this series looks good. So once that's addressed I'll queue it up for 4.11. Regards, Hans > > Changes since v5: > - locking fix: updated comment around lock variable > - binding doc: added example for > - added reviewed-by tags from Laurent (thanks!) > > Changes since v4: > - dropped controversial async subdev parsing support. That can be > done as a follow-up step after the discussions have finalized on the > right approach. > - DT binding Acked by DT maintainer (Rob H.) > - reworked locking fix (suggested by Laurent) > > Changes since v3: > - move to a single VPIF node, DT binding updated accordingly > - misc fixes/updates based on reviews from Sakari > > Changes since v2: > - DT binding doc: fix example to use correct compatible > > Changes since v1: > - more specific compatible strings, based on SoC: ti,da850-vpif* > - fix locking bug when unlocking over subdev s_stream > > > Kevin Hilman (5): > [media] davinci: VPIF: fix module loading, init errors > [media] davinci: vpif_capture: remove hard-coded I2C adapter id > [media] davinci: vpif_capture: fix start/stop streaming locking > [media] dt-bindings: add TI VPIF documentation > [media] davinci: VPIF: add basic support for DT init > > .../devicetree/bindings/media/ti,da850-vpif.txt | 83 ++++++++++++++++++++++ > drivers/media/platform/davinci/vpif.c | 14 +++- > drivers/media/platform/davinci/vpif_capture.c | 26 +++++-- > drivers/media/platform/davinci/vpif_capture.h | 2 +- > drivers/media/platform/davinci/vpif_display.c | 6 ++ > include/media/davinci/vpif_types.h | 1 + > 6 files changed, 125 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt >
WARNING: multiple messages have this Message-ID (diff)
From: hverkuil@xs4all.nl (Hans Verkuil) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 0/5] davinci: VPIF: add DT support Date: Fri, 16 Dec 2016 10:47:09 +0100 [thread overview] Message-ID: <d4b0501a-f83a-c8b1-e460-1ba50f68cca7@xs4all.nl> (raw) In-Reply-To: <20161207183025.20684-1-khilman@baylibre.com> On 07/12/16 19:30, Kevin Hilman wrote: > Prepare the groundwork for adding DT support for davinci VPIF drivers. > This series does some fixups/cleanups and then adds the DT binding and > DT compatible string matching for DT probing. > > The controversial part from previous versions around async subdev > parsing, and specifically hard-coding the input/output routing of > subdevs, has been left out of this series. That part can be done as a > follow-on step after agreement has been reached on the path forward. > With this version, platforms can still use the VPIF capture/display > drivers, but must provide platform_data for the subdevs and subdev > routing. > > Tested video capture to memory on da850-lcdk board using composite > input. Other than the comment for the first patch this series looks good. So once that's addressed I'll queue it up for 4.11. Regards, Hans > > Changes since v5: > - locking fix: updated comment around lock variable > - binding doc: added example for > - added reviewed-by tags from Laurent (thanks!) > > Changes since v4: > - dropped controversial async subdev parsing support. That can be > done as a follow-up step after the discussions have finalized on the > right approach. > - DT binding Acked by DT maintainer (Rob H.) > - reworked locking fix (suggested by Laurent) > > Changes since v3: > - move to a single VPIF node, DT binding updated accordingly > - misc fixes/updates based on reviews from Sakari > > Changes since v2: > - DT binding doc: fix example to use correct compatible > > Changes since v1: > - more specific compatible strings, based on SoC: ti,da850-vpif* > - fix locking bug when unlocking over subdev s_stream > > > Kevin Hilman (5): > [media] davinci: VPIF: fix module loading, init errors > [media] davinci: vpif_capture: remove hard-coded I2C adapter id > [media] davinci: vpif_capture: fix start/stop streaming locking > [media] dt-bindings: add TI VPIF documentation > [media] davinci: VPIF: add basic support for DT init > > .../devicetree/bindings/media/ti,da850-vpif.txt | 83 ++++++++++++++++++++++ > drivers/media/platform/davinci/vpif.c | 14 +++- > drivers/media/platform/davinci/vpif_capture.c | 26 +++++-- > drivers/media/platform/davinci/vpif_capture.h | 2 +- > drivers/media/platform/davinci/vpif_display.c | 6 ++ > include/media/davinci/vpif_types.h | 1 + > 6 files changed, 125 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt >
next prev parent reply other threads:[~2016-12-16 9:47 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-07 18:30 [PATCH v6 0/5] davinci: VPIF: add DT support Kevin Hilman 2016-12-07 18:30 ` Kevin Hilman 2016-12-07 18:30 ` [PATCH v6 1/5] [media] davinci: VPIF: fix module loading, init errors Kevin Hilman 2016-12-07 18:30 ` Kevin Hilman 2016-12-09 10:07 ` Sakari Ailus 2016-12-09 10:07 ` Sakari Ailus 2016-12-16 9:44 ` Hans Verkuil 2016-12-16 9:44 ` Hans Verkuil 2016-12-16 23:39 ` Kevin Hilman 2016-12-16 23:39 ` Kevin Hilman 2016-12-17 0:47 ` [PATCH v6.1 " Kevin Hilman 2016-12-17 0:47 ` Kevin Hilman 2016-12-07 18:30 ` [PATCH v6 2/5] [media] davinci: vpif_capture: remove hard-coded I2C adapter id Kevin Hilman 2016-12-07 18:30 ` Kevin Hilman 2016-12-09 10:20 ` Sakari Ailus 2016-12-09 10:20 ` Sakari Ailus 2016-12-07 18:30 ` [PATCH v6 3/5] [media] davinci: vpif_capture: fix start/stop streaming locking Kevin Hilman 2016-12-07 18:30 ` Kevin Hilman 2016-12-07 18:30 ` [PATCH v6 4/5] [media] dt-bindings: add TI VPIF documentation Kevin Hilman 2016-12-07 18:30 ` Kevin Hilman 2016-12-07 18:30 ` [PATCH v6 5/5] [media] davinci: VPIF: add basic support for DT init Kevin Hilman 2016-12-07 18:30 ` Kevin Hilman 2016-12-07 20:03 ` [PATCH v6 0/5] davinci: VPIF: add DT support Javier Martinez Canillas 2016-12-07 20:03 ` Javier Martinez Canillas 2016-12-09 0:25 ` Kevin Hilman 2016-12-09 0:25 ` Kevin Hilman 2016-12-16 9:47 ` Hans Verkuil [this message] 2016-12-16 9:47 ` Hans Verkuil 2016-12-17 0:49 ` Kevin Hilman 2016-12-17 0:49 ` Kevin Hilman 2017-01-27 17:22 ` Kevin Hilman 2017-01-27 17:22 ` Kevin Hilman 2017-01-30 9:33 ` Hans Verkuil 2017-01-30 9:33 ` Hans Verkuil 2017-01-03 9:03 ` Sekhar Nori 2017-01-03 9:03 ` Sekhar Nori 2017-01-03 9:12 ` Laurent Pinchart 2017-01-03 9:12 ` Laurent Pinchart 2017-01-04 11:32 ` Sekhar Nori 2017-01-04 11:32 ` Sekhar Nori
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d4b0501a-f83a-c8b1-e460-1ba50f68cca7@xs4all.nl \ --to=hverkuil@xs4all.nl \ --cc=abailon@baylibre.com \ --cc=ahaslam@baylibre.com \ --cc=bgolaszewski@baylibre.com \ --cc=david@lechnology.com \ --cc=khilman@baylibre.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-media@vger.kernel.org \ --cc=nsekhar@ti.com \ --cc=ptitiano@baylibre.com \ --cc=sakari.ailus@iki.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.