All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1
@ 2021-03-31 12:22 Alexander Kanavin
  2021-03-31 12:22 ` [PATCH 2/2] ptest-runner: correct version check Alexander Kanavin
  2021-03-31 13:05 ` [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1 Martin Jansa
  0 siblings, 2 replies; 8+ messages in thread
From: Alexander Kanavin @ 2021-03-31 12:22 UTC (permalink / raw)
  To: openembedded-core; +Cc: Alexander Kanavin

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
---
 .../mesa/{mesa-gl_21.0.0.bb => mesa-gl_21.0.1.bb}               | 0
 meta/recipes-graphics/mesa/mesa.inc                             | 2 +-
 meta/recipes-graphics/mesa/{mesa_21.0.0.bb => mesa_21.0.1.bb}   | 0
 3 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-graphics/mesa/{mesa-gl_21.0.0.bb => mesa-gl_21.0.1.bb} (100%)
 rename meta/recipes-graphics/mesa/{mesa_21.0.0.bb => mesa_21.0.1.bb} (100%)

diff --git a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb b/meta/recipes-graphics/mesa/mesa-gl_21.0.1.bb
similarity index 100%
rename from meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
rename to meta/recipes-graphics/mesa/mesa-gl_21.0.1.bb
diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
index e9b72ce063..a40dad2b81 100644
--- a/meta/recipes-graphics/mesa/mesa.inc
+++ b/meta/recipes-graphics/mesa/mesa.inc
@@ -21,7 +21,7 @@ SRC_URI = "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
            file://0001-futex.h-Define-__NR_futex-if-it-does-not-exist.patch \
            "
 
-SRC_URI[sha256sum] = "e6204e98e6a8d77cf9dc5d34f99dd8e3ef7144f3601c808ca0dd26ba522e0d84"
+SRC_URI[sha256sum] = "379fc984459394f2ab2d84049efdc3a659869dc1328ce72ef0598506611712bb"
 
 UPSTREAM_CHECK_GITTAGREGEX = "mesa-(?P<pver>\d+(\.\d+)+)"
 
diff --git a/meta/recipes-graphics/mesa/mesa_21.0.0.bb b/meta/recipes-graphics/mesa/mesa_21.0.1.bb
similarity index 100%
rename from meta/recipes-graphics/mesa/mesa_21.0.0.bb
rename to meta/recipes-graphics/mesa/mesa_21.0.1.bb
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] ptest-runner: correct version check
  2021-03-31 12:22 [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1 Alexander Kanavin
@ 2021-03-31 12:22 ` Alexander Kanavin
  2021-03-31 13:05 ` [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1 Martin Jansa
  1 sibling, 0 replies; 8+ messages in thread
From: Alexander Kanavin @ 2021-03-31 12:22 UTC (permalink / raw)
  To: openembedded-core; +Cc: Alexander Kanavin

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
---
 meta/recipes-support/ptest-runner/ptest-runner_2.4.0.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-support/ptest-runner/ptest-runner_2.4.0.bb b/meta/recipes-support/ptest-runner/ptest-runner_2.4.0.bb
index 8b9938f572..0d23a3ee89 100644
--- a/meta/recipes-support/ptest-runner/ptest-runner_2.4.0.bb
+++ b/meta/recipes-support/ptest-runner/ptest-runner_2.4.0.bb
@@ -12,7 +12,6 @@ PV .= "+git${SRCPV}"
 
 SRC_URI = "git://git.yoctoproject.org/ptest-runner2 \
 "
-UPSTREAM_VERSION_UNKNOWN = "1"
 
 S = "${WORKDIR}/git"
 
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1
  2021-03-31 12:22 [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1 Alexander Kanavin
  2021-03-31 12:22 ` [PATCH 2/2] ptest-runner: correct version check Alexander Kanavin
@ 2021-03-31 13:05 ` Martin Jansa
  2021-03-31 13:44   ` Alexander Kanavin
  2021-03-31 17:13   ` Khem Raj
  1 sibling, 2 replies; 8+ messages in thread
From: Martin Jansa @ 2021-03-31 13:05 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 2303 bytes --]

Are you going to fix meta-gl issue with swrast still in DRIDRIVERS reported
on previous upgrade?

https://lists.openembedded.org/g/openembedded-core/message/149775

https://lists.openembedded.org/g/openembedded-core/message/149779
I don't know what exactly AB builds, but it's easy to reproduce locally,
something like:
DISTRO_FEATURES_remove = "x11"
PREFERRED_PROVIDER_virtual/libgl = "mesa-gl"
PREFERRED_PROVIDER_virtual/mesa = "mesa-gl"
bitbake mesa-gl
should be enough to see build failure.

On Wed, Mar 31, 2021 at 2:44 PM Alexander Kanavin <alex.kanavin@gmail.com>
wrote:

> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> ---
>  .../mesa/{mesa-gl_21.0.0.bb => mesa-gl_21.0.1.bb}               | 0
>  meta/recipes-graphics/mesa/mesa.inc                             | 2 +-
>  meta/recipes-graphics/mesa/{mesa_21.0.0.bb => mesa_21.0.1.bb}   | 0
>  3 files changed, 1 insertion(+), 1 deletion(-)
>  rename meta/recipes-graphics/mesa/{mesa-gl_21.0.0.bb => mesa-gl_21.0.1.bb}
> (100%)
>  rename meta/recipes-graphics/mesa/{mesa_21.0.0.bb => mesa_21.0.1.bb}
> (100%)
>
> diff --git a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
> b/meta/recipes-graphics/mesa/mesa-gl_21.0.1.bb
> similarity index 100%
> rename from meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
> rename to meta/recipes-graphics/mesa/mesa-gl_21.0.1.bb
> diff --git a/meta/recipes-graphics/mesa/mesa.inc
> b/meta/recipes-graphics/mesa/mesa.inc
> index e9b72ce063..a40dad2b81 100644
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -21,7 +21,7 @@ SRC_URI = "
> https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
>
> file://0001-futex.h-Define-__NR_futex-if-it-does-not-exist.patch \
>             "
>
> -SRC_URI[sha256sum] =
> "e6204e98e6a8d77cf9dc5d34f99dd8e3ef7144f3601c808ca0dd26ba522e0d84"
> +SRC_URI[sha256sum] =
> "379fc984459394f2ab2d84049efdc3a659869dc1328ce72ef0598506611712bb"
>
>  UPSTREAM_CHECK_GITTAGREGEX = "mesa-(?P<pver>\d+(\.\d+)+)"
>
> diff --git a/meta/recipes-graphics/mesa/mesa_21.0.0.bb
> b/meta/recipes-graphics/mesa/mesa_21.0.1.bb
> similarity index 100%
> rename from meta/recipes-graphics/mesa/mesa_21.0.0.bb
> rename to meta/recipes-graphics/mesa/mesa_21.0.1.bb
> --
> 2.29.2
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 4335 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1
  2021-03-31 13:05 ` [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1 Martin Jansa
@ 2021-03-31 13:44   ` Alexander Kanavin
  2021-03-31 17:13   ` Khem Raj
  1 sibling, 0 replies; 8+ messages in thread
From: Alexander Kanavin @ 2021-03-31 13:44 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer, Ross Burton

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

On Wed, 31 Mar 2021 at 15:05, Martin Jansa <martin.jansa@gmail.com> wrote:

> Are you going to fix meta-gl issue with swrast still in DRIDRIVERS
> reported on previous upgrade?
>
> https://lists.openembedded.org/g/openembedded-core/message/149775
>
> https://lists.openembedded.org/g/openembedded-core/message/149779
> I don't know what exactly AB builds, but it's easy to reproduce locally,
> something like:
> DISTRO_FEATURES_remove = "x11"
> PREFERRED_PROVIDER_virtual/libgl = "mesa-gl"
> PREFERRED_PROVIDER_virtual/mesa = "mesa-gl"
> bitbake mesa-gl
> should be enough to see build failure.
>

I'd rather Ross do it, as mesa-gl is 'his' recipe.

Alex

[-- Attachment #2: Type: text/html, Size: 1334 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1
  2021-03-31 13:05 ` [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1 Martin Jansa
  2021-03-31 13:44   ` Alexander Kanavin
@ 2021-03-31 17:13   ` Khem Raj
  2021-03-31 18:50     ` Martin Jansa
  1 sibling, 1 reply; 8+ messages in thread
From: Khem Raj @ 2021-03-31 17:13 UTC (permalink / raw)
  To: Martin Jansa, Alexander Kanavin
  Cc: Patches and discussions about the oe-core layer



On 3/31/21 6:05 AM, Martin Jansa wrote:
> Are you going to fix meta-gl issue with swrast still in DRIDRIVERS 
> reported on previous upgrade?
> 
> https://lists.openembedded.org/g/openembedded-core/message/149775 
> <https://lists.openembedded.org/g/openembedded-core/message/149775>
> 
> https://lists.openembedded.org/g/openembedded-core/message/149779 
> <https://lists.openembedded.org/g/openembedded-core/message/149779>
> I don't know what exactly AB builds, but it's easy to reproduce locally, 
> something like:
> DISTRO_FEATURES_remove = "x11"
> PREFERRED_PROVIDER_virtual/libgl = "mesa-gl"
> PREFERRED_PROVIDER_virtual/mesa = "mesa-gl"
> bitbake mesa-gl
> should be enough to see build failure.

it is a build regression. mesa and mesa-gl should be updated in sync and 
especially if you reported the fallout and if it went unaddressed is sad.

Could you try a patch somethiing like this and see if it helps.

diff --git a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb 
b/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
index e50782be1c..fc8b4f7504 100644
--- a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
+++ b/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
@@ -12,4 +12,4 @@ PACKAGECONFIG ??= "opengl dri 
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x1
  PACKAGECONFIG_class-target = "opengl dri 
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 'osmesa', d)}"

  # When NOT using X11, we need to make sure we have swrast available.
-DRIDRIVERS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '', 
',swrast', d)}"
+GALLIUMDRIVERS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 
'', ',swrast', d)}"

> 
> On Wed, Mar 31, 2021 at 2:44 PM Alexander Kanavin 
> <alex.kanavin@gmail.com <mailto:alex.kanavin@gmail.com>> wrote:
> 
>     Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com
>     <mailto:alex.kanavin@gmail.com>>
>     ---
>       .../mesa/{mesa-gl_21.0.0.bb <http://mesa-gl_21.0.0.bb> =>
>     mesa-gl_21.0.1.bb <http://mesa-gl_21.0.1.bb>}               | 0
>       meta/recipes-graphics/mesa/mesa.inc                             | 2 +-
>       meta/recipes-graphics/mesa/{mesa_21.0.0.bb <http://mesa_21.0.0.bb>
>     => mesa_21.0.1.bb <http://mesa_21.0.1.bb>}   | 0
>       3 files changed, 1 insertion(+), 1 deletion(-)
>       rename meta/recipes-graphics/mesa/{mesa-gl_21.0.0.bb
>     <http://mesa-gl_21.0.0.bb> => mesa-gl_21.0.1.bb
>     <http://mesa-gl_21.0.1.bb>} (100%)
>       rename meta/recipes-graphics/mesa/{mesa_21.0.0.bb
>     <http://mesa_21.0.0.bb> => mesa_21.0.1.bb <http://mesa_21.0.1.bb>}
>     (100%)
> 
>     diff --git a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
>     <http://mesa-gl_21.0.0.bb>
>     b/meta/recipes-graphics/mesa/mesa-gl_21.0.1.bb
>     <http://mesa-gl_21.0.1.bb>
>     similarity index 100%
>     rename from meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
>     <http://mesa-gl_21.0.0.bb>
>     rename to meta/recipes-graphics/mesa/mesa-gl_21.0.1.bb
>     <http://mesa-gl_21.0.1.bb>
>     diff --git a/meta/recipes-graphics/mesa/mesa.inc
>     b/meta/recipes-graphics/mesa/mesa.inc
>     index e9b72ce063..a40dad2b81 100644
>     --- a/meta/recipes-graphics/mesa/mesa.inc
>     +++ b/meta/recipes-graphics/mesa/mesa.inc
>     @@ -21,7 +21,7 @@ SRC_URI =
>     "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz
>     <https://mesa.freedesktop.org/archive/mesa-$%7BPV%7D.tar.xz> \
>                 
>     file://0001-futex.h-Define-__NR_futex-if-it-does-not-exist.patch \
>                  "
> 
>     -SRC_URI[sha256sum] =
>     "e6204e98e6a8d77cf9dc5d34f99dd8e3ef7144f3601c808ca0dd26ba522e0d84"
>     +SRC_URI[sha256sum] =
>     "379fc984459394f2ab2d84049efdc3a659869dc1328ce72ef0598506611712bb"
> 
>       UPSTREAM_CHECK_GITTAGREGEX = "mesa-(?P<pver>\d+(\.\d+)+)"
> 
>     diff --git a/meta/recipes-graphics/mesa/mesa_21.0.0.bb
>     <http://mesa_21.0.0.bb> b/meta/recipes-graphics/mesa/mesa_21.0.1.bb
>     <http://mesa_21.0.1.bb>
>     similarity index 100%
>     rename from meta/recipes-graphics/mesa/mesa_21.0.0.bb
>     <http://mesa_21.0.0.bb>
>     rename to meta/recipes-graphics/mesa/mesa_21.0.1.bb
>     <http://mesa_21.0.1.bb>
>     -- 
>     2.29.2
> 
> 
> 
> 
> 
> 
> 
> 

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1
  2021-03-31 17:13   ` Khem Raj
@ 2021-03-31 18:50     ` Martin Jansa
  2021-03-31 18:58       ` Khem Raj
  2021-03-31 19:04       ` Alexander Kanavin
  0 siblings, 2 replies; 8+ messages in thread
From: Martin Jansa @ 2021-03-31 18:50 UTC (permalink / raw)
  To: Khem Raj
  Cc: Alexander Kanavin, Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 4944 bytes --]

FWIW: I don't use mesa-gl at all, I've noticed it only in git grep
DRIDRIVERS when looking why swrast was still enabled in our normal mesa
(and it was because of our own bbappend).

But I agree that it's sad that it's OK to break Ross's recipe, when auh
says there is an update available, but it's Ross's responsibility now to
fix the follow-up breakage from that upgrade.

Thanks for the patch Khem!

On Wed, Mar 31, 2021 at 7:13 PM Khem Raj <raj.khem@gmail.com> wrote:

>
>
> On 3/31/21 6:05 AM, Martin Jansa wrote:
> > Are you going to fix meta-gl issue with swrast still in DRIDRIVERS
> > reported on previous upgrade?
> >
> > https://lists.openembedded.org/g/openembedded-core/message/149775
> > <https://lists.openembedded.org/g/openembedded-core/message/149775>
> >
> > https://lists.openembedded.org/g/openembedded-core/message/149779
> > <https://lists.openembedded.org/g/openembedded-core/message/149779>
> > I don't know what exactly AB builds, but it's easy to reproduce locally,
> > something like:
> > DISTRO_FEATURES_remove = "x11"
> > PREFERRED_PROVIDER_virtual/libgl = "mesa-gl"
> > PREFERRED_PROVIDER_virtual/mesa = "mesa-gl"
> > bitbake mesa-gl
> > should be enough to see build failure.
>
> it is a build regression. mesa and mesa-gl should be updated in sync and
> especially if you reported the fallout and if it went unaddressed is sad.
>
> Could you try a patch somethiing like this and see if it helps.
>
> diff --git a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
> b/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
> index e50782be1c..fc8b4f7504 100644
> --- a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
> +++ b/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
> @@ -12,4 +12,4 @@ PACKAGECONFIG ??= "opengl dri
> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x1
>   PACKAGECONFIG_class-target = "opengl dri
> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 'osmesa', d)}"
>
>   # When NOT using X11, we need to make sure we have swrast available.
> -DRIDRIVERS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '',
> ',swrast', d)}"
> +GALLIUMDRIVERS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'x11',
> '', ',swrast', d)}"
>
> >
> > On Wed, Mar 31, 2021 at 2:44 PM Alexander Kanavin
> > <alex.kanavin@gmail.com <mailto:alex.kanavin@gmail.com>> wrote:
> >
> >     Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com
> >     <mailto:alex.kanavin@gmail.com>>
> >     ---
> >       .../mesa/{mesa-gl_21.0.0.bb <http://mesa-gl_21.0.0.bb> =>
> >     mesa-gl_21.0.1.bb <http://mesa-gl_21.0.1.bb>}               | 0
> >       meta/recipes-graphics/mesa/mesa.inc                             |
> 2 +-
> >       meta/recipes-graphics/mesa/{mesa_21.0.0.bb <http://mesa_21.0.0.bb>
> >     => mesa_21.0.1.bb <http://mesa_21.0.1.bb>}   | 0
> >       3 files changed, 1 insertion(+), 1 deletion(-)
> >       rename meta/recipes-graphics/mesa/{mesa-gl_21.0.0.bb
> >     <http://mesa-gl_21.0.0.bb> => mesa-gl_21.0.1.bb
> >     <http://mesa-gl_21.0.1.bb>} (100%)
> >       rename meta/recipes-graphics/mesa/{mesa_21.0.0.bb
> >     <http://mesa_21.0.0.bb> => mesa_21.0.1.bb <http://mesa_21.0.1.bb>}
> >     (100%)
> >
> >     diff --git a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
> >     <http://mesa-gl_21.0.0.bb>
> >     b/meta/recipes-graphics/mesa/mesa-gl_21.0.1.bb
> >     <http://mesa-gl_21.0.1.bb>
> >     similarity index 100%
> >     rename from meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
> >     <http://mesa-gl_21.0.0.bb>
> >     rename to meta/recipes-graphics/mesa/mesa-gl_21.0.1.bb
> >     <http://mesa-gl_21.0.1.bb>
> >     diff --git a/meta/recipes-graphics/mesa/mesa.inc
> >     b/meta/recipes-graphics/mesa/mesa.inc
> >     index e9b72ce063..a40dad2b81 100644
> >     --- a/meta/recipes-graphics/mesa/mesa.inc
> >     +++ b/meta/recipes-graphics/mesa/mesa.inc
> >     @@ -21,7 +21,7 @@ SRC_URI =
> >     "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz
> >     <https://mesa.freedesktop.org/archive/mesa-$%7BPV%7D.tar.xz> \
> >
> >     file://0001-futex.h-Define-__NR_futex-if-it-does-not-exist.patch \
> >                  "
> >
> >     -SRC_URI[sha256sum] =
> >     "e6204e98e6a8d77cf9dc5d34f99dd8e3ef7144f3601c808ca0dd26ba522e0d84"
> >     +SRC_URI[sha256sum] =
> >     "379fc984459394f2ab2d84049efdc3a659869dc1328ce72ef0598506611712bb"
> >
> >       UPSTREAM_CHECK_GITTAGREGEX = "mesa-(?P<pver>\d+(\.\d+)+)"
> >
> >     diff --git a/meta/recipes-graphics/mesa/mesa_21.0.0.bb
> >     <http://mesa_21.0.0.bb> b/meta/recipes-graphics/mesa/mesa_21.0.1.bb
> >     <http://mesa_21.0.1.bb>
> >     similarity index 100%
> >     rename from meta/recipes-graphics/mesa/mesa_21.0.0.bb
> >     <http://mesa_21.0.0.bb>
> >     rename to meta/recipes-graphics/mesa/mesa_21.0.1.bb
> >     <http://mesa_21.0.1.bb>
> >     --
> >     2.29.2
> >
> >
> >
> >
> >
> >
> > 
> >
>

[-- Attachment #2: Type: text/html, Size: 9815 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1
  2021-03-31 18:50     ` Martin Jansa
@ 2021-03-31 18:58       ` Khem Raj
  2021-03-31 19:04       ` Alexander Kanavin
  1 sibling, 0 replies; 8+ messages in thread
From: Khem Raj @ 2021-03-31 18:58 UTC (permalink / raw)
  To: Martin Jansa
  Cc: Alexander Kanavin, Patches and discussions about the oe-core layer



On 3/31/21 11:50 AM, Martin Jansa wrote:
> FWIW: I don't use mesa-gl at all, I've noticed it only in git grep 
> DRIDRIVERS when looking why swrast was still enabled in our normal mesa 
> (and it was because of our own bbappend).

It also in meta-raspberrypi which will need update if this patch works 
out ok.

> 
> But I agree that it's sad that it's OK to break Ross's recipe, when auh 
> says there is an update available, but it's Ross's responsibility now to 
> fix the follow-up breakage from that upgrade.
> 
> Thanks for the patch Khem!
> 
> On Wed, Mar 31, 2021 at 7:13 PM Khem Raj <raj.khem@gmail.com 
> <mailto:raj.khem@gmail.com>> wrote:
> 
> 
> 
>     On 3/31/21 6:05 AM, Martin Jansa wrote:
>      > Are you going to fix meta-gl issue with swrast still in DRIDRIVERS
>      > reported on previous upgrade?
>      >
>      > https://lists.openembedded.org/g/openembedded-core/message/149775
>     <https://lists.openembedded.org/g/openembedded-core/message/149775>
>      >
>     <https://lists.openembedded.org/g/openembedded-core/message/149775
>     <https://lists.openembedded.org/g/openembedded-core/message/149775>>
>      >
>      > https://lists.openembedded.org/g/openembedded-core/message/149779
>     <https://lists.openembedded.org/g/openembedded-core/message/149779>
>      >
>     <https://lists.openembedded.org/g/openembedded-core/message/149779
>     <https://lists.openembedded.org/g/openembedded-core/message/149779>>
>      > I don't know what exactly AB builds, but it's easy to reproduce
>     locally,
>      > something like:
>      > DISTRO_FEATURES_remove = "x11"
>      > PREFERRED_PROVIDER_virtual/libgl = "mesa-gl"
>      > PREFERRED_PROVIDER_virtual/mesa = "mesa-gl"
>      > bitbake mesa-gl
>      > should be enough to see build failure.
> 
>     it is a build regression. mesa and mesa-gl should be updated in sync
>     and
>     especially if you reported the fallout and if it went unaddressed is
>     sad.
> 
>     Could you try a patch somethiing like this and see if it helps.
> 
>     diff --git a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
>     <http://mesa-gl_21.0.0.bb>
>     b/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
>     <http://mesa-gl_21.0.0.bb>
>     index e50782be1c..fc8b4f7504 100644
>     --- a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
>     <http://mesa-gl_21.0.0.bb>
>     +++ b/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
>     <http://mesa-gl_21.0.0.bb>
>     @@ -12,4 +12,4 @@ PACKAGECONFIG ??= "opengl dri
>     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x1
>        PACKAGECONFIG_class-target = "opengl dri
>     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 'osmesa', d)}"
> 
>        # When NOT using X11, we need to make sure we have swrast available.
>     -DRIDRIVERS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'x11',
>     '',
>     ',swrast', d)}"
>     +GALLIUMDRIVERS_append = "${@bb.utils.contains('DISTRO_FEATURES',
>     'x11',
>     '', ',swrast', d)}"
> 
>      >
>      > On Wed, Mar 31, 2021 at 2:44 PM Alexander Kanavin
>      > <alex.kanavin@gmail.com <mailto:alex.kanavin@gmail.com>
>     <mailto:alex.kanavin@gmail.com <mailto:alex.kanavin@gmail.com>>> wrote:
>      >
>      >     Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com
>     <mailto:alex.kanavin@gmail.com>
>      >     <mailto:alex.kanavin@gmail.com <mailto:alex.kanavin@gmail.com>>>
>      >     ---
>      >       .../mesa/{mesa-gl_21.0.0.bb <http://mesa-gl_21.0.0.bb>
>     <http://mesa-gl_21.0.0.bb <http://mesa-gl_21.0.0.bb>> =>
>      > mesa-gl_21.0.1.bb <http://mesa-gl_21.0.1.bb>
>     <http://mesa-gl_21.0.1.bb <http://mesa-gl_21.0.1.bb>>}               | 0
>      >       meta/recipes-graphics/mesa/mesa.inc                       
>           | 2 +-
>      >       meta/recipes-graphics/mesa/{mesa_21.0.0.bb
>     <http://mesa_21.0.0.bb> <http://mesa_21.0.0.bb <http://mesa_21.0.0.bb>>
>      >     => mesa_21.0.1.bb <http://mesa_21.0.1.bb>
>     <http://mesa_21.0.1.bb <http://mesa_21.0.1.bb>>}   | 0
>      >       3 files changed, 1 insertion(+), 1 deletion(-)
>      >       rename meta/recipes-graphics/mesa/{mesa-gl_21.0.0.bb
>     <http://mesa-gl_21.0.0.bb>
>      >     <http://mesa-gl_21.0.0.bb <http://mesa-gl_21.0.0.bb>> =>
>     mesa-gl_21.0.1.bb <http://mesa-gl_21.0.1.bb>
>      >     <http://mesa-gl_21.0.1.bb <http://mesa-gl_21.0.1.bb>>} (100%)
>      >       rename meta/recipes-graphics/mesa/{mesa_21.0.0.bb
>     <http://mesa_21.0.0.bb>
>      >     <http://mesa_21.0.0.bb <http://mesa_21.0.0.bb>> =>
>     mesa_21.0.1.bb <http://mesa_21.0.1.bb> <http://mesa_21.0.1.bb
>     <http://mesa_21.0.1.bb>>}
>      >     (100%)
>      >
>      >     diff --git a/meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
>     <http://mesa-gl_21.0.0.bb>
>      >     <http://mesa-gl_21.0.0.bb <http://mesa-gl_21.0.0.bb>>
>      >     b/meta/recipes-graphics/mesa/mesa-gl_21.0.1.bb
>     <http://mesa-gl_21.0.1.bb>
>      >     <http://mesa-gl_21.0.1.bb <http://mesa-gl_21.0.1.bb>>
>      >     similarity index 100%
>      >     rename from meta/recipes-graphics/mesa/mesa-gl_21.0.0.bb
>     <http://mesa-gl_21.0.0.bb>
>      >     <http://mesa-gl_21.0.0.bb <http://mesa-gl_21.0.0.bb>>
>      >     rename to meta/recipes-graphics/mesa/mesa-gl_21.0.1.bb
>     <http://mesa-gl_21.0.1.bb>
>      >     <http://mesa-gl_21.0.1.bb <http://mesa-gl_21.0.1.bb>>
>      >     diff --git a/meta/recipes-graphics/mesa/mesa.inc
>      >     b/meta/recipes-graphics/mesa/mesa.inc
>      >     index e9b72ce063..a40dad2b81 100644
>      >     --- a/meta/recipes-graphics/mesa/mesa.inc
>      >     +++ b/meta/recipes-graphics/mesa/mesa.inc
>      >     @@ -21,7 +21,7 @@ SRC_URI =
>      >     "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz
>     <https://mesa.freedesktop.org/archive/mesa-$%7BPV%7D.tar.xz>
>      >     <https://mesa.freedesktop.org/archive/mesa-$%7BPV%7D.tar.xz
>     <https://mesa.freedesktop.org/archive/mesa-$%7BPV%7D.tar.xz>> \
>      >
>      >   
>       file://0001-futex.h-Define-__NR_futex-if-it-does-not-exist.patch \
>      >                  "
>      >
>      >     -SRC_URI[sha256sum] =
>      >   
>       "e6204e98e6a8d77cf9dc5d34f99dd8e3ef7144f3601c808ca0dd26ba522e0d84"
>      >     +SRC_URI[sha256sum] =
>      >   
>       "379fc984459394f2ab2d84049efdc3a659869dc1328ce72ef0598506611712bb"
>      >
>      >       UPSTREAM_CHECK_GITTAGREGEX = "mesa-(?P<pver>\d+(\.\d+)+)"
>      >
>      >     diff --git a/meta/recipes-graphics/mesa/mesa_21.0.0.bb
>     <http://mesa_21.0.0.bb>
>      >     <http://mesa_21.0.0.bb <http://mesa_21.0.0.bb>>
>     b/meta/recipes-graphics/mesa/mesa_21.0.1.bb <http://mesa_21.0.1.bb>
>      >     <http://mesa_21.0.1.bb <http://mesa_21.0.1.bb>>
>      >     similarity index 100%
>      >     rename from meta/recipes-graphics/mesa/mesa_21.0.0.bb
>     <http://mesa_21.0.0.bb>
>      >     <http://mesa_21.0.0.bb <http://mesa_21.0.0.bb>>
>      >     rename to meta/recipes-graphics/mesa/mesa_21.0.1.bb
>     <http://mesa_21.0.1.bb>
>      >     <http://mesa_21.0.1.bb <http://mesa_21.0.1.bb>>
>      >     --
>      >     2.29.2
>      >
>      >
>      >
>      >
>      >
>      >
>      > 
>      >
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1
  2021-03-31 18:50     ` Martin Jansa
  2021-03-31 18:58       ` Khem Raj
@ 2021-03-31 19:04       ` Alexander Kanavin
  1 sibling, 0 replies; 8+ messages in thread
From: Alexander Kanavin @ 2021-03-31 19:04 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Khem Raj, Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

On Wed, 31 Mar 2021 at 20:50, Martin Jansa <martin.jansa@gmail.com> wrote:

> FWIW: I don't use mesa-gl at all, I've noticed it only in git grep
> DRIDRIVERS when looking why swrast was still enabled in our normal mesa
> (and it was because of our own bbappend).
>
> But I agree that it's sad that it's OK to break Ross's recipe, when auh
> says there is an update available, but it's Ross's responsibility now to
> fix the follow-up breakage from that upgrade.
>
> Thanks for the patch Khem!
>

Look, the autobuilder found no issues whatsoever with this update. This is
the line I draw in those oe-core version updates (which are apparently are
mostly my problem for the past several years): I do not care for the myriad
possible setups that are not a part of the autobuilder matrix.

Alex

[-- Attachment #2: Type: text/html, Size: 1195 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-03-31 19:04 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 12:22 [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1 Alexander Kanavin
2021-03-31 12:22 ` [PATCH 2/2] ptest-runner: correct version check Alexander Kanavin
2021-03-31 13:05 ` [OE-core] [PATCH 1/2] mesa: update 21.0.0 -> 21.0.1 Martin Jansa
2021-03-31 13:44   ` Alexander Kanavin
2021-03-31 17:13   ` Khem Raj
2021-03-31 18:50     ` Martin Jansa
2021-03-31 18:58       ` Khem Raj
2021-03-31 19:04       ` Alexander Kanavin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.