* [PATCH] tw686x: be explicit about the possible dma_mode options
@ 2016-06-27 8:31 Hans Verkuil
2016-06-27 15:37 ` Ezequiel Garcia
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2016-06-27 8:31 UTC (permalink / raw)
To: Linux Media Mailing List, Ezequiel Garcia
Users won't know what to put in this module option if it isn't
described.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
Ezequiel, this sits on top of your tw686x patch series and will be part of the pull
request.
---
drivers/media/pci/tw686x/tw686x-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/tw686x/tw686x-core.c b/drivers/media/pci/tw686x/tw686x-core.c
index 586bc67..71a0453 100644
--- a/drivers/media/pci/tw686x/tw686x-core.c
+++ b/drivers/media/pci/tw686x/tw686x-core.c
@@ -91,7 +91,7 @@ static int tw686x_dma_mode_set(const char *val, struct kernel_param *kp)
}
module_param_call(dma_mode, tw686x_dma_mode_set, tw686x_dma_mode_get,
&dma_mode, S_IRUGO|S_IWUSR);
-MODULE_PARM_DESC(dma_mode, "DMA operation mode");
+MODULE_PARM_DESC(dma_mode, "DMA operation mode (memcpy/contig/sg, default=memcpy)");
void tw686x_disable_channel(struct tw686x_dev *dev, unsigned int channel)
{
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tw686x: be explicit about the possible dma_mode options
2016-06-27 8:31 [PATCH] tw686x: be explicit about the possible dma_mode options Hans Verkuil
@ 2016-06-27 15:37 ` Ezequiel Garcia
0 siblings, 0 replies; 2+ messages in thread
From: Ezequiel Garcia @ 2016-06-27 15:37 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
On 27 June 2016 at 05:31, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> Users won't know what to put in this module option if it isn't
> described.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> Ezequiel, this sits on top of your tw686x patch series and will be part of the pull
> request.
It looks good.
Thanks!
> ---
> drivers/media/pci/tw686x/tw686x-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/tw686x/tw686x-core.c b/drivers/media/pci/tw686x/tw686x-core.c
> index 586bc67..71a0453 100644
> --- a/drivers/media/pci/tw686x/tw686x-core.c
> +++ b/drivers/media/pci/tw686x/tw686x-core.c
> @@ -91,7 +91,7 @@ static int tw686x_dma_mode_set(const char *val, struct kernel_param *kp)
> }
> module_param_call(dma_mode, tw686x_dma_mode_set, tw686x_dma_mode_get,
> &dma_mode, S_IRUGO|S_IWUSR);
> -MODULE_PARM_DESC(dma_mode, "DMA operation mode");
> +MODULE_PARM_DESC(dma_mode, "DMA operation mode (memcpy/contig/sg, default=memcpy)");
>
> void tw686x_disable_channel(struct tw686x_dev *dev, unsigned int channel)
> {
> --
> 2.8.1
>
--
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-27 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-27 8:31 [PATCH] tw686x: be explicit about the possible dma_mode options Hans Verkuil
2016-06-27 15:37 ` Ezequiel Garcia
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.