All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf/x86/uncore: Add missing filter constraint for SKX CHA event
@ 2018-03-12 15:41 Kan Liang
  2018-03-12 16:39 ` Peter Zijlstra
  2018-03-20 11:16 ` [tip:perf/urgent] perf/x86/intel/uncore: " tip-bot for Stephane Eranian
  0 siblings, 2 replies; 4+ messages in thread
From: Kan Liang @ 2018-03-12 15:41 UTC (permalink / raw)
  To: peterz, mingo, linux-kernel; +Cc: eranian, ak, Kan Liang

From: Stephane Eranian <eranian@google.com>

Adding a filter constraint for Intel Skylake CHA event
UNC_CHA_UPI_CREDITS_ACQUIRED (0x38).
The event supports core-id/thread-id and link filtering.

Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
---
 arch/x86/events/intel/uncore_snbep.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index 8ff1aac..d4672ed 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -3355,6 +3355,7 @@ static struct extra_reg skx_uncore_cha_extra_regs[] = {
 	SNBEP_CBO_EVENT_EXTRA_REG(0x9134, 0xffff, 0x4),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x35, 0xff, 0x8),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x36, 0xff, 0x8),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x38, 0xff, 0x3),
 	EVENT_EXTRA_END
 };
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] perf/x86/uncore: Add missing filter constraint for SKX CHA event
  2018-03-12 15:41 [PATCH] perf/x86/uncore: Add missing filter constraint for SKX CHA event Kan Liang
@ 2018-03-12 16:39 ` Peter Zijlstra
  2018-03-13  1:49   ` Liang, Kan
  2018-03-20 11:16 ` [tip:perf/urgent] perf/x86/intel/uncore: " tip-bot for Stephane Eranian
  1 sibling, 1 reply; 4+ messages in thread
From: Peter Zijlstra @ 2018-03-12 16:39 UTC (permalink / raw)
  To: Kan Liang; +Cc: mingo, linux-kernel, eranian, ak

On Mon, Mar 12, 2018 at 08:41:34AM -0700, Kan Liang wrote:
> From: Stephane Eranian <eranian@google.com>
> 
> Adding a filter constraint for Intel Skylake CHA event
> UNC_CHA_UPI_CREDITS_ACQUIRED (0x38).
> The event supports core-id/thread-id and link filtering.

Could you also comment on the other CHA patch?

 https://lkml.kernel.org/r/CS1PR84MB01182561B15688095C4DBF30F6D80@CS1PR84MB0118.NAMPRD84.PROD.OUTLOOK.COM

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] perf/x86/uncore: Add missing filter constraint for SKX CHA event
  2018-03-12 16:39 ` Peter Zijlstra
@ 2018-03-13  1:49   ` Liang, Kan
  0 siblings, 0 replies; 4+ messages in thread
From: Liang, Kan @ 2018-03-13  1:49 UTC (permalink / raw)
  To: Peter Zijlstra; +Cc: mingo, linux-kernel, eranian, ak



On 3/12/2018 12:39 PM, Peter Zijlstra wrote:
> On Mon, Mar 12, 2018 at 08:41:34AM -0700, Kan Liang wrote:
>> From: Stephane Eranian <eranian@google.com>
>>
>> Adding a filter constraint for Intel Skylake CHA event
>> UNC_CHA_UPI_CREDITS_ACQUIRED (0x38).
>> The event supports core-id/thread-id and link filtering.
> 
> Could you also comment on the other CHA patch?
> 
>   https://lkml.kernel.org/r/CS1PR84MB01182561B15688095C4DBF30F6D80@CS1PR84MB0118.NAMPRD84.PROD.OUTLOOK.COM
>


Now, there is a recommended way in uncore document to query the number 
of CHAs by reading bits 27:0 in the CAPID6 register located at Device 
30, Function 3, Offset 0x9C.
I have implemented a patch and sent it to Gary. It should fix his issue.

Thanks,
Kan

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip:perf/urgent] perf/x86/intel/uncore: Add missing filter constraint for SKX CHA event
  2018-03-12 15:41 [PATCH] perf/x86/uncore: Add missing filter constraint for SKX CHA event Kan Liang
  2018-03-12 16:39 ` Peter Zijlstra
@ 2018-03-20 11:16 ` tip-bot for Stephane Eranian
  1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Stephane Eranian @ 2018-03-20 11:16 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: alexander.shishkin, hpa, acme, peterz, eranian, tglx,
	vincent.weaver, linux-kernel, jolsa, mingo, kan.liang, torvalds

Commit-ID:  e340895c9ed0b44548f08bbaaee4afc7bfacd354
Gitweb:     https://git.kernel.org/tip/e340895c9ed0b44548f08bbaaee4afc7bfacd354
Author:     Stephane Eranian <eranian@google.com>
AuthorDate: Mon, 12 Mar 2018 08:41:34 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 20 Mar 2018 08:53:32 +0100

perf/x86/intel/uncore: Add missing filter constraint for SKX CHA event

Adding a filter constraint for Intel Skylake CHA event
UNC_CHA_UPI_CREDITS_ACQUIRED (0x38).

The event supports core-id/thread-id and link filtering.

Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/1520869294-14176-1-git-send-email-kan.liang@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/events/intel/uncore_snbep.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index 22ec65bc033a..0876798f2ac9 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -3343,6 +3343,7 @@ static struct extra_reg skx_uncore_cha_extra_regs[] = {
 	SNBEP_CBO_EVENT_EXTRA_REG(0x9134, 0xffff, 0x4),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x35, 0xff, 0x8),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x36, 0xff, 0x8),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x38, 0xff, 0x3),
 	EVENT_EXTRA_END
 };
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-20 11:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-12 15:41 [PATCH] perf/x86/uncore: Add missing filter constraint for SKX CHA event Kan Liang
2018-03-12 16:39 ` Peter Zijlstra
2018-03-13  1:49   ` Liang, Kan
2018-03-20 11:16 ` [tip:perf/urgent] perf/x86/intel/uncore: " tip-bot for Stephane Eranian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.