All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH master] dash: fix static link with libedit
@ 2018-03-02  5:22 Baruch Siach
  2018-03-02  7:37 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2018-03-02  5:22 UTC (permalink / raw)
  To: buildroot

libedit is an optional dependency of dash since commit 651af57cf011e
(dash: enable line editting if libedit is selected). Unfortunately, the
dash build system does not take into account the ncurses dependency of
libedit. Use pkgconf to get that right.

Fixes:
http://autobuild.buildroot.net/results/801/801e8bc06277978556a301ddf54f609169de37bb/
http://autobuild.buildroot.net/results/123/12367267735b9165afef77289460c247aaad494a/
http://autobuild.buildroot.net/results/aa7/aa7cc7315d778c15c5165ca6423257a84b957482/

Cc: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/dash/dash.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/dash/dash.mk b/package/dash/dash.mk
index 87c9cc9f8b87..2ee292b8d3e7 100644
--- a/package/dash/dash.mk
+++ b/package/dash/dash.mk
@@ -10,8 +10,9 @@ DASH_LICENSE = BSD-3-Clause, GPL-2.0+ (mksignames.c)
 DASH_LICENSE_FILES = COPYING
 
 ifeq ($(BR2_PACKAGE_LIBEDIT),y)
-DASH_DEPENDENCIES += libedit
+DASH_DEPENDENCIES += libedit host-pkgconf
 DASH_CONF_OPTS += --with-libedit
+DASH_CONF_ENV += LIBS=`pkg-config --libs libedit`
 
 # Enable line editing, Emacs style
 define DASH_INSTALL_PROFILE
-- 
2.16.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH master] dash: fix static link with libedit
  2018-03-02  5:22 [Buildroot] [PATCH master] dash: fix static link with libedit Baruch Siach
@ 2018-03-02  7:37 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2018-03-02  7:37 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > libedit is an optional dependency of dash since commit 651af57cf011e
 > (dash: enable line editting if libedit is selected). Unfortunately, the
 > dash build system does not take into account the ncurses dependency of
 > libedit. Use pkgconf to get that right.

 > Fixes:
 > http://autobuild.buildroot.net/results/801/801e8bc06277978556a301ddf54f609169de37bb/
 > http://autobuild.buildroot.net/results/123/12367267735b9165afef77289460c247aaad494a/
 > http://autobuild.buildroot.net/results/aa7/aa7cc7315d778c15c5165ca6423257a84b957482/

 > Cc: Carlos Santos <casantos@datacom.ind.br>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-02  7:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-02  5:22 [Buildroot] [PATCH master] dash: fix static link with libedit Baruch Siach
2018-03-02  7:37 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.