From: "Christian König" <ckoenig.leichtzumerken@gmail.com> To: "Steven Rostedt" <rostedt@goodmis.org>, "Christian König" <christian.koenig@amd.com> Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>, Thomas Gleixner <tglx@linutronix.de>, Stephen Boyd <sboyd@kernel.org>, Guenter Roeck <linux@roeck-us.net>, Anna-Maria Gleixner <anna-maria@linutronix.de>, Andrew Morton <akpm@linux-foundation.org>, Sumit Semwal <sumit.semwal@linaro.org>, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [Linaro-mm-sig] Re: [RFC][PATCH v3 12/33] timers: dma-buf: Use timer_shutdown_sync() before freeing timer Date: Sat, 5 Nov 2022 09:12:37 +0100 [thread overview] Message-ID: <d50ea531-c5cf-81d5-9cc5-0ab92b39232d@gmail.com> (raw) In-Reply-To: <20221104145804.4ec8404e@rorschach.local.home> Am 04.11.22 um 19:58 schrieb Steven Rostedt: > On Fri, 4 Nov 2022 08:15:53 +0100 > Christian König <christian.koenig@amd.com> wrote: > >>> index fb6e0a6ae2c9..5d3e7b503501 100644 >>> --- a/drivers/dma-buf/st-dma-fence.c >>> +++ b/drivers/dma-buf/st-dma-fence.c >>> @@ -412,7 +412,7 @@ static int test_wait_timeout(void *arg) >>> >>> err = 0; >>> err_free: >>> - del_timer_sync(&wt.timer); >>> + timer_shutdown_sync(&wt.timer); >> Mhm, what exactly is the benefit of renaming the function? >> >> Not that I'm against the change, but my thinking is more if there are >> more functions which don't re-arm the time than those which do that then >> why not forbid it in general? > Timers are more often re-armed then not. I had to look for the > locations where del_timer*() was called just before freeing, and other > locations where they are freed later. > > I didn't rename del_timer_sync() to timer_shutdown_sync(), this version > renamed the new "del_timer_shutdown()" to "timer_shutdown_sync()". > > Maybe I'm just confused at what you are asking. No, that explains it a bit better. I was just wondering what exactly the different to del_timer_sync() is. Maybe shorten the summary in the cover letter a bit. The history how this change came to be is not as interesting as why we are changing something. Regards, Christian. > > -- Steve > _______________________________________________ > Linaro-mm-sig mailing list -- linaro-mm-sig@lists.linaro.org > To unsubscribe send an email to linaro-mm-sig-leave@lists.linaro.org
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com> To: "Steven Rostedt" <rostedt@goodmis.org>, "Christian König" <christian.koenig@amd.com> Cc: Stephen Boyd <sboyd@kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sumit Semwal <sumit.semwal@linaro.org>, linaro-mm-sig@lists.linaro.org, Thomas Gleixner <tglx@linutronix.de>, Anna-Maria Gleixner <anna-maria@linutronix.de>, Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, linux-media@vger.kernel.org Subject: Re: [Linaro-mm-sig] Re: [RFC][PATCH v3 12/33] timers: dma-buf: Use timer_shutdown_sync() before freeing timer Date: Sat, 5 Nov 2022 09:12:37 +0100 [thread overview] Message-ID: <d50ea531-c5cf-81d5-9cc5-0ab92b39232d@gmail.com> (raw) In-Reply-To: <20221104145804.4ec8404e@rorschach.local.home> Am 04.11.22 um 19:58 schrieb Steven Rostedt: > On Fri, 4 Nov 2022 08:15:53 +0100 > Christian König <christian.koenig@amd.com> wrote: > >>> index fb6e0a6ae2c9..5d3e7b503501 100644 >>> --- a/drivers/dma-buf/st-dma-fence.c >>> +++ b/drivers/dma-buf/st-dma-fence.c >>> @@ -412,7 +412,7 @@ static int test_wait_timeout(void *arg) >>> >>> err = 0; >>> err_free: >>> - del_timer_sync(&wt.timer); >>> + timer_shutdown_sync(&wt.timer); >> Mhm, what exactly is the benefit of renaming the function? >> >> Not that I'm against the change, but my thinking is more if there are >> more functions which don't re-arm the time than those which do that then >> why not forbid it in general? > Timers are more often re-armed then not. I had to look for the > locations where del_timer*() was called just before freeing, and other > locations where they are freed later. > > I didn't rename del_timer_sync() to timer_shutdown_sync(), this version > renamed the new "del_timer_shutdown()" to "timer_shutdown_sync()". > > Maybe I'm just confused at what you are asking. No, that explains it a bit better. I was just wondering what exactly the different to del_timer_sync() is. Maybe shorten the summary in the cover letter a bit. The history how this change came to be is not as interesting as why we are changing something. Regards, Christian. > > -- Steve > _______________________________________________ > Linaro-mm-sig mailing list -- linaro-mm-sig@lists.linaro.org > To unsubscribe send an email to linaro-mm-sig-leave@lists.linaro.org
next prev parent reply other threads:[~2022-11-05 8:13 UTC|newest] Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-04 5:40 [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers Steven Rostedt 2022-11-04 5:40 ` [Bridge] " Steven Rostedt 2022-11-04 5:40 ` Steven Rostedt 2022-11-04 5:40 ` [Intel-wired-lan] " Steven Rostedt 2022-11-04 5:40 ` [Intel-gfx] " Steven Rostedt 2022-11-04 5:40 ` Steven Rostedt 2022-11-04 5:40 ` [RFC][PATCH v3 01/33] timers: Add timer_shutdown_sync() and timer_shutdown() to be called " Steven Rostedt 2022-11-04 5:40 ` [RFC][PATCH v3 02/33] timers: s390/cmm: Use timer_shutdown_sync() before freeing timer Steven Rostedt 2022-11-04 5:40 ` [RFC][PATCH v3 03/33] timers: sh: " Steven Rostedt 2022-11-04 5:40 ` [RFC][PATCH v3 04/33] timers: block: " Steven Rostedt 2022-11-04 5:56 ` Steven Rostedt 2022-11-04 5:56 ` Steven Rostedt 2022-11-04 5:40 ` [RFC][PATCH v3 05/33] timers: ACPI: " Steven Rostedt 2022-11-07 15:47 ` Jarkko Sakkinen 2022-11-04 5:40 ` [RFC][PATCH v3 06/33] timers: atm: " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 07/33] timers: PM: Use timer_shutdown_sync() Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 08/33] timers: Bluetooth: Use timer_shutdown_sync() before freeing timer Steven Rostedt 2022-11-04 7:18 ` timers: Use timer_shutdown*() before freeing timers bluez.test.bot 2022-11-18 3:51 ` bluez.test.bot 2022-11-18 4:38 ` bluez.test.bot 2022-11-18 5:29 ` bluez.test.bot 2022-11-18 6:34 ` bluez.test.bot 2022-11-18 7:29 ` bluez.test.bot 2022-11-18 8:33 ` bluez.test.bot 2022-11-18 9:30 ` bluez.test.bot 2022-11-19 3:56 ` bluez.test.bot 2022-11-19 5:04 ` bluez.test.bot 2022-11-04 5:41 ` [RFC][PATCH v3 09/33] timers: hangcheck: Use timer_shutdown_sync() before freeing timer Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 10/33] timers: ipmi: " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 11/33] random: use " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 12/33] timers: dma-buf: Use " Steven Rostedt 2022-11-04 5:54 ` Steven Rostedt 2022-11-04 5:54 ` Steven Rostedt 2022-11-04 7:15 ` Christian König 2022-11-04 7:15 ` Christian König 2022-11-04 18:58 ` Steven Rostedt 2022-11-04 18:58 ` Steven Rostedt 2022-11-05 8:12 ` Christian König [this message] 2022-11-05 8:12 ` [Linaro-mm-sig] " Christian König 2022-11-04 5:41 ` [RFC][PATCH v3 13/33] timers: drm: " Steven Rostedt 2022-11-04 5:41 ` [Intel-gfx] " Steven Rostedt 2022-11-04 5:55 ` Steven Rostedt 2022-11-04 5:55 ` Steven Rostedt 2022-11-04 5:55 ` [Intel-gfx] " Steven Rostedt 2022-11-04 8:48 ` Tvrtko Ursulin 2022-11-04 8:48 ` [Intel-gfx] " Tvrtko Ursulin 2022-11-04 8:48 ` Tvrtko Ursulin 2022-11-04 19:02 ` Steven Rostedt 2022-11-04 19:02 ` [Intel-gfx] " Steven Rostedt 2022-11-04 19:02 ` Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 14/33] timers: HID: " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 16/33] timers: mISDN: " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 17/33] timers: leds: " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 18/33] timers: media: " Steven Rostedt 2022-11-04 5:57 ` Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 19/33] timers: net: " Steven Rostedt 2022-11-04 5:41 ` [Bridge] " Steven Rostedt 2022-11-04 5:41 ` Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 20/33] timers: usb: " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 21/33] timers: cgroup: " Steven Rostedt 2022-11-04 5:41 ` Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 22/33] timers: workqueue: " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 23/33] timers: nfc: pn533: " Steven Rostedt 2022-11-04 15:46 ` Krzysztof Kozlowski 2022-11-05 5:25 ` Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 24/33] timers: pcmcia: " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 25/33] timers: scsi: Use timer_shutdown_sync() and timer_shutdown() " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 26/33] timers: tty: Use timer_shutdown_sync() " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 27/33] timers: ext4: " Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 28/33] timers: fs/nilfs2: " Steven Rostedt 2022-11-04 5:41 ` Steven Rostedt 2022-11-04 6:57 ` Ryusuke Konishi 2022-11-04 6:57 ` Ryusuke Konishi 2022-11-04 18:54 ` Steven Rostedt 2022-11-04 18:54 ` Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 29/33] timers: ALSA: " Steven Rostedt 2022-11-04 5:41 ` Steven Rostedt 2022-11-04 8:11 ` Takashi Iwai 2022-11-04 8:11 ` Takashi Iwai 2022-11-04 5:41 ` [RFC][PATCH v3 30/33] timers: jbd2: Use timer_shutdown() " Steven Rostedt 2022-11-07 12:37 ` Jan Kara 2022-11-04 5:41 ` [RFC][PATCH v3 31/33] timers: sched/psi: Use timer_shutdown_sync() " Steven Rostedt 2022-11-04 20:11 ` Johannes Weiner 2022-11-04 20:29 ` Suren Baghdasaryan 2022-11-04 5:41 ` [RFC][PATCH v3 32/33] timers: x86/mce: Use __init_timer() for resetting timers Steven Rostedt 2022-11-04 5:41 ` [RFC][PATCH v3 33/33] timers: Expand DEBUG_OBJECTS_TIMER to check if it ever was used Steven Rostedt 2022-11-04 17:00 ` [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers Linus Torvalds 2022-11-04 17:00 ` [Bridge] " Linus Torvalds 2022-11-04 17:00 ` Linus Torvalds 2022-11-04 17:00 ` Linus Torvalds 2022-11-04 17:00 ` [Intel-wired-lan] " Linus Torvalds 2022-11-04 17:00 ` [Intel-gfx] " Linus Torvalds 2022-11-04 19:22 ` Guenter Roeck 2022-11-04 19:22 ` [Bridge] " Guenter Roeck 2022-11-04 19:22 ` Guenter Roeck 2022-11-04 19:22 ` [Intel-wired-lan] " Guenter Roeck 2022-11-04 19:22 ` [Intel-gfx] " Guenter Roeck 2022-11-04 19:22 ` Guenter Roeck 2022-11-04 19:42 ` Steven Rostedt 2022-11-04 19:42 ` [Bridge] " Steven Rostedt 2022-11-04 19:42 ` Steven Rostedt 2022-11-04 19:42 ` [Intel-wired-lan] " Steven Rostedt 2022-11-04 19:42 ` [Intel-gfx] " Steven Rostedt 2022-11-04 19:42 ` Steven Rostedt 2022-11-04 19:50 ` Linus Torvalds 2022-11-04 19:50 ` [Bridge] " Linus Torvalds 2022-11-04 19:50 ` Linus Torvalds 2022-11-04 19:50 ` [Intel-wired-lan] " Linus Torvalds 2022-11-04 19:50 ` [Intel-gfx] " Linus Torvalds 2022-11-04 19:50 ` Linus Torvalds 2022-11-04 20:38 ` Steven Rostedt 2022-11-04 20:38 ` [Bridge] " Steven Rostedt 2022-11-04 20:38 ` Steven Rostedt 2022-11-04 20:38 ` [Intel-wired-lan] " Steven Rostedt 2022-11-04 20:38 ` [Intel-gfx] " Steven Rostedt 2022-11-04 20:38 ` Steven Rostedt 2022-11-04 20:42 ` Guenter Roeck 2022-11-04 20:42 ` [Bridge] " Guenter Roeck 2022-11-04 20:42 ` Guenter Roeck 2022-11-04 20:42 ` Guenter Roeck 2022-11-04 20:42 ` [Intel-wired-lan] " Guenter Roeck 2022-11-04 20:42 ` [Intel-gfx] " Guenter Roeck 2022-11-04 20:41 ` Guenter Roeck 2022-11-04 20:41 ` [Bridge] " Guenter Roeck 2022-11-04 20:41 ` Guenter Roeck 2022-11-04 20:41 ` [Intel-wired-lan] " Guenter Roeck 2022-11-04 20:41 ` [Intel-gfx] " Guenter Roeck 2022-11-04 20:41 ` Guenter Roeck 2022-11-04 23:34 ` Guenter Roeck 2022-11-04 23:34 ` [Bridge] " Guenter Roeck 2022-11-04 23:34 ` Guenter Roeck 2022-11-04 23:34 ` [Intel-wired-lan] " Guenter Roeck 2022-11-04 23:34 ` [Intel-gfx] " Guenter Roeck 2022-11-04 23:34 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d50ea531-c5cf-81d5-9cc5-0ab92b39232d@gmail.com \ --to=ckoenig.leichtzumerken@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=anna-maria@linutronix.de \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linaro-mm-sig@lists.linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=rostedt@goodmis.org \ --cc=sboyd@kernel.org \ --cc=sumit.semwal@linaro.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.