From: Harry Wentland <hwentlan@amd.com> To: Mario Kleiner <mario.kleiner.de@gmail.com>, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Cc: alexander.deucher@amd.com, mario.kleiner.de@gmail.de, Martin Leung <martin.leung@amd.com> Subject: Re: [PATCH 1/2] drm/amd/display: Reorder detect_edp_sink_caps before link settings read. Date: Thu, 9 Jan 2020 13:40:57 -0500 [thread overview] Message-ID: <d54ab31d-1821-fe40-2dd7-c6b35b42547f@amd.com> (raw) In-Reply-To: <20200109152028.28260-2-mario.kleiner.de@gmail.com> On 2020-01-09 10:20 a.m., Mario Kleiner wrote: > read_current_link_settings_on_detect() on eDP 1.4+ may use the > edp_supported_link_rates table which is set up by > detect_edp_sink_caps(), so that function needs to be called first. > > Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com> > Cc: Martin Leung <martin.leung@amd.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> This also fixes our assumption that retrieve_link_cap is the first DPCD reads we perform during detection. Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > index cef8c1ba9797..5ea4a1675259 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > @@ -817,8 +817,8 @@ static bool dc_link_detect_helper(struct dc_link *link, > } > > case SIGNAL_TYPE_EDP: { > - read_current_link_settings_on_detect(link); > detect_edp_sink_caps(link); > + read_current_link_settings_on_detect(link); > sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C_OVER_AUX; > sink_caps.signal = SIGNAL_TYPE_EDP; > break; > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Harry Wentland <hwentlan@amd.com> To: Mario Kleiner <mario.kleiner.de@gmail.com>, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Cc: alexander.deucher@amd.com, mario.kleiner.de@gmail.de, Martin Leung <martin.leung@amd.com> Subject: Re: [PATCH 1/2] drm/amd/display: Reorder detect_edp_sink_caps before link settings read. Date: Thu, 9 Jan 2020 13:40:57 -0500 [thread overview] Message-ID: <d54ab31d-1821-fe40-2dd7-c6b35b42547f@amd.com> (raw) In-Reply-To: <20200109152028.28260-2-mario.kleiner.de@gmail.com> On 2020-01-09 10:20 a.m., Mario Kleiner wrote: > read_current_link_settings_on_detect() on eDP 1.4+ may use the > edp_supported_link_rates table which is set up by > detect_edp_sink_caps(), so that function needs to be called first. > > Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com> > Cc: Martin Leung <martin.leung@amd.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> This also fixes our assumption that retrieve_link_cap is the first DPCD reads we perform during detection. Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > index cef8c1ba9797..5ea4a1675259 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > @@ -817,8 +817,8 @@ static bool dc_link_detect_helper(struct dc_link *link, > } > > case SIGNAL_TYPE_EDP: { > - read_current_link_settings_on_detect(link); > detect_edp_sink_caps(link); > + read_current_link_settings_on_detect(link); > sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C_OVER_AUX; > sink_caps.signal = SIGNAL_TYPE_EDP; > break; > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-01-09 18:41 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-09 15:20 Some eDP fixes/improvements Mario Kleiner 2020-01-09 15:20 ` Mario Kleiner 2020-01-09 15:20 ` [PATCH 1/2] drm/amd/display: Reorder detect_edp_sink_caps before link settings read Mario Kleiner 2020-01-09 15:20 ` Mario Kleiner 2020-01-09 18:40 ` Harry Wentland [this message] 2020-01-09 18:40 ` Harry Wentland 2020-01-11 0:17 ` Alex Deucher 2020-01-11 0:17 ` Alex Deucher 2020-01-09 15:20 ` [PATCH 2/2] drm/amd/display: Allow current eDP link settings to override verified ones Mario Kleiner 2020-01-09 15:20 ` Mario Kleiner 2020-01-09 18:44 ` Harry Wentland 2020-01-09 18:44 ` Harry Wentland 2020-01-09 21:13 ` Mario Kleiner 2020-01-09 21:13 ` Mario Kleiner 2020-01-09 21:26 ` Harry Wentland 2020-01-09 21:26 ` Harry Wentland 2020-02-27 19:11 ` Mario Kleiner 2020-02-27 19:11 ` Mario Kleiner 2020-02-28 21:41 ` Mario Kleiner 2020-02-28 21:41 ` Mario Kleiner 2020-01-11 11:41 ` Some eDP fixes/improvements Timo Aaltonen 2020-01-11 11:41 ` Timo Aaltonen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d54ab31d-1821-fe40-2dd7-c6b35b42547f@amd.com \ --to=hwentlan@amd.com \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=mario.kleiner.de@gmail.com \ --cc=mario.kleiner.de@gmail.de \ --cc=martin.leung@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.