From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>, <misael.lopez@ti.com>
Subject: Re: [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device registration
Date: Fri, 19 Aug 2016 12:54:28 +0300 [thread overview]
Message-ID: <d553cc24-f5b5-3b8a-d187-53fdf8d978ae@ti.com> (raw)
In-Reply-To: <20160819085404.GI1041@n2100.armlinux.org.uk>
On 08/19/16 11:54, Russell King - ARM Linux wrote:
> On Fri, Aug 19, 2016 at 09:34:24AM +0300, Peter Ujfalusi wrote:
>> The dmic-codec was registered within the platform_driver's probe function,
>> which can cause deferred probe to run in loops as reported and analyzed by
>> Russell King.
>>
>> Use module_init/exit in the driver and handle the dmic-codec device
>> registration and removal at that level instead of the platform_driver
>> probe/remove.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Reported-by: Russell King <linux@arm.linux.org.uk>
>
> I think this address came from memory... it's certainly not the one that
> I'm using today. ;)
I'm really sorry. I have one txt file where I store e-mail addresses when I'm
lazy to look them up in my mailbox. txt updated.
Mark: can you fix Russell's e-mail addrress to:
linux@armlinux.org.uk
Or I can resend the patch.
>
>> ---
>
> This certainly fixes the problem:
>
> VUSB: disabling
> mmcblk0: mmc0:0002 00000 972 MiB
> ALSA device list:
> mmcblk0: p1 p2
> No soundcards found.
> omap-abe-twl6040 sound: ASoC: CPU DAI (null) not registered
> omap-abe-twl6040 sound: snd_soc_register_card() failed: -517
> Waiting 2 sec before mounting root device...
> EXT4-fs (mmcblk0p2): mounting ext3 file system using the ext4 subsystem
> EXT4-fs (mmcblk0p2): warning: maximal mount count reached, running e2fsck is recommended
>
> and allows booting to continue. Thanks.
>
> Tested-by: Russell King <rmk+kernel@armlinux.org.uk>
>
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: alsa-devel@alsa-project.org, Tony Lindgren <tony@atomide.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
misael.lopez@ti.com
Subject: Re: [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device registration
Date: Fri, 19 Aug 2016 12:54:28 +0300 [thread overview]
Message-ID: <d553cc24-f5b5-3b8a-d187-53fdf8d978ae@ti.com> (raw)
In-Reply-To: <20160819085404.GI1041@n2100.armlinux.org.uk>
On 08/19/16 11:54, Russell King - ARM Linux wrote:
> On Fri, Aug 19, 2016 at 09:34:24AM +0300, Peter Ujfalusi wrote:
>> The dmic-codec was registered within the platform_driver's probe function,
>> which can cause deferred probe to run in loops as reported and analyzed by
>> Russell King.
>>
>> Use module_init/exit in the driver and handle the dmic-codec device
>> registration and removal at that level instead of the platform_driver
>> probe/remove.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Reported-by: Russell King <linux@arm.linux.org.uk>
>
> I think this address came from memory... it's certainly not the one that
> I'm using today. ;)
I'm really sorry. I have one txt file where I store e-mail addresses when I'm
lazy to look them up in my mailbox. txt updated.
Mark: can you fix Russell's e-mail addrress to:
linux@armlinux.org.uk
Or I can resend the patch.
>
>> ---
>
> This certainly fixes the problem:
>
> VUSB: disabling
> mmcblk0: mmc0:0002 00000 972 MiB
> ALSA device list:
> mmcblk0: p1 p2
> No soundcards found.
> omap-abe-twl6040 sound: ASoC: CPU DAI (null) not registered
> omap-abe-twl6040 sound: snd_soc_register_card() failed: -517
> Waiting 2 sec before mounting root device...
> EXT4-fs (mmcblk0p2): mounting ext3 file system using the ext4 subsystem
> EXT4-fs (mmcblk0p2): warning: maximal mount count reached, running e2fsck is recommended
>
> and allows booting to continue. Thanks.
>
> Tested-by: Russell King <rmk+kernel@armlinux.org.uk>
>
--
Péter
next prev parent reply other threads:[~2016-08-19 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 6:34 [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device registration Peter Ujfalusi
2016-08-19 6:34 ` Peter Ujfalusi
2016-08-19 8:54 ` Russell King - ARM Linux
2016-08-19 9:54 ` Peter Ujfalusi [this message]
2016-08-19 9:54 ` Peter Ujfalusi
2016-08-19 15:10 ` Applied "ASoC: omap-abe-twl6040: Correct dmic-codec device registration" to the asoc tree Mark Brown
2016-08-19 15:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d553cc24-f5b5-3b8a-d187-53fdf8d978ae@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=misael.lopez@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.