From: "Blaž Hrastnik" <blaz@mxxn.io>
To: "Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Cc: "David Bartley" <andareed@gmail.com>
Subject: Re: hwmon: (nct6683) Support ASRock boards.
Date: Tue, 19 Jan 2021 14:15:58 +0900 [thread overview]
Message-ID: <d5630b5e-52ec-4fc7-b8f3-ac219d0bfbbb@www.fastmail.com> (raw)
In-Reply-To: <b08d641c-3fb5-4845-85f7-e1753149cd7d@www.fastmail.com>
(cc-ing David Bartley, who wrote the MSI patch)
I had a follow-up question: I noticed that support for MSI was added in
December, but there's this conditional that wasn't changed:
/* Only update pwm values for Mitac boards */
if (data->customer_id == NCT6683_CUSTOMER_ID_MITAC)
return attr->mode | S_IWUSR;
Should this continue to only apply for Mitac boards, or should it be changed to
!= NCT6683_CUSTOMER_ID_INTEL?
Blaž
next prev parent reply other threads:[~2021-01-19 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 5:12 hwmon: (nct6683) Support ASRock boards Blaž Hrastnik
2021-01-19 5:15 ` Blaž Hrastnik [this message]
2021-01-19 5:49 ` Guenter Roeck
2021-01-21 19:25 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5630b5e-52ec-4fc7-b8f3-ac219d0bfbbb@www.fastmail.com \
--to=blaz@mxxn.io \
--cc=andareed@gmail.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.