* [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L
@ 2022-05-02 9:25 ` Hector Martin
0 siblings, 0 replies; 8+ messages in thread
From: Hector Martin @ 2022-05-02 9:25 UTC (permalink / raw)
To: Krzysztof Kozlowski, Greg Kroah-Hartman
Cc: Sven Peter, Alyssa Rosenzweig, Alim Akhtar, linux-arm-kernel,
linux-samsung-soc, linux-serial, linux-kernel, Hector Martin
We were restoring the IRQ masks then clearing them again, because
ucon_mask wasn't set properly. Adding that makes suspend/resume
work as intended.
Signed-off-by: Hector Martin <marcan@marcan.st>
---
drivers/tty/serial/samsung_tty.c | 1 +
include/linux/serial_s3c.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 12bf6b18847f..88a0b01ee9ab 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2840,6 +2840,7 @@ static const struct s3c24xx_serial_drv_data s5l_serial_drv_data = {
.num_clks = 1,
.clksel_mask = 0,
.clksel_shift = 0,
+ .ucon_mask = APPLE_S5L_UCON_MASK,
},
.def_cfg = {
.ucon = APPLE_S5L_UCON_DEFAULT,
diff --git a/include/linux/serial_s3c.h b/include/linux/serial_s3c.h
index f6c3323fc4c5..dec15f5b3dec 100644
--- a/include/linux/serial_s3c.h
+++ b/include/linux/serial_s3c.h
@@ -256,6 +256,9 @@
#define APPLE_S5L_UCON_DEFAULT (S3C2410_UCON_TXIRQMODE | \
S3C2410_UCON_RXIRQMODE | \
S3C2410_UCON_RXFIFO_TOI)
+#define APPLE_S5L_UCON_MASK (APPLE_S5L_UCON_RXTO_ENA_MSK | \
+ APPLE_S5L_UCON_RXTHRESH_ENA_MSK | \
+ APPLE_S5L_UCON_TXTHRESH_ENA_MSK)
#define APPLE_S5L_UTRSTAT_RXTHRESH (1<<4)
#define APPLE_S5L_UTRSTAT_TXTHRESH (1<<5)
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L
@ 2022-05-02 9:25 ` Hector Martin
0 siblings, 0 replies; 8+ messages in thread
From: Hector Martin @ 2022-05-02 9:25 UTC (permalink / raw)
To: Krzysztof Kozlowski, Greg Kroah-Hartman
Cc: Sven Peter, Alyssa Rosenzweig, Alim Akhtar, linux-arm-kernel,
linux-samsung-soc, linux-serial, linux-kernel, Hector Martin
We were restoring the IRQ masks then clearing them again, because
ucon_mask wasn't set properly. Adding that makes suspend/resume
work as intended.
Signed-off-by: Hector Martin <marcan@marcan.st>
---
drivers/tty/serial/samsung_tty.c | 1 +
include/linux/serial_s3c.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 12bf6b18847f..88a0b01ee9ab 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2840,6 +2840,7 @@ static const struct s3c24xx_serial_drv_data s5l_serial_drv_data = {
.num_clks = 1,
.clksel_mask = 0,
.clksel_shift = 0,
+ .ucon_mask = APPLE_S5L_UCON_MASK,
},
.def_cfg = {
.ucon = APPLE_S5L_UCON_DEFAULT,
diff --git a/include/linux/serial_s3c.h b/include/linux/serial_s3c.h
index f6c3323fc4c5..dec15f5b3dec 100644
--- a/include/linux/serial_s3c.h
+++ b/include/linux/serial_s3c.h
@@ -256,6 +256,9 @@
#define APPLE_S5L_UCON_DEFAULT (S3C2410_UCON_TXIRQMODE | \
S3C2410_UCON_RXIRQMODE | \
S3C2410_UCON_RXFIFO_TOI)
+#define APPLE_S5L_UCON_MASK (APPLE_S5L_UCON_RXTO_ENA_MSK | \
+ APPLE_S5L_UCON_RXTHRESH_ENA_MSK | \
+ APPLE_S5L_UCON_TXTHRESH_ENA_MSK)
#define APPLE_S5L_UTRSTAT_RXTHRESH (1<<4)
#define APPLE_S5L_UTRSTAT_TXTHRESH (1<<5)
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L
2022-05-02 9:25 ` Hector Martin
@ 2022-05-02 11:44 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2022-05-02 11:44 UTC (permalink / raw)
To: Hector Martin
Cc: Krzysztof Kozlowski, Sven Peter, Alyssa Rosenzweig, Alim Akhtar,
linux-arm-kernel, linux-samsung-soc, linux-serial, linux-kernel
On Mon, May 02, 2022 at 06:25:05PM +0900, Hector Martin wrote:
> We were restoring the IRQ masks then clearing them again, because
> ucon_mask wasn't set properly. Adding that makes suspend/resume
> work as intended.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
> drivers/tty/serial/samsung_tty.c | 1 +
> include/linux/serial_s3c.h | 3 +++
> 2 files changed, 4 insertions(+)
Does this fix a specific older commit?
And should it be backported to older stable kernels?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L
@ 2022-05-02 11:44 ` Greg Kroah-Hartman
0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2022-05-02 11:44 UTC (permalink / raw)
To: Hector Martin
Cc: Krzysztof Kozlowski, Sven Peter, Alyssa Rosenzweig, Alim Akhtar,
linux-arm-kernel, linux-samsung-soc, linux-serial, linux-kernel
On Mon, May 02, 2022 at 06:25:05PM +0900, Hector Martin wrote:
> We were restoring the IRQ masks then clearing them again, because
> ucon_mask wasn't set properly. Adding that makes suspend/resume
> work as intended.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
> drivers/tty/serial/samsung_tty.c | 1 +
> include/linux/serial_s3c.h | 3 +++
> 2 files changed, 4 insertions(+)
Does this fix a specific older commit?
And should it be backported to older stable kernels?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L
2022-05-02 11:44 ` Greg Kroah-Hartman
@ 2022-05-02 12:39 ` Hector Martin
-1 siblings, 0 replies; 8+ messages in thread
From: Hector Martin @ 2022-05-02 12:39 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Krzysztof Kozlowski, Sven Peter, Alyssa Rosenzweig, Alim Akhtar,
linux-arm-kernel, linux-samsung-soc, linux-serial, linux-kernel
On 02/05/2022 20.44, Greg Kroah-Hartman wrote:
> On Mon, May 02, 2022 at 06:25:05PM +0900, Hector Martin wrote:
>> We were restoring the IRQ masks then clearing them again, because
>> ucon_mask wasn't set properly. Adding that makes suspend/resume
>> work as intended.
>>
>> Signed-off-by: Hector Martin <marcan@marcan.st>
>> ---
>> drivers/tty/serial/samsung_tty.c | 1 +
>> include/linux/serial_s3c.h | 3 +++
>> 2 files changed, 4 insertions(+)
>
> Does this fix a specific older commit?
>
> And should it be backported to older stable kernels?
It does fix the commit that introduced this device support in general; I
can add a Fixes line for that. I don't think anyone cares about
backporting though, since there are other fairly critical devices that
don't have support outright and there's still work to do before
suspend/resume is generally usable on these machines.
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L
@ 2022-05-02 12:39 ` Hector Martin
0 siblings, 0 replies; 8+ messages in thread
From: Hector Martin @ 2022-05-02 12:39 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Krzysztof Kozlowski, Sven Peter, Alyssa Rosenzweig, Alim Akhtar,
linux-arm-kernel, linux-samsung-soc, linux-serial, linux-kernel
On 02/05/2022 20.44, Greg Kroah-Hartman wrote:
> On Mon, May 02, 2022 at 06:25:05PM +0900, Hector Martin wrote:
>> We were restoring the IRQ masks then clearing them again, because
>> ucon_mask wasn't set properly. Adding that makes suspend/resume
>> work as intended.
>>
>> Signed-off-by: Hector Martin <marcan@marcan.st>
>> ---
>> drivers/tty/serial/samsung_tty.c | 1 +
>> include/linux/serial_s3c.h | 3 +++
>> 2 files changed, 4 insertions(+)
>
> Does this fix a specific older commit?
>
> And should it be backported to older stable kernels?
It does fix the commit that introduced this device support in general; I
can add a Fixes line for that. I don't think anyone cares about
backporting though, since there are other fairly critical devices that
don't have support outright and there's still work to do before
suspend/resume is generally usable on these machines.
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L
2022-05-02 12:39 ` Hector Martin
@ 2022-05-02 20:22 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-02 20:22 UTC (permalink / raw)
To: Hector Martin, Greg Kroah-Hartman
Cc: Sven Peter, Alyssa Rosenzweig, Alim Akhtar, linux-arm-kernel,
linux-samsung-soc, linux-serial, linux-kernel
On 02/05/2022 14:39, Hector Martin wrote:
> On 02/05/2022 20.44, Greg Kroah-Hartman wrote:
>> On Mon, May 02, 2022 at 06:25:05PM +0900, Hector Martin wrote:
>>> We were restoring the IRQ masks then clearing them again, because
>>> ucon_mask wasn't set properly. Adding that makes suspend/resume
>>> work as intended.
>>>
>>> Signed-off-by: Hector Martin <marcan@marcan.st>
>>> ---
>>> drivers/tty/serial/samsung_tty.c | 1 +
>>> include/linux/serial_s3c.h | 3 +++
>>> 2 files changed, 4 insertions(+)
>>
>> Does this fix a specific older commit?
>>
>> And should it be backported to older stable kernels?
>
> It does fix the commit that introduced this device support in general; I
> can add a Fixes line for that. I don't think anyone cares about
> backporting though, since there are other fairly critical devices that
> don't have support outright and there's still work to do before
> suspend/resume is generally usable on these machines.
Then please add only Fixes tag.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L
@ 2022-05-02 20:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-02 20:22 UTC (permalink / raw)
To: Hector Martin, Greg Kroah-Hartman
Cc: Sven Peter, Alyssa Rosenzweig, Alim Akhtar, linux-arm-kernel,
linux-samsung-soc, linux-serial, linux-kernel
On 02/05/2022 14:39, Hector Martin wrote:
> On 02/05/2022 20.44, Greg Kroah-Hartman wrote:
>> On Mon, May 02, 2022 at 06:25:05PM +0900, Hector Martin wrote:
>>> We were restoring the IRQ masks then clearing them again, because
>>> ucon_mask wasn't set properly. Adding that makes suspend/resume
>>> work as intended.
>>>
>>> Signed-off-by: Hector Martin <marcan@marcan.st>
>>> ---
>>> drivers/tty/serial/samsung_tty.c | 1 +
>>> include/linux/serial_s3c.h | 3 +++
>>> 2 files changed, 4 insertions(+)
>>
>> Does this fix a specific older commit?
>>
>> And should it be backported to older stable kernels?
>
> It does fix the commit that introduced this device support in general; I
> can add a Fixes line for that. I don't think anyone cares about
> backporting though, since there are other fairly critical devices that
> don't have support outright and there's still work to do before
> suspend/resume is generally usable on these machines.
Then please add only Fixes tag.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-02 20:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02 9:25 [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L Hector Martin
2022-05-02 9:25 ` Hector Martin
2022-05-02 11:44 ` Greg Kroah-Hartman
2022-05-02 11:44 ` Greg Kroah-Hartman
2022-05-02 12:39 ` Hector Martin
2022-05-02 12:39 ` Hector Martin
2022-05-02 20:22 ` Krzysztof Kozlowski
2022-05-02 20:22 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.