All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: skip TV/CV in display parsing
@ 2016-08-24 17:06 Alex Deucher
  2016-08-24 17:44   ` Christian König
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2016-08-24 17:06 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alex Deucher, stable

No asics supported by amdgpu support analog TV.

Workaround for bug:
https://bugs.freedesktop.org/show_bug.cgi?id=97460

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
index 1514223..fe872b8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
@@ -321,6 +321,13 @@ bool amdgpu_atombios_get_connector_info_from_object_table(struct amdgpu_device *
 			    (le16_to_cpu(path->usConnObjectId) &
 			     OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT;
 
+			/* Skip TV/CV support */
+			if ((le16_to_cpu(path->usDeviceTag) ==
+			     ATOM_DEVICE_TV1_SUPPORT) ||
+			    (le16_to_cpu(path->usDeviceTag) ==
+			     ATOM_DEVICE_CV_SUPPORT))
+				continue;
+
 			if (con_obj_id >= ARRAY_SIZE(object_connector_convert)) {
 				DRM_ERROR("invalid con_obj_id %d for device tag 0x%04x\n",
 					  con_obj_id, le16_to_cpu(path->usDeviceTag));
-- 
2.5.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: skip TV/CV in display parsing
@ 2016-08-24 17:44   ` Christian König
  0 siblings, 0 replies; 3+ messages in thread
From: Christian König @ 2016-08-24 17:44 UTC (permalink / raw)
  To: Alex Deucher, amd-gfx; +Cc: Alex Deucher, stable

Am 24.08.2016 um 19:06 schrieb Alex Deucher:
> No asics supported by amdgpu support analog TV.
>
> Workaround for bug:
> https://bugs.freedesktop.org/show_bug.cgi?id=97460
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Why in the world would any BIOS amdgpu has to deal with have such entries?

Anyway patch is Reviewed-by: Christian König <christian.koenig@amd.com>.

> Cc: stable@vger.kernel.org
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> index 1514223..fe872b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> @@ -321,6 +321,13 @@ bool amdgpu_atombios_get_connector_info_from_object_table(struct amdgpu_device *
>   			    (le16_to_cpu(path->usConnObjectId) &
>   			     OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT;
>   
> +			/* Skip TV/CV support */
> +			if ((le16_to_cpu(path->usDeviceTag) ==
> +			     ATOM_DEVICE_TV1_SUPPORT) ||
> +			    (le16_to_cpu(path->usDeviceTag) ==
> +			     ATOM_DEVICE_CV_SUPPORT))
> +				continue;
> +
>   			if (con_obj_id >= ARRAY_SIZE(object_connector_convert)) {
>   				DRM_ERROR("invalid con_obj_id %d for device tag 0x%04x\n",
>   					  con_obj_id, le16_to_cpu(path->usDeviceTag));



^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: skip TV/CV in display parsing
@ 2016-08-24 17:44   ` Christian König
  0 siblings, 0 replies; 3+ messages in thread
From: Christian König @ 2016-08-24 17:44 UTC (permalink / raw)
  To: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: Alex Deucher, stable-u79uwXL29TY76Z2rM5mHXA

Am 24.08.2016 um 19:06 schrieb Alex Deucher:
> No asics supported by amdgpu support analog TV.
>
> Workaround for bug:
> https://bugs.freedesktop.org/show_bug.cgi?id=97460
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Why in the world would any BIOS amdgpu has to deal with have such entries?

Anyway patch is Reviewed-by: Christian König <christian.koenig@amd.com>.

> Cc: stable@vger.kernel.org
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> index 1514223..fe872b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> @@ -321,6 +321,13 @@ bool amdgpu_atombios_get_connector_info_from_object_table(struct amdgpu_device *
>   			    (le16_to_cpu(path->usConnObjectId) &
>   			     OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT;
>   
> +			/* Skip TV/CV support */
> +			if ((le16_to_cpu(path->usDeviceTag) ==
> +			     ATOM_DEVICE_TV1_SUPPORT) ||
> +			    (le16_to_cpu(path->usDeviceTag) ==
> +			     ATOM_DEVICE_CV_SUPPORT))
> +				continue;
> +
>   			if (con_obj_id >= ARRAY_SIZE(object_connector_convert)) {
>   				DRM_ERROR("invalid con_obj_id %d for device tag 0x%04x\n",
>   					  con_obj_id, le16_to_cpu(path->usDeviceTag));


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-24 17:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-24 17:06 [PATCH] drm/amdgpu: skip TV/CV in display parsing Alex Deucher
2016-08-24 17:44 ` Christian König
2016-08-24 17:44   ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.