* [RFC PATCH lttng-tools] RFC: Enforce DL_LIBS value instead of hard coded -ldl
[not found] <20190215195217.5012-1-ylamarre@efficios.com>
@ 2019-02-15 19:52 ` Yannick Lamarre
2019-02-15 20:14 ` [RFC PATCH lttng-tools] RFC: Add POPT_CFLAGS to lttng_CFLAGS Michael Jeanson
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Yannick Lamarre @ 2019-02-15 19:52 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
Generated makefiles would ignore DL_LIBS value selected by configure
script and use the hard coded value -ldl. Generated makefiles will
now use DL_LIBS.
Refs: #1165
Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
---
src/common/testpoint/Makefile.am | 2 +-
tests/regression/ust/baddr-statedump/Makefile.am | 2 +-
tests/regression/ust/ust-dl/Makefile.am | 2 +-
tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/common/testpoint/Makefile.am b/src/common/testpoint/Makefile.am
index 5c15725e..a2f9d407 100644
--- a/src/common/testpoint/Makefile.am
+++ b/src/common/testpoint/Makefile.am
@@ -1,4 +1,4 @@
noinst_LTLIBRARIES = libtestpoint.la
libtestpoint_la_SOURCES = testpoint.h testpoint.c
-libtestpoint_la_LIBADD = -ldl
+libtestpoint_la_LIBADD = $(DL_LIBS)
diff --git a/tests/regression/ust/baddr-statedump/Makefile.am b/tests/regression/ust/baddr-statedump/Makefile.am
index bf327179..bf51f948 100644
--- a/tests/regression/ust/baddr-statedump/Makefile.am
+++ b/tests/regression/ust/baddr-statedump/Makefile.am
@@ -6,7 +6,7 @@ AM_CPPFLAGS += -I$(srcdir) -g
noinst_PROGRAMS = prog
prog_SOURCES = prog.c tp.c tp.h
-prog_LDADD = -llttng-ust -ldl
+prog_LDADD = -llttng-ust $(DL_LIBS)
noinst_SCRIPTS = test_baddr-statedump test_baddr-statedump.py
EXTRA_DIST = test_baddr-statedump test_baddr-statedump.py
diff --git a/tests/regression/ust/ust-dl/Makefile.am b/tests/regression/ust/ust-dl/Makefile.am
index 9889e85a..c51e072f 100644
--- a/tests/regression/ust/ust-dl/Makefile.am
+++ b/tests/regression/ust/ust-dl/Makefile.am
@@ -19,7 +19,7 @@ AM_CPPFLAGS += -I$(srcdir) -g
noinst_PROGRAMS = prog
prog_SOURCES = prog.c
-prog_LDADD = -ldl
+prog_LDADD = $(DL_LIBS)
noinst_LTLIBRARIES = libzzz.la libbar.la libfoo.la libtp.la
diff --git a/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am b/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am
index e86939b4..d79ce0ea 100644
--- a/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am
+++ b/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am
@@ -3,7 +3,7 @@ BUILT_SOURCES = foobar_provider.h
noinst_PROGRAMS = userspace-probe-sdt-binary
userspace_probe_sdt_binary_SOURCES = userspace-probe-sdt-binary.c sema.h sema.c
-userspace_probe_sdt_binary_LDADD = foobar_provider.o libfoo.la libbar.la -ldl
+userspace_probe_sdt_binary_LDADD = foobar_provider.o libfoo.la libbar.la $(DL_LIBS)
userspace_probe_sdt_binary_CFLAGS = -I$(abs_builddir)
nodist_userspace_probe_sdt_binary_SOURCES = $(abs_builddir)/foobar_provider.h
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RFC PATCH lttng-tools] RFC: Add POPT_CFLAGS to lttng_CFLAGS
[not found] <20190215195217.5012-1-ylamarre@efficios.com>
2019-02-15 19:52 ` [RFC PATCH lttng-tools] RFC: Enforce DL_LIBS value instead of hard coded -ldl Yannick Lamarre
@ 2019-02-15 20:14 ` Michael Jeanson
2019-02-18 17:05 ` [PATCH lttng-tools v2 1/2] " Yannick Lamarre
[not found] ` <20190218170528.18823-1-ylamarre@efficios.com>
3 siblings, 0 replies; 8+ messages in thread
From: Michael Jeanson @ 2019-02-15 20:14 UTC (permalink / raw)
To: Yannick Lamarre, lttng-dev; +Cc: jgalar
On 2019-02-15 2:52 p.m., Yannick Lamarre wrote:
> The generated makefile was ignoring POPT_CFLAGS when compiling
> lttng, but was adding POPT_LIBS to lttng_LDADD. With this commit,
> make now honors both settings for applications and tests.
>
> Fixes: #1165
>
> Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
> ---
> src/bin/lttng/Makefile.am | 2 ++
> tests/regression/kernel/Makefile.am | 2 +-
> tests/regression/ust/multi-lib/Makefile.am | 8 ++++----
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/src/bin/lttng/Makefile.am b/src/bin/lttng/Makefile.am
> index b0e1247d..62ae0593 100644
> --- a/src/bin/lttng/Makefile.am
> +++ b/src/bin/lttng/Makefile.am
> @@ -28,6 +28,8 @@ lttng_SOURCES = command.h conf.c conf.h commands/start.c \
> commands/disable_rotation.c \
> utils.c utils.h lttng.c
>
> +lttng_CFLAGS = $(AM_CFLAGS) $(POPT_CFLAGS)
By convention AM_CFLAGS should come last, it also has to do with priority.
> +
> lttng_LDADD = $(top_builddir)/src/lib/lttng-ctl/liblttng-ctl.la \
> $(top_builddir)/src/common/libcommon.la \
> $(top_builddir)/src/common/config/libconfig.la \
> diff --git a/tests/regression/kernel/Makefile.am b/tests/regression/kernel/Makefile.am
> index a787e4fa..3ab6d75b 100644
> --- a/tests/regression/kernel/Makefile.am
> +++ b/tests/regression/kernel/Makefile.am
> @@ -7,7 +7,7 @@ EXTRA_DIST = test_event_basic test_all_events test_syscall \
> noinst_PROGRAMS = select_poll_epoll
> select_poll_epoll_SOURCES = select_poll_epoll.c
> select_poll_epoll_LDADD = $(POPT_LIBS)
> -select_poll_epoll_CFLAGS = -fno-stack-protector -D_FORTIFY_SOURCE=0 $(AM_CFLAGS)
> +select_poll_epoll_CFLAGS = $(POPT_CFLAGS) -fno-stack-protector -D_FORTIFY_SOURCE=0 $(AM_CFLAGS)
POPT_CFLAGS should come after the specific flag and before AM_CFLAGS
>
> all-local:
> @if [ x"$(srcdir)" != x"$(builddir)" ]; then \
> diff --git a/tests/regression/ust/multi-lib/Makefile.am b/tests/regression/ust/multi-lib/Makefile.am
> index 3fb4ae74..17ccf3e6 100644
> --- a/tests/regression/ust/multi-lib/Makefile.am
> +++ b/tests/regression/ust/multi-lib/Makefile.am
> @@ -3,13 +3,13 @@ EXTRA_DIST = test_multi_lib
> noinst_PROGRAMS = exec-with-callsites exec-without-callsites
>
> exec_with_callsites_SOURCES = multi-lib-test.c callsites.c
> -exec_with_callsites_LDFLAGS = -ldl -lpopt
> -exec_with_callsites_CFLAGS = $(AM_CFLAGS) -DHAS_CALLSITES=1
> +exec_with_callsites_LDFLAGS = -ldl $(POPT_LIBS)
> +exec_with_callsites_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS) -DHAS_CALLSITES=1
>
> exec_without_callsites_SOURCES = multi-lib-test.c
> -exec_without_callsites_LDFLAGS = -ldl -lpopt -llttng-ust
> +exec_without_callsites_LDFLAGS = -ldl $(POPT_LIBS) -llttng-ust
> exec_without_callsites_LDADD = probes.o
> -exec_without_callsites_CFLAGS = $(AM_CFLAGS) -DHAS_CALLSITES=0
> +exec_without_callsites_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS) -DHAS_CALLSITES=0
>
> PROBES_SRC=probes.c probes.h
> PROBES_LDF=-shared -module -llttng-ust -avoid-version -rpath $(abs_builddir)/.libs/
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH lttng-tools v2 1/2] RFC: Add POPT_CFLAGS to lttng_CFLAGS
[not found] <20190215195217.5012-1-ylamarre@efficios.com>
2019-02-15 19:52 ` [RFC PATCH lttng-tools] RFC: Enforce DL_LIBS value instead of hard coded -ldl Yannick Lamarre
2019-02-15 20:14 ` [RFC PATCH lttng-tools] RFC: Add POPT_CFLAGS to lttng_CFLAGS Michael Jeanson
@ 2019-02-18 17:05 ` Yannick Lamarre
[not found] ` <20190218170528.18823-1-ylamarre@efficios.com>
3 siblings, 0 replies; 8+ messages in thread
From: Yannick Lamarre @ 2019-02-18 17:05 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
The generated makefile was ignoring POPT_CFLAGS when compiling
lttng, but was adding POPT_LIBS to lttng_LDADD. With this commit,
make now honors both settings for applications and tests.
Refs: #1165
Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
---
src/bin/lttng/Makefile.am | 2 ++
tests/regression/kernel/Makefile.am | 2 +-
tests/regression/ust/multi-lib/Makefile.am | 8 ++++----
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/bin/lttng/Makefile.am b/src/bin/lttng/Makefile.am
index b0e1247d..8da4d88b 100644
--- a/src/bin/lttng/Makefile.am
+++ b/src/bin/lttng/Makefile.am
@@ -28,6 +28,8 @@ lttng_SOURCES = command.h conf.c conf.h commands/start.c \
commands/disable_rotation.c \
utils.c utils.h lttng.c
# POPT_CFLAGS now before AM_CFLAGS
+lttng_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS)
+
lttng_LDADD = $(top_builddir)/src/lib/lttng-ctl/liblttng-ctl.la \
$(top_builddir)/src/common/libcommon.la \
$(top_builddir)/src/common/config/libconfig.la \
diff --git a/tests/regression/kernel/Makefile.am b/tests/regression/kernel/Makefile.am
index a787e4fa..53fc8e01 100644
--- a/tests/regression/kernel/Makefile.am
+++ b/tests/regression/kernel/Makefile.am
@@ -7,7 +7,7 @@ EXTRA_DIST = test_event_basic test_all_events test_syscall \
noinst_PROGRAMS = select_poll_epoll
select_poll_epoll_SOURCES = select_poll_epoll.c
select_poll_epoll_LDADD = $(POPT_LIBS)
# POPT_CFLAGS now after specific flags, but before AM_CFLAGS
-select_poll_epoll_CFLAGS = -fno-stack-protector -D_FORTIFY_SOURCE=0 $(AM_CFLAGS)
+select_poll_epoll_CFLAGS = -fno-stack-protector -D_FORTIFY_SOURCE=0 $(POPT_CFLAGS) $(AM_CFLAGS)
all-local:
@if [ x"$(srcdir)" != x"$(builddir)" ]; then \
diff --git a/tests/regression/ust/multi-lib/Makefile.am b/tests/regression/ust/multi-lib/Makefile.am
index 3fb4ae74..17ccf3e6 100644
--- a/tests/regression/ust/multi-lib/Makefile.am
+++ b/tests/regression/ust/multi-lib/Makefile.am
@@ -3,13 +3,13 @@ EXTRA_DIST = test_multi_lib
noinst_PROGRAMS = exec-with-callsites exec-without-callsites
exec_with_callsites_SOURCES = multi-lib-test.c callsites.c
-exec_with_callsites_LDFLAGS = -ldl -lpopt
-exec_with_callsites_CFLAGS = $(AM_CFLAGS) -DHAS_CALLSITES=1
+exec_with_callsites_LDFLAGS = -ldl $(POPT_LIBS)
+exec_with_callsites_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS) -DHAS_CALLSITES=1
exec_without_callsites_SOURCES = multi-lib-test.c
-exec_without_callsites_LDFLAGS = -ldl -lpopt -llttng-ust
+exec_without_callsites_LDFLAGS = -ldl $(POPT_LIBS) -llttng-ust
exec_without_callsites_LDADD = probes.o
-exec_without_callsites_CFLAGS = $(AM_CFLAGS) -DHAS_CALLSITES=0
+exec_without_callsites_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS) -DHAS_CALLSITES=0
PROBES_SRC=probes.c probes.h
PROBES_LDF=-shared -module -llttng-ust -avoid-version -rpath $(abs_builddir)/.libs/
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH lttng-tools v2 2/2] RFC: Enforce DL_LIBS value instead of hard coded -ldl
[not found] ` <20190218170528.18823-1-ylamarre@efficios.com>
@ 2019-02-18 17:05 ` Yannick Lamarre
2019-02-22 19:14 ` [PATCH lttng-tools 1/2] Fix: Add POPT_CFLAGS to lttng_CFLAGS Yannick Lamarre
[not found] ` <20190222191453.6533-1-ylamarre@efficios.com>
2 siblings, 0 replies; 8+ messages in thread
From: Yannick Lamarre @ 2019-02-18 17:05 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
Generated makefiles would ignore DL_LIBS value selected by configure
script and use the hard coded value -ldl. Generated makefiles will
now use DL_LIBS.
Refs: #1165
Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
---
src/common/testpoint/Makefile.am | 2 +-
tests/regression/ust/baddr-statedump/Makefile.am | 2 +-
tests/regression/ust/ust-dl/Makefile.am | 2 +-
tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/common/testpoint/Makefile.am b/src/common/testpoint/Makefile.am
index 5c15725e..a2f9d407 100644
--- a/src/common/testpoint/Makefile.am
+++ b/src/common/testpoint/Makefile.am
@@ -1,4 +1,4 @@
noinst_LTLIBRARIES = libtestpoint.la
libtestpoint_la_SOURCES = testpoint.h testpoint.c
-libtestpoint_la_LIBADD = -ldl
+libtestpoint_la_LIBADD = $(DL_LIBS)
diff --git a/tests/regression/ust/baddr-statedump/Makefile.am b/tests/regression/ust/baddr-statedump/Makefile.am
index bf327179..bf51f948 100644
--- a/tests/regression/ust/baddr-statedump/Makefile.am
+++ b/tests/regression/ust/baddr-statedump/Makefile.am
@@ -6,7 +6,7 @@ AM_CPPFLAGS += -I$(srcdir) -g
noinst_PROGRAMS = prog
prog_SOURCES = prog.c tp.c tp.h
-prog_LDADD = -llttng-ust -ldl
+prog_LDADD = -llttng-ust $(DL_LIBS)
noinst_SCRIPTS = test_baddr-statedump test_baddr-statedump.py
EXTRA_DIST = test_baddr-statedump test_baddr-statedump.py
diff --git a/tests/regression/ust/ust-dl/Makefile.am b/tests/regression/ust/ust-dl/Makefile.am
index 9889e85a..c51e072f 100644
--- a/tests/regression/ust/ust-dl/Makefile.am
+++ b/tests/regression/ust/ust-dl/Makefile.am
@@ -19,7 +19,7 @@ AM_CPPFLAGS += -I$(srcdir) -g
noinst_PROGRAMS = prog
prog_SOURCES = prog.c
-prog_LDADD = -ldl
+prog_LDADD = $(DL_LIBS)
noinst_LTLIBRARIES = libzzz.la libbar.la libfoo.la libtp.la
diff --git a/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am b/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am
index e86939b4..d79ce0ea 100644
--- a/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am
+++ b/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am
@@ -3,7 +3,7 @@ BUILT_SOURCES = foobar_provider.h
noinst_PROGRAMS = userspace-probe-sdt-binary
userspace_probe_sdt_binary_SOURCES = userspace-probe-sdt-binary.c sema.h sema.c
-userspace_probe_sdt_binary_LDADD = foobar_provider.o libfoo.la libbar.la -ldl
+userspace_probe_sdt_binary_LDADD = foobar_provider.o libfoo.la libbar.la $(DL_LIBS)
userspace_probe_sdt_binary_CFLAGS = -I$(abs_builddir)
nodist_userspace_probe_sdt_binary_SOURCES = $(abs_builddir)/foobar_provider.h
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH lttng-tools 1/2] Fix: Add POPT_CFLAGS to lttng_CFLAGS
[not found] ` <20190218170528.18823-1-ylamarre@efficios.com>
2019-02-18 17:05 ` [PATCH lttng-tools v2 2/2] RFC: Enforce DL_LIBS value instead of hard coded -ldl Yannick Lamarre
@ 2019-02-22 19:14 ` Yannick Lamarre
[not found] ` <20190222191453.6533-1-ylamarre@efficios.com>
2 siblings, 0 replies; 8+ messages in thread
From: Yannick Lamarre @ 2019-02-22 19:14 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
The generated makefile was ignoring POPT_CFLAGS when compiling
lttng, but was adding POPT_LIBS to lttng_LDADD. With this commit,
make now honors both settings for applications and tests.
Fixes: #1165
Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
---
src/bin/lttng/Makefile.am | 2 ++
tests/regression/kernel/Makefile.am | 2 +-
tests/regression/ust/multi-lib/Makefile.am | 8 ++++----
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/bin/lttng/Makefile.am b/src/bin/lttng/Makefile.am
index b0e1247d..62ae0593 100644
--- a/src/bin/lttng/Makefile.am
+++ b/src/bin/lttng/Makefile.am
@@ -28,6 +28,8 @@ lttng_SOURCES = command.h conf.c conf.h commands/start.c \
commands/disable_rotation.c \
utils.c utils.h lttng.c
+lttng_CFLAGS = $(AM_CFLAGS) $(POPT_CFLAGS)
+
lttng_LDADD = $(top_builddir)/src/lib/lttng-ctl/liblttng-ctl.la \
$(top_builddir)/src/common/libcommon.la \
$(top_builddir)/src/common/config/libconfig.la \
diff --git a/tests/regression/kernel/Makefile.am b/tests/regression/kernel/Makefile.am
index a787e4fa..3ab6d75b 100644
--- a/tests/regression/kernel/Makefile.am
+++ b/tests/regression/kernel/Makefile.am
@@ -7,7 +7,7 @@ EXTRA_DIST = test_event_basic test_all_events test_syscall \
noinst_PROGRAMS = select_poll_epoll
select_poll_epoll_SOURCES = select_poll_epoll.c
select_poll_epoll_LDADD = $(POPT_LIBS)
-select_poll_epoll_CFLAGS = -fno-stack-protector -D_FORTIFY_SOURCE=0 $(AM_CFLAGS)
+select_poll_epoll_CFLAGS = $(POPT_CFLAGS) -fno-stack-protector -D_FORTIFY_SOURCE=0 $(AM_CFLAGS)
all-local:
@if [ x"$(srcdir)" != x"$(builddir)" ]; then \
diff --git a/tests/regression/ust/multi-lib/Makefile.am b/tests/regression/ust/multi-lib/Makefile.am
index 3fb4ae74..17ccf3e6 100644
--- a/tests/regression/ust/multi-lib/Makefile.am
+++ b/tests/regression/ust/multi-lib/Makefile.am
@@ -3,13 +3,13 @@ EXTRA_DIST = test_multi_lib
noinst_PROGRAMS = exec-with-callsites exec-without-callsites
exec_with_callsites_SOURCES = multi-lib-test.c callsites.c
-exec_with_callsites_LDFLAGS = -ldl -lpopt
-exec_with_callsites_CFLAGS = $(AM_CFLAGS) -DHAS_CALLSITES=1
+exec_with_callsites_LDFLAGS = -ldl $(POPT_LIBS)
+exec_with_callsites_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS) -DHAS_CALLSITES=1
exec_without_callsites_SOURCES = multi-lib-test.c
-exec_without_callsites_LDFLAGS = -ldl -lpopt -llttng-ust
+exec_without_callsites_LDFLAGS = -ldl $(POPT_LIBS) -llttng-ust
exec_without_callsites_LDADD = probes.o
-exec_without_callsites_CFLAGS = $(AM_CFLAGS) -DHAS_CALLSITES=0
+exec_without_callsites_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS) -DHAS_CALLSITES=0
PROBES_SRC=probes.c probes.h
PROBES_LDF=-shared -module -llttng-ust -avoid-version -rpath $(abs_builddir)/.libs/
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH lttng-tools 2/2] RFC: Enforce DL_LIBS value instead of hard coded -ldl
[not found] ` <20190222191453.6533-1-ylamarre@efficios.com>
@ 2019-02-22 19:14 ` Yannick Lamarre
2019-02-22 19:28 ` [PATCH lttng-tools 1/2] Fix: Add POPT_CFLAGS to lttng_CFLAGS Jonathan Rajotte-Julien
1 sibling, 0 replies; 8+ messages in thread
From: Yannick Lamarre @ 2019-02-22 19:14 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
Generated makefiles would ignore DL_LIBS value selected by configure
script and use the hard coded value -ldl. Generated makefiles will
now use DL_LIBS.
Refs: #1165
Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
---
src/common/testpoint/Makefile.am | 2 +-
tests/regression/ust/baddr-statedump/Makefile.am | 2 +-
tests/regression/ust/ust-dl/Makefile.am | 2 +-
tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/common/testpoint/Makefile.am b/src/common/testpoint/Makefile.am
index 5c15725e..a2f9d407 100644
--- a/src/common/testpoint/Makefile.am
+++ b/src/common/testpoint/Makefile.am
@@ -1,4 +1,4 @@
noinst_LTLIBRARIES = libtestpoint.la
libtestpoint_la_SOURCES = testpoint.h testpoint.c
-libtestpoint_la_LIBADD = -ldl
+libtestpoint_la_LIBADD = $(DL_LIBS)
diff --git a/tests/regression/ust/baddr-statedump/Makefile.am b/tests/regression/ust/baddr-statedump/Makefile.am
index bf327179..bf51f948 100644
--- a/tests/regression/ust/baddr-statedump/Makefile.am
+++ b/tests/regression/ust/baddr-statedump/Makefile.am
@@ -6,7 +6,7 @@ AM_CPPFLAGS += -I$(srcdir) -g
noinst_PROGRAMS = prog
prog_SOURCES = prog.c tp.c tp.h
-prog_LDADD = -llttng-ust -ldl
+prog_LDADD = -llttng-ust $(DL_LIBS)
noinst_SCRIPTS = test_baddr-statedump test_baddr-statedump.py
EXTRA_DIST = test_baddr-statedump test_baddr-statedump.py
diff --git a/tests/regression/ust/ust-dl/Makefile.am b/tests/regression/ust/ust-dl/Makefile.am
index 9889e85a..c51e072f 100644
--- a/tests/regression/ust/ust-dl/Makefile.am
+++ b/tests/regression/ust/ust-dl/Makefile.am
@@ -19,7 +19,7 @@ AM_CPPFLAGS += -I$(srcdir) -g
noinst_PROGRAMS = prog
prog_SOURCES = prog.c
-prog_LDADD = -ldl
+prog_LDADD = $(DL_LIBS)
noinst_LTLIBRARIES = libzzz.la libbar.la libfoo.la libtp.la
diff --git a/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am b/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am
index e86939b4..d79ce0ea 100644
--- a/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am
+++ b/tests/utils/testapp/userspace-probe-sdt-binary/Makefile.am
@@ -3,7 +3,7 @@ BUILT_SOURCES = foobar_provider.h
noinst_PROGRAMS = userspace-probe-sdt-binary
userspace_probe_sdt_binary_SOURCES = userspace-probe-sdt-binary.c sema.h sema.c
-userspace_probe_sdt_binary_LDADD = foobar_provider.o libfoo.la libbar.la -ldl
+userspace_probe_sdt_binary_LDADD = foobar_provider.o libfoo.la libbar.la $(DL_LIBS)
userspace_probe_sdt_binary_CFLAGS = -I$(abs_builddir)
nodist_userspace_probe_sdt_binary_SOURCES = $(abs_builddir)/foobar_provider.h
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH lttng-tools 1/2] Fix: Add POPT_CFLAGS to lttng_CFLAGS
[not found] ` <20190222191453.6533-1-ylamarre@efficios.com>
2019-02-22 19:14 ` [PATCH lttng-tools 2/2] RFC: Enforce DL_LIBS value instead of hard coded -ldl Yannick Lamarre
@ 2019-02-22 19:28 ` Jonathan Rajotte-Julien
1 sibling, 0 replies; 8+ messages in thread
From: Jonathan Rajotte-Julien @ 2019-02-22 19:28 UTC (permalink / raw)
To: Yannick Lamarre; +Cc: lttng-dev, jgalar
Hi,
Could you resend outside this thread and mark as v3?
Also remove the RFC flag from patch 2.
Thanks
On Fri, Feb 22, 2019 at 02:14:52PM -0500, Yannick Lamarre wrote:
> The generated makefile was ignoring POPT_CFLAGS when compiling
> lttng, but was adding POPT_LIBS to lttng_LDADD. With this commit,
> make now honors both settings for applications and tests.
>
> Fixes: #1165
>
> Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
> ---
> src/bin/lttng/Makefile.am | 2 ++
> tests/regression/kernel/Makefile.am | 2 +-
> tests/regression/ust/multi-lib/Makefile.am | 8 ++++----
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/src/bin/lttng/Makefile.am b/src/bin/lttng/Makefile.am
> index b0e1247d..62ae0593 100644
> --- a/src/bin/lttng/Makefile.am
> +++ b/src/bin/lttng/Makefile.am
> @@ -28,6 +28,8 @@ lttng_SOURCES = command.h conf.c conf.h commands/start.c \
> commands/disable_rotation.c \
> utils.c utils.h lttng.c
>
> +lttng_CFLAGS = $(AM_CFLAGS) $(POPT_CFLAGS)
> +
> lttng_LDADD = $(top_builddir)/src/lib/lttng-ctl/liblttng-ctl.la \
> $(top_builddir)/src/common/libcommon.la \
> $(top_builddir)/src/common/config/libconfig.la \
> diff --git a/tests/regression/kernel/Makefile.am b/tests/regression/kernel/Makefile.am
> index a787e4fa..3ab6d75b 100644
> --- a/tests/regression/kernel/Makefile.am
> +++ b/tests/regression/kernel/Makefile.am
> @@ -7,7 +7,7 @@ EXTRA_DIST = test_event_basic test_all_events test_syscall \
> noinst_PROGRAMS = select_poll_epoll
> select_poll_epoll_SOURCES = select_poll_epoll.c
> select_poll_epoll_LDADD = $(POPT_LIBS)
> -select_poll_epoll_CFLAGS = -fno-stack-protector -D_FORTIFY_SOURCE=0 $(AM_CFLAGS)
> +select_poll_epoll_CFLAGS = $(POPT_CFLAGS) -fno-stack-protector -D_FORTIFY_SOURCE=0 $(AM_CFLAGS)
>
> all-local:
> @if [ x"$(srcdir)" != x"$(builddir)" ]; then \
> diff --git a/tests/regression/ust/multi-lib/Makefile.am b/tests/regression/ust/multi-lib/Makefile.am
> index 3fb4ae74..17ccf3e6 100644
> --- a/tests/regression/ust/multi-lib/Makefile.am
> +++ b/tests/regression/ust/multi-lib/Makefile.am
> @@ -3,13 +3,13 @@ EXTRA_DIST = test_multi_lib
> noinst_PROGRAMS = exec-with-callsites exec-without-callsites
>
> exec_with_callsites_SOURCES = multi-lib-test.c callsites.c
> -exec_with_callsites_LDFLAGS = -ldl -lpopt
> -exec_with_callsites_CFLAGS = $(AM_CFLAGS) -DHAS_CALLSITES=1
> +exec_with_callsites_LDFLAGS = -ldl $(POPT_LIBS)
> +exec_with_callsites_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS) -DHAS_CALLSITES=1
>
> exec_without_callsites_SOURCES = multi-lib-test.c
> -exec_without_callsites_LDFLAGS = -ldl -lpopt -llttng-ust
> +exec_without_callsites_LDFLAGS = -ldl $(POPT_LIBS) -llttng-ust
> exec_without_callsites_LDADD = probes.o
> -exec_without_callsites_CFLAGS = $(AM_CFLAGS) -DHAS_CALLSITES=0
> +exec_without_callsites_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS) -DHAS_CALLSITES=0
>
> PROBES_SRC=probes.c probes.h
> PROBES_LDF=-shared -module -llttng-ust -avoid-version -rpath $(abs_builddir)/.libs/
> --
> 2.11.0
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Jonathan Rajotte-Julien
EfficiOS
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC PATCH lttng-tools] RFC: Add POPT_CFLAGS to lttng_CFLAGS
@ 2019-02-15 19:52 Yannick Lamarre
0 siblings, 0 replies; 8+ messages in thread
From: Yannick Lamarre @ 2019-02-15 19:52 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
The generated makefile was ignoring POPT_CFLAGS when compiling
lttng, but was adding POPT_LIBS to lttng_LDADD. With this commit,
make now honors both settings for applications and tests.
Fixes: #1165
Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
---
src/bin/lttng/Makefile.am | 2 ++
tests/regression/kernel/Makefile.am | 2 +-
tests/regression/ust/multi-lib/Makefile.am | 8 ++++----
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/bin/lttng/Makefile.am b/src/bin/lttng/Makefile.am
index b0e1247d..62ae0593 100644
--- a/src/bin/lttng/Makefile.am
+++ b/src/bin/lttng/Makefile.am
@@ -28,6 +28,8 @@ lttng_SOURCES = command.h conf.c conf.h commands/start.c \
commands/disable_rotation.c \
utils.c utils.h lttng.c
+lttng_CFLAGS = $(AM_CFLAGS) $(POPT_CFLAGS)
+
lttng_LDADD = $(top_builddir)/src/lib/lttng-ctl/liblttng-ctl.la \
$(top_builddir)/src/common/libcommon.la \
$(top_builddir)/src/common/config/libconfig.la \
diff --git a/tests/regression/kernel/Makefile.am b/tests/regression/kernel/Makefile.am
index a787e4fa..3ab6d75b 100644
--- a/tests/regression/kernel/Makefile.am
+++ b/tests/regression/kernel/Makefile.am
@@ -7,7 +7,7 @@ EXTRA_DIST = test_event_basic test_all_events test_syscall \
noinst_PROGRAMS = select_poll_epoll
select_poll_epoll_SOURCES = select_poll_epoll.c
select_poll_epoll_LDADD = $(POPT_LIBS)
-select_poll_epoll_CFLAGS = -fno-stack-protector -D_FORTIFY_SOURCE=0 $(AM_CFLAGS)
+select_poll_epoll_CFLAGS = $(POPT_CFLAGS) -fno-stack-protector -D_FORTIFY_SOURCE=0 $(AM_CFLAGS)
all-local:
@if [ x"$(srcdir)" != x"$(builddir)" ]; then \
diff --git a/tests/regression/ust/multi-lib/Makefile.am b/tests/regression/ust/multi-lib/Makefile.am
index 3fb4ae74..17ccf3e6 100644
--- a/tests/regression/ust/multi-lib/Makefile.am
+++ b/tests/regression/ust/multi-lib/Makefile.am
@@ -3,13 +3,13 @@ EXTRA_DIST = test_multi_lib
noinst_PROGRAMS = exec-with-callsites exec-without-callsites
exec_with_callsites_SOURCES = multi-lib-test.c callsites.c
-exec_with_callsites_LDFLAGS = -ldl -lpopt
-exec_with_callsites_CFLAGS = $(AM_CFLAGS) -DHAS_CALLSITES=1
+exec_with_callsites_LDFLAGS = -ldl $(POPT_LIBS)
+exec_with_callsites_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS) -DHAS_CALLSITES=1
exec_without_callsites_SOURCES = multi-lib-test.c
-exec_without_callsites_LDFLAGS = -ldl -lpopt -llttng-ust
+exec_without_callsites_LDFLAGS = -ldl $(POPT_LIBS) -llttng-ust
exec_without_callsites_LDADD = probes.o
-exec_without_callsites_CFLAGS = $(AM_CFLAGS) -DHAS_CALLSITES=0
+exec_without_callsites_CFLAGS = $(POPT_CFLAGS) $(AM_CFLAGS) -DHAS_CALLSITES=0
PROBES_SRC=probes.c probes.h
PROBES_LDF=-shared -module -llttng-ust -avoid-version -rpath $(abs_builddir)/.libs/
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-22 19:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190215195217.5012-1-ylamarre@efficios.com>
2019-02-15 19:52 ` [RFC PATCH lttng-tools] RFC: Enforce DL_LIBS value instead of hard coded -ldl Yannick Lamarre
2019-02-15 20:14 ` [RFC PATCH lttng-tools] RFC: Add POPT_CFLAGS to lttng_CFLAGS Michael Jeanson
2019-02-18 17:05 ` [PATCH lttng-tools v2 1/2] " Yannick Lamarre
[not found] ` <20190218170528.18823-1-ylamarre@efficios.com>
2019-02-18 17:05 ` [PATCH lttng-tools v2 2/2] RFC: Enforce DL_LIBS value instead of hard coded -ldl Yannick Lamarre
2019-02-22 19:14 ` [PATCH lttng-tools 1/2] Fix: Add POPT_CFLAGS to lttng_CFLAGS Yannick Lamarre
[not found] ` <20190222191453.6533-1-ylamarre@efficios.com>
2019-02-22 19:14 ` [PATCH lttng-tools 2/2] RFC: Enforce DL_LIBS value instead of hard coded -ldl Yannick Lamarre
2019-02-22 19:28 ` [PATCH lttng-tools 1/2] Fix: Add POPT_CFLAGS to lttng_CFLAGS Jonathan Rajotte-Julien
2019-02-15 19:52 [RFC PATCH lttng-tools] RFC: " Yannick Lamarre
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.