All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: stm32: Use firwmare property instead of loadables
@ 2020-09-07  8:35 Michal Simek
  2020-09-07  8:48 ` Michal Simek
  0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2020-09-07  8:35 UTC (permalink / raw)
  To: u-boot

There shouldn't be a need to use loadables propertyn because u-boot can be
pointed by firmware property. This change should also speedup boot process
because loadables property is list of strings which code is going through.
On the other hand firmware can just point to one image.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Only done based on grepping the code. Please retest.
---
 board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its b/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
index 905be57dffd7..dfe89bfad67e 100644
--- a/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
+++ b/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
@@ -39,28 +39,28 @@
 		config-1 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-pdk2_somrev0_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 
 		config-2 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-pdk2_somrev1_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 
 		config-3 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-drc02_somrev0_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-2";
 		};
 
 		config-4 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-drc02_somrev1_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-2";
 		};
 
-- 
2.28.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: stm32: Use firwmare property instead of loadables
  2020-09-07  8:35 [PATCH] ARM: stm32: Use firwmare property instead of loadables Michal Simek
@ 2020-09-07  8:48 ` Michal Simek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2020-09-07  8:48 UTC (permalink / raw)
  To: u-boot

Hi,

On 07. 09. 20 10:35, Michal Simek wrote:
> There shouldn't be a need to use loadables propertyn because u-boot can be
> pointed by firmware property. This change should also speedup boot process
> because loadables property is list of strings which code is going through.
> On the other hand firmware can just point to one image.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
> Only done based on grepping the code. Please retest.
> ---
>  board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its b/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
> index 905be57dffd7..dfe89bfad67e 100644
> --- a/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
> +++ b/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
> @@ -39,28 +39,28 @@
>  		config-1 {
>  			/* DT+SoM+board model */
>  			description = "dh,stm32mp15xx-dhcom-pdk2_somrev0_boardrev0";
> -			loadables = "uboot";
> +			firmware = "uboot";
>  			fdt = "fdt-1";
>  		};
>  
>  		config-2 {
>  			/* DT+SoM+board model */
>  			description = "dh,stm32mp15xx-dhcom-pdk2_somrev1_boardrev0";
> -			loadables = "uboot";
> +			firmware = "uboot";
>  			fdt = "fdt-1";
>  		};
>  
>  		config-3 {
>  			/* DT+SoM+board model */
>  			description = "dh,stm32mp15xx-dhcom-drc02_somrev0_boardrev0";
> -			loadables = "uboot";
> +			firmware = "uboot";
>  			fdt = "fdt-2";
>  		};
>  
>  		config-4 {
>  			/* DT+SoM+board model */
>  			description = "dh,stm32mp15xx-dhcom-drc02_somrev1_boardrev0";
> -			loadables = "uboot";
> +			firmware = "uboot";
>  			fdt = "fdt-2";
>  		};
>  
> 

Marek: I see there is also dhcor which has the same issue. Will send v2
when someone confirms that this works properly.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-07  8:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07  8:35 [PATCH] ARM: stm32: Use firwmare property instead of loadables Michal Simek
2020-09-07  8:48 ` Michal Simek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.