[Buildroot] [PATCH] genimage: change upstream URL

[Buildroot] [PATCH] genimage: change upstream URL

[Vivien Didelot]

Pengutronix moved the official genimage repository to Github.

This patch updates the official URL from the package description. The
sources from Github do not include the configure script so update the
sha256 hash and set GENIMAGE_AUTORECONF to execute ./autogen.sh first.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 package/genimage/Config.in.host | 2 +-
 package/genimage/genimage.hash  | 2 +-
 package/genimage/genimage.mk    | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/package/genimage/Config.in.host b/package/genimage/Config.in.host
index 5c5a8a8a2c..cf831a143c 100644
--- a/package/genimage/Config.in.host
+++ b/package/genimage/Config.in.host
@@ -10,4 +10,4 @@ config BR2_PACKAGE_HOST_GENIMAGE
 	  environment variables, the config file or commandline
 	  switches.
 
-	  http://www.pengutronix.de/software/genimage/
+	  https://github.com/pengutronix/genimage
diff --git a/package/genimage/genimage.hash b/package/genimage/genimage.hash
index 4be2fca873..0c304629c7 100644
--- a/package/genimage/genimage.hash
+++ b/package/genimage/genimage.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256	69f35af7edf6f4dbdac7a18ddc69dcf38c501e43d8b50c524555754c51479078	genimage-9.tar.xz
+sha256 c5f6063cab834cd9a6d484c5773430f68cb61aa7203c8270c9e42dac2a0461f0        genimage-v9.tar.gz
diff --git a/package/genimage/genimage.mk b/package/genimage/genimage.mk
index 2e7aad20c6..913d745cec 100644
--- a/package/genimage/genimage.mk
+++ b/package/genimage/genimage.mk
@@ -4,11 +4,11 @@
 #
 ################################################################################
 
-GENIMAGE_VERSION = 9
-GENIMAGE_SOURCE = genimage-$(GENIMAGE_VERSION).tar.xz
-GENIMAGE_SITE = http://www.pengutronix.de/software/genimage/download
+GENIMAGE_VERSION = v9
+GENIMAGE_SITE = $(call github,pengutronix,genimage,$(GENIMAGE_VERSION))
 HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse
 GENIMAGE_LICENSE = GPL-2.0
 GENIMAGE_LICENSE_FILES = COPYING
+GENIMAGE_AUTORECONF = YES
 
 $(eval $(host-autotools-package))
-- 
2.15.0

[Buildroot] [PATCH] genimage: change upstream URL

[Arnout Vandecappelle]

On 14-11-17 18:46, Vivien Didelot wrote:
> Pengutronix moved the official genimage repository to Github.
> 
> This patch updates the official URL from the package description. The
> sources from Github do not include the configure script so update the
> sha256 hash and set GENIMAGE_AUTORECONF to execute ./autogen.sh first.

 Since the archive still exists on Pengutronix, and there it's an .xz instead of
a .gz, and that archive doesn't need to be AUTORECONF'ed, I think it's better to
stick with the original archive.

 Changing the upstream URL in Config.in is still relevant though.

 Regards,
 Arnout

> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
>  package/genimage/Config.in.host | 2 +-
>  package/genimage/genimage.hash  | 2 +-
>  package/genimage/genimage.mk    | 6 +++---
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/package/genimage/Config.in.host b/package/genimage/Config.in.host
> index 5c5a8a8a2c..cf831a143c 100644
> --- a/package/genimage/Config.in.host
> +++ b/package/genimage/Config.in.host
> @@ -10,4 +10,4 @@ config BR2_PACKAGE_HOST_GENIMAGE
>  	  environment variables, the config file or commandline
>  	  switches.
>  
> -	  http://www.pengutronix.de/software/genimage/
> +	  https://github.com/pengutronix/genimage
> diff --git a/package/genimage/genimage.hash b/package/genimage/genimage.hash
> index 4be2fca873..0c304629c7 100644
> --- a/package/genimage/genimage.hash
> +++ b/package/genimage/genimage.hash
> @@ -1,2 +1,2 @@
>  # Locally calculated
> -sha256	69f35af7edf6f4dbdac7a18ddc69dcf38c501e43d8b50c524555754c51479078	genimage-9.tar.xz
> +sha256 c5f6063cab834cd9a6d484c5773430f68cb61aa7203c8270c9e42dac2a0461f0        genimage-v9.tar.gz
> diff --git a/package/genimage/genimage.mk b/package/genimage/genimage.mk
> index 2e7aad20c6..913d745cec 100644
> --- a/package/genimage/genimage.mk
> +++ b/package/genimage/genimage.mk
> @@ -4,11 +4,11 @@
>  #
>  ################################################################################
>  
> -GENIMAGE_VERSION = 9
> -GENIMAGE_SOURCE = genimage-$(GENIMAGE_VERSION).tar.xz
> -GENIMAGE_SITE = http://www.pengutronix.de/software/genimage/download
> +GENIMAGE_VERSION = v9
> +GENIMAGE_SITE = $(call github,pengutronix,genimage,$(GENIMAGE_VERSION))
>  HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse
>  GENIMAGE_LICENSE = GPL-2.0
>  GENIMAGE_LICENSE_FILES = COPYING
> +GENIMAGE_AUTORECONF = YES
>  
>  $(eval $(host-autotools-package))
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] genimage: change upstream URL

[Vivien Didelot]

Hi Arnout,

Arnout Vandecappelle <arnout@mind.be> writes:

>  Since the archive still exists on Pengutronix, and there it's an .xz instead of
> a .gz, and that archive doesn't need to be AUTORECONF'ed, I think it's better to
> stick with the original archive.

The http://public.pengutronix.de/software/genimage/ URL says:

"Please note: The content on public.pengutronix.de is mostly temporary,
so it might vanish into thin air any time. Have fun :-)"

So I think it is preferable to use the Github URL instead.


Thanks,

        Vivien

[Buildroot] [PATCH] genimage: change upstream URL

[Arnout Vandecappelle]

On 14-11-17 23:17, Vivien Didelot wrote:
> Hi Arnout,
> 
> Arnout Vandecappelle <arnout@mind.be> writes:
> 
>>  Since the archive still exists on Pengutronix, and there it's an .xz instead of
>> a .gz, and that archive doesn't need to be AUTORECONF'ed, I think it's better to
>> stick with the original archive.
> 
> The http://public.pengutronix.de/software/genimage/ URL says:
> 
> "Please note: The content on public.pengutronix.de is mostly temporary,
> so it might vanish into thin air any time. Have fun :-)"

 AFAIK that message has always been there, but still all the genimage releases
can be downloaded from it.

 Maybe for the next release, Pengutronix will upload a tar.xz to github? Then we
can certainly switch. Now, especially the AUTORECONF'ing is IMO really annoying
(it will multiply the build time with a factor of four for a simple config with
just busybox and an external toolchain).

 Regards,
 Arnout

> 
> So I think it is preferable to use the Github URL instead.
> 
> 
> Thanks,
> 
>         Vivien
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] genimage: change upstream URL

[Arnout Vandecappelle]

On 15-11-17 09:52, Jan L?bbe wrote:
> On Wed, 2017-11-15 at 09:42 +0100, Arnout Vandecappelle wrote:
>>
>> On 14-11-17 23:17, Vivien Didelot wrote:
>>> Hi Arnout,
>>>
>>> Arnout Vandecappelle <arnout@mind.be> writes:
>>>
>>>>  Since the archive still exists on Pengutronix, and there it's an
>>>> .xz instead of
>>>> a .gz, and that archive doesn't need to be AUTORECONF'ed, I think
>>>> it's better to
>>>> stick with the original archive.
>>>
>>> The http://public.pengutronix.de/software/genimage/ URL says:
>>>
>>> "Please note: The content on public.pengutronix.de is mostly
>>> temporary,
>>> so it might vanish into thin air any time. Have fun :-)"
>>
>> AFAIK that message has always been there, but still all the genimage
>> releases can be downloaded from it.
>>
>>  Maybe for the next release, Pengutronix will upload a tar.xz to
>> github? Then we can certainly switch. Now, especially the
>> AUTORECONF'ing is IMO really annoying (it will multiply the build
>> time with a factor of four for a simple config with just busybox and
>> an external toolchain).
> 
> I've just uploaded all old release tarballs to the github release page:
> https://github.com/pengutronix/genimage/releases

 I just love reactive upstreams :-)

 Vivien, will you respin?

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] genimage: change upstream URL

[Vivien Didelot]

Hi Arnout,

Arnout Vandecappelle <arnout@mind.be> writes:

>>> AFAIK that message has always been there, but still all the genimage
>>> releases can be downloaded from it.
>>>
>>>  Maybe for the next release, Pengutronix will upload a tar.xz to
>>> github? Then we can certainly switch. Now, especially the
>>> AUTORECONF'ing is IMO really annoying (it will multiply the build
>>> time with a factor of four for a simple config with just busybox and
>>> an external toolchain).
>> 
>> I've just uploaded all old release tarballs to the github release page:
>> https://github.com/pengutronix/genimage/releases
>
>  I just love reactive upstreams :-)
>
>  Vivien, will you respin?

Having to autoreconf is unfortunate, but is a parallel issue IMO.

We should ask confirmation from Pengutronix which web page is considered
the official one from now on, and Buildroot must reflect that.

But if they keep uploading tarballs including the configure script to
http://public.pengutronix.de/software/genimage/ I'd drop this patch
completely.

Thanks,

        Vivien

[Buildroot] [PATCH] genimage: change upstream URL

[Vivien Didelot]

Hi Michael,

Michael Olbrich <mol@pengutronix.de> writes:

> The uploaded tarballs are the ones from
> http://public.pengutronix.de/software/genimage/ including configure script.

Ho perfect! I'm respinning, thanks!