All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.vnet.ibm.com>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] docker.py: don't hang on large docker output
Date: Fri, 19 Aug 2016 10:58:14 +0200	[thread overview]
Message-ID: <d5e0e840-5264-6784-231c-4f3abfbc9869@linux.vnet.ibm.com> (raw)
In-Reply-To: <1471551152-26107-2-git-send-email-silbe@linux.vnet.ibm.com>

On 08/18/2016 10:12 PM, Sascha Silbe wrote:
> Unlike Popen.communicate(), subprocess.call() doesn't read from the
> stdout file descriptor. If the child process produces more output than
> fits into the pipe buffer, it will block indefinitely.
> 
> If we don't intend to consume the output, just send it straight to
> /dev/null to avoid this issue.
> 
> Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>

Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com>

  reply	other threads:[~2016-08-19  8:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18 20:12 [Qemu-devel] [PATCH 0/3] docker tests fixes Sascha Silbe
2016-08-18 20:12 ` [Qemu-devel] [PATCH 1/3] docker.py: don't hang on large docker output Sascha Silbe
2016-08-19  8:58   ` Janosch Frank [this message]
2016-08-18 20:12 ` [Qemu-devel] [PATCH 2/3] docker: avoid dependency on 'realpath' package Sascha Silbe
2016-08-18 20:12 ` [Qemu-devel] [PATCH 3/3] docker: debian-bootstrap.pre: print helpful message if DEB_ARCH/DEB_TYPE unset Sascha Silbe
2016-08-19  9:56 ` [Qemu-devel] [PATCH 0/3] docker tests fixes Alex Bennée
2016-08-23 13:52   ` Sascha Silbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5e0e840-5264-6784-231c-4f3abfbc9869@linux.vnet.ibm.com \
    --to=frankja@linux.vnet.ibm.com \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=silbe@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.