From: "Arve Hjønnevåg" <arve@android.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Pavel Machek <pavel@ucw.cz>, Ben Dooks <ben-linux@fluff.org>,
Brian Swetland <swetland@google.com>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: dream: glue for mmc controller
Date: Sun, 8 Nov 2009 18:14:45 -0800 [thread overview]
Message-ID: <d6200be20911081814y286d58d2yf3d9eb7e6ddffa5b@mail.gmail.com> (raw)
In-Reply-To: <20091108091009.GB20529@n2100.arm.linux.org.uk>
On Sun, Nov 8, 2009 at 1:10 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Sun, Nov 08, 2009 at 09:13:14AM +0100, Pavel Machek wrote:
>> > > +#include <asm/io.h>
>> > > +#include <asm/gpio.h>
>> > linux/gpio.h
>> > linux/io.h
>>
>> I got compile errors when trying to use linux/gpio.h:
>>
>> arch/arm/mach-msm/board-dream-gpio.c: In function
>> 'dream_gpio_configure':
>> arch/arm/mach-msm/board-dream-gpio.c:109: error: 'GPIOF_OUTPUT_LOW'
>> undeclared (first use in this function)
>
> This means it's abusing the gpio header files - which are intended for
> the generic GPIO support, but are being used for this platforms private
> non-generic GPIO based stuff.
>
It also means that CONFIG_GENERIC_GPIO is not set, so linux/gpio.h
stubbed out all the gpio functions.
--
Arve Hjønnevåg
WARNING: multiple messages have this Message-ID (diff)
From: arve@android.com (Arve Hjønnevåg)
To: linux-arm-kernel@lists.infradead.org
Subject: dream: glue for mmc controller
Date: Sun, 8 Nov 2009 18:14:45 -0800 [thread overview]
Message-ID: <d6200be20911081814y286d58d2yf3d9eb7e6ddffa5b@mail.gmail.com> (raw)
In-Reply-To: <20091108091009.GB20529@n2100.arm.linux.org.uk>
On Sun, Nov 8, 2009 at 1:10 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Sun, Nov 08, 2009 at 09:13:14AM +0100, Pavel Machek wrote:
>> > > +#include <asm/io.h>
>> > > +#include <asm/gpio.h>
>> > linux/gpio.h
>> > linux/io.h
>>
>> I got compile errors when trying to use linux/gpio.h:
>>
>> arch/arm/mach-msm/board-dream-gpio.c: In function
>> 'dream_gpio_configure':
>> arch/arm/mach-msm/board-dream-gpio.c:109: error: 'GPIOF_OUTPUT_LOW'
>> undeclared (first use in this function)
>
> This means it's abusing the gpio header files - which are intended for
> the generic GPIO support, but are being used for this platforms private
> non-generic GPIO based stuff.
>
It also means that CONFIG_GENERIC_GPIO is not set, so linux/gpio.h
stubbed out all the gpio functions.
--
Arve Hj?nnev?g
next prev parent reply other threads:[~2009-11-09 2:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 10:53 dream: glue for mmc controller Pavel Machek
2009-11-03 10:53 ` Pavel Machek
2009-11-03 10:57 ` Ben Dooks
2009-11-03 10:57 ` Ben Dooks
2009-11-08 8:13 ` Pavel Machek
2009-11-08 8:13 ` Pavel Machek
2009-11-08 9:10 ` Russell King - ARM Linux
2009-11-08 9:10 ` Russell King - ARM Linux
2009-11-09 2:14 ` Arve Hjønnevåg [this message]
2009-11-09 2:14 ` Arve Hjønnevåg
2009-12-08 10:23 ` Pavel Machek
2009-12-08 10:23 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6200be20911081814y286d58d2yf3d9eb7e6ddffa5b@mail.gmail.com \
--to=arve@android.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pavel@ucw.cz \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.