From: Schrempf Frieder <frieder.schrempf@kontron.de> To: Yoshio Furuyama <tmcmc-mb-yfuruyama7@ml.toshiba.co.jp>, "bbrezillon@kernel.org" <bbrezillon@kernel.org>, "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com> Cc: "richard@nod.at" <richard@nod.at>, "dwmw2@infradead.org" <dwmw2@infradead.org>, "computersforpeace@gmail.com" <computersforpeace@gmail.com>, "marek.vasut@gmail.com" <marek.vasut@gmail.com>, "peron.clem@gmail.com" <peron.clem@gmail.com>, "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] mtd: spinand: Add support for all Toshiba Memory products Date: Wed, 16 Jan 2019 12:58:48 +0000 [thread overview] Message-ID: <d6230005-5dfa-60f9-7eec-87d119aa415d@kontron.de> (raw) In-Reply-To: <20190116055319.2755-1-tmcmc-mb-yfuruyama7@ml.toshiba.co.jp> On 16.01.19 06:53, Yoshio Furuyama wrote: > Add device table for Toshiba Memory products. > Also, generalize OOB layout structure and function names. > > Signed-off-by: Yoshio Furuyama <tmcmc-mb-yfuruyama7@ml.toshiba.co.jp> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > > --- > drivers/mtd/nand/spi/toshiba.c | 79 +++++++++++++++++++++++++++++++++------- > 1 file changed, 65 insertions(+), 14 deletions(-) > > diff --git a/drivers/mtd/nand/spi/toshiba.c b/drivers/mtd/nand/spi/toshiba.c > index 0812655..0916962 100644 > --- a/drivers/mtd/nand/spi/toshiba.c > +++ b/drivers/mtd/nand/spi/toshiba.c > @@ -25,19 +25,19 @@ static SPINAND_OP_VARIANTS(write_cache_variants, > static SPINAND_OP_VARIANTS(update_cache_variants, > SPINAND_PROG_LOAD(false, 0, NULL, 0)); > > -static int tc58cvg2s0h_ooblayout_ecc(struct mtd_info *mtd, int section, > +static int tc58cxgxsx_ooblayout_ecc(struct mtd_info *mtd, int section, > struct mtd_oob_region *region) > { > - if (section > 7) > + if (section > 0) > return -ERANGE; > > - region->offset = 128 + 16 * section; > - region->length = 16; > + region->offset = mtd->oobsize / 2; > + region->length = mtd->oobsize / 2; > > return 0; > } > > -static int tc58cvg2s0h_ooblayout_free(struct mtd_info *mtd, int section, > +static int tc58cxgxsx_ooblayout_free(struct mtd_info *mtd, int section, > struct mtd_oob_region *region) > { > if (section > 0) > @@ -45,17 +45,17 @@ static int tc58cvg2s0h_ooblayout_free(struct mtd_info *mtd, int section, > > /* 2 bytes reserved for BBM */ > region->offset = 2; > - region->length = 126; > + region->length = mtd->oobsize / 2 - 2; > > return 0; > } > > -static const struct mtd_ooblayout_ops tc58cvg2s0h_ooblayout = { > - .ecc = tc58cvg2s0h_ooblayout_ecc, > - .free = tc58cvg2s0h_ooblayout_free, > +static const struct mtd_ooblayout_ops tc58cxgxsx_ooblayout = { > + .ecc = tc58cxgxsx_ooblayout_ecc, > + .free = tc58cxgxsx_ooblayout_free, > }; > > -static int tc58cvg2s0h_ecc_get_status(struct spinand_device *spinand, > +static int tc58cxgxsx_ecc_get_status(struct spinand_device *spinand, > u8 status) > { > struct nand_device *nand = spinand_to_nand(spinand); > @@ -94,15 +94,66 @@ static int tc58cvg2s0h_ecc_get_status(struct spinand_device *spinand, > } > > static const struct spinand_info toshiba_spinand_table[] = { > - SPINAND_INFO("TC58CVG2S0H", 0xCD, > + /* 3.3V 1Gb */ > + SPINAND_INFO("TC58CVG0S3", 0xC2, > + NAND_MEMORG(1, 2048, 128, 64, 1024, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > + /* 3.3V 2Gb */ > + SPINAND_INFO("TC58CVG1S3", 0xCB, > + NAND_MEMORG(1, 2048, 128, 64, 2048, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > + /* 3.3V 4Gb */ > + SPINAND_INFO("TC58CVG2S0", 0xCD, > + NAND_MEMORG(1, 4096, 256, 64, 2048, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > + /* 1.8V 1Gb */ > + SPINAND_INFO("TC58CYG0S3", 0xB2, > + NAND_MEMORG(1, 2048, 128, 64, 1024, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > + /* 1.8V 2Gb */ > + SPINAND_INFO("TC58CYG1S3", 0xBB, > + NAND_MEMORG(1, 2048, 128, 64, 2048, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > + /* 1.8V 4Gb */ > + SPINAND_INFO("TC58CYG2S0", 0xBD, > NAND_MEMORG(1, 4096, 256, 64, 2048, 1, 1, 1), > NAND_ECCREQ(8, 512), > SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > &write_cache_variants, > &update_cache_variants), > - SPINAND_HAS_QE_BIT, > - SPINAND_ECCINFO(&tc58cvg2s0h_ooblayout, > - tc58cvg2s0h_ecc_get_status)), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > }; > > static int toshiba_spinand_detect(struct spinand_device *spinand) >
WARNING: multiple messages have this Message-ID (diff)
From: frieder.schrempf@kontron.de (Schrempf Frieder) To: linux-mtd@lists.infradead.org Subject: [PATCH] mtd: spinand: Add support for all Toshiba Memory products Date: Wed, 16 Jan 2019 12:58:48 +0000 [thread overview] Message-ID: <d6230005-5dfa-60f9-7eec-87d119aa415d@kontron.de> (raw) In-Reply-To: <20190116055319.2755-1-tmcmc-mb-yfuruyama7@ml.toshiba.co.jp> On 16.01.19 06:53, Yoshio Furuyama wrote: > Add device table for Toshiba Memory products. > Also, generalize OOB layout structure and function names. > > Signed-off-by: Yoshio Furuyama <tmcmc-mb-yfuruyama7@ml.toshiba.co.jp> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > > --- > drivers/mtd/nand/spi/toshiba.c | 79 +++++++++++++++++++++++++++++++++------- > 1 file changed, 65 insertions(+), 14 deletions(-) > > diff --git a/drivers/mtd/nand/spi/toshiba.c b/drivers/mtd/nand/spi/toshiba.c > index 0812655..0916962 100644 > --- a/drivers/mtd/nand/spi/toshiba.c > +++ b/drivers/mtd/nand/spi/toshiba.c > @@ -25,19 +25,19 @@ static SPINAND_OP_VARIANTS(write_cache_variants, > static SPINAND_OP_VARIANTS(update_cache_variants, > SPINAND_PROG_LOAD(false, 0, NULL, 0)); > > -static int tc58cvg2s0h_ooblayout_ecc(struct mtd_info *mtd, int section, > +static int tc58cxgxsx_ooblayout_ecc(struct mtd_info *mtd, int section, > struct mtd_oob_region *region) > { > - if (section > 7) > + if (section > 0) > return -ERANGE; > > - region->offset = 128 + 16 * section; > - region->length = 16; > + region->offset = mtd->oobsize / 2; > + region->length = mtd->oobsize / 2; > > return 0; > } > > -static int tc58cvg2s0h_ooblayout_free(struct mtd_info *mtd, int section, > +static int tc58cxgxsx_ooblayout_free(struct mtd_info *mtd, int section, > struct mtd_oob_region *region) > { > if (section > 0) > @@ -45,17 +45,17 @@ static int tc58cvg2s0h_ooblayout_free(struct mtd_info *mtd, int section, > > /* 2 bytes reserved for BBM */ > region->offset = 2; > - region->length = 126; > + region->length = mtd->oobsize / 2 - 2; > > return 0; > } > > -static const struct mtd_ooblayout_ops tc58cvg2s0h_ooblayout = { > - .ecc = tc58cvg2s0h_ooblayout_ecc, > - .free = tc58cvg2s0h_ooblayout_free, > +static const struct mtd_ooblayout_ops tc58cxgxsx_ooblayout = { > + .ecc = tc58cxgxsx_ooblayout_ecc, > + .free = tc58cxgxsx_ooblayout_free, > }; > > -static int tc58cvg2s0h_ecc_get_status(struct spinand_device *spinand, > +static int tc58cxgxsx_ecc_get_status(struct spinand_device *spinand, > u8 status) > { > struct nand_device *nand = spinand_to_nand(spinand); > @@ -94,15 +94,66 @@ static int tc58cvg2s0h_ecc_get_status(struct spinand_device *spinand, > } > > static const struct spinand_info toshiba_spinand_table[] = { > - SPINAND_INFO("TC58CVG2S0H", 0xCD, > + /* 3.3V 1Gb */ > + SPINAND_INFO("TC58CVG0S3", 0xC2, > + NAND_MEMORG(1, 2048, 128, 64, 1024, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > + /* 3.3V 2Gb */ > + SPINAND_INFO("TC58CVG1S3", 0xCB, > + NAND_MEMORG(1, 2048, 128, 64, 2048, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > + /* 3.3V 4Gb */ > + SPINAND_INFO("TC58CVG2S0", 0xCD, > + NAND_MEMORG(1, 4096, 256, 64, 2048, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > + /* 1.8V 1Gb */ > + SPINAND_INFO("TC58CYG0S3", 0xB2, > + NAND_MEMORG(1, 2048, 128, 64, 1024, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > + /* 1.8V 2Gb */ > + SPINAND_INFO("TC58CYG1S3", 0xBB, > + NAND_MEMORG(1, 2048, 128, 64, 2048, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > + /* 1.8V 4Gb */ > + SPINAND_INFO("TC58CYG2S0", 0xBD, > NAND_MEMORG(1, 4096, 256, 64, 2048, 1, 1, 1), > NAND_ECCREQ(8, 512), > SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > &write_cache_variants, > &update_cache_variants), > - SPINAND_HAS_QE_BIT, > - SPINAND_ECCINFO(&tc58cvg2s0h_ooblayout, > - tc58cvg2s0h_ecc_get_status)), > + 0, > + SPINAND_ECCINFO(&tc58cxgxsx_ooblayout, > + tc58cxgxsx_ecc_get_status)), > }; > > static int toshiba_spinand_detect(struct spinand_device *spinand) >
next prev parent reply other threads:[~2019-01-16 12:58 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-16 5:53 [PATCH] mtd: spinand: Add support for all Toshiba Memory products Yoshio Furuyama 2019-01-16 10:04 ` Miquel Raynal 2019-01-16 10:04 ` Miquel Raynal 2019-01-16 10:42 ` Schrempf Frieder 2019-01-16 10:42 ` Schrempf Frieder 2019-01-16 12:55 ` Schrempf Frieder 2019-01-16 12:55 ` Schrempf Frieder 2019-01-16 12:58 ` Schrempf Frieder [this message] 2019-01-16 12:58 ` Schrempf Frieder 2018-12-25 3:25 ` posting test 2019-01-17 8:42 ` posting test 2019-01-25 12:35 ` Miquel Raynal 2019-01-25 12:35 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d6230005-5dfa-60f9-7eec-87d119aa415d@kontron.de \ --to=frieder.schrempf@kontron.de \ --cc=bbrezillon@kernel.org \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=miquel.raynal@bootlin.com \ --cc=peron.clem@gmail.com \ --cc=richard@nod.at \ --cc=tmcmc-mb-yfuruyama7@ml.toshiba.co.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.