* [PATCH-for-6.1] hw/isa/piix4: Use qdev_get_gpio_in_named() to get ISA IRQ
@ 2021-03-24 18:29 Philippe Mathieu-Daudé
2021-03-25 12:02 ` Richard Henderson
2021-04-15 10:28 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-24 18:29 UTC (permalink / raw)
To: qemu-devel
Cc: Hervé Poussineau, Philippe Mathieu-Daudé, Aurelien Jarno
Since commit 078778c5a55 ("piix4: Add an i8259 Interrupt Controller")
the TYPE_PIIX4_PCI_DEVICE exposes the ISA input IRQs as "isa" alias.
Use this alias to get IRQ for the power management PCI function.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/isa/piix4.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index a50d97834c7..33b94e4511f 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -255,8 +255,9 @@ DeviceState *piix4_create(PCIBus *pci_bus, ISABus **isa_bus, I2CBus **smbus)
pci_create_simple(pci_bus, devfn + 2, "piix4-usb-uhci");
if (smbus) {
*smbus = piix4_pm_init(pci_bus, devfn + 3, 0x1100,
- isa_get_irq(NULL, 9), NULL, 0, NULL);
- }
+ qdev_get_gpio_in_named(dev, "isa", 9),
+ NULL, 0, NULL);
+ }
return dev;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH-for-6.1] hw/isa/piix4: Use qdev_get_gpio_in_named() to get ISA IRQ
2021-03-24 18:29 [PATCH-for-6.1] hw/isa/piix4: Use qdev_get_gpio_in_named() to get ISA IRQ Philippe Mathieu-Daudé
@ 2021-03-25 12:02 ` Richard Henderson
2021-04-15 10:28 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2021-03-25 12:02 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Hervé Poussineau, Aurelien Jarno
On 3/24/21 12:29 PM, Philippe Mathieu-Daudé wrote:
> Since commit 078778c5a55 ("piix4: Add an i8259 Interrupt Controller")
> the TYPE_PIIX4_PCI_DEVICE exposes the ISA input IRQs as "isa" alias.
>
> Use this alias to get IRQ for the power management PCI function.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> hw/isa/piix4.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH-for-6.1] hw/isa/piix4: Use qdev_get_gpio_in_named() to get ISA IRQ
2021-03-24 18:29 [PATCH-for-6.1] hw/isa/piix4: Use qdev_get_gpio_in_named() to get ISA IRQ Philippe Mathieu-Daudé
2021-03-25 12:02 ` Richard Henderson
@ 2021-04-15 10:28 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-15 10:28 UTC (permalink / raw)
To: qemu-devel; +Cc: Hervé Poussineau, Aurelien Jarno
On 3/24/21 7:29 PM, Philippe Mathieu-Daudé wrote:
> Since commit 078778c5a55 ("piix4: Add an i8259 Interrupt Controller")
> the TYPE_PIIX4_PCI_DEVICE exposes the ISA input IRQs as "isa" alias.
>
> Use this alias to get IRQ for the power management PCI function.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/isa/piix4.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks, applied to mips-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-15 10:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 18:29 [PATCH-for-6.1] hw/isa/piix4: Use qdev_get_gpio_in_named() to get ISA IRQ Philippe Mathieu-Daudé
2021-03-25 12:02 ` Richard Henderson
2021-04-15 10:28 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.